Maniphest T294616

Pressing space after inserting an @-mention causes keyboard to close
Closed, ResolvedPublic
Actions

Description

Environment

The behavior described below was observed in the following environments:

Device: iPhone XS
Browser(s): Chrome 95.0.4638.50 and Safari
OS: iOS 15.0.2

Behavior

New Discussion + Reply Tools

Visit a talk page on a mobile device.
- Broken: https://patchdemo.wmflabs.org/wikis/6ce52b531d/w/index.php?title=Talk:Main_Page&mobileaction=toggle_view_mobile
- Fixed: https://patchdemo.wmflabs.org/wikis/357ac7dbeb/w/index.php?title=Talk:Main_Page&mobileaction=toggle_view_mobile
Click a [ reply ] affordance to open the Reply Tool or the Add Discussion affordance to open the New Discussion Tool
Notice the tool of your choosing opens
Tap inside the tool of your choosing's text input area
Ensure you are in the tool's Visual mode
Type @ to open up the username suggestion list
Type in a username of your choosing
Tap within the username suggestion list to insert the username you typed in "Step 7."
Tap the keyboard's space key

Actual
❗️5. The keyboard closes/disappears preventing you from continuing to type

Expected
✅ 5. The keyboard remains open/visible so that you can continue typing

Details

	Subject	Repo	Branch	Lines +/-
	UsernameCompletion: Disable fragment auto-select	mediawiki/extensions/DiscussionTools	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Resolved	None	T278588 Mobile talk page improvements
Resolved	ppelberg	T282638 [RELEASE TICKET] Offer Mobile Reply and New Discussion Tools at Partner Wikis
Resolved	Esanders	T294616 Pressing space after inserting an @-mention causes keyboard to close

Event Timeline

ppelberg created this task.Oct 29 2021, 1:07 AM

ppelberg edited parent tasks, added: T282638: [RELEASE TICKET] Offer Mobile Reply and New Discussion Tools at Partner Wikis; removed: T270536: Introduce the Reply Tool on mobile.Oct 29 2021, 11:25 PM

Change 736316 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] UsernameCompletion: Disable fragment auto-select

https://gerrit.wikimedia.org/r/736316

gerritbot added a project: Patch-For-Review.Nov 2 2021, 11:35 PM

ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team (Tracking).Nov 2 2021, 11:38 PM

ppelberg moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

https://patchdemo.wmflabs.org/wikis/357ac7dbeb/w/index.php?title=Talk:Main_Page&mobileaction=toggle_view_mobile

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Nov 4 2021, 3:25 PM

Change 736316 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] UsernameCompletion: Disable fragment auto-select

https://gerrit.wikimedia.org/r/736316

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 4 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2021, 5:10 PM

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Nov 4 2021, 5:28 PM

DLynch added a project: Editing QA.

QA note: This can be tested on https://en.wikipedia.beta.wmflabs.org/, but won't be available on production wikis until we enable the mobile interface there (T270536#7483693).

VPuffetMichel added a project: Goal.Nov 9 2021, 12:16 AM

I tested this and captured the behavior. https://photos.app.goo.gl/iArXRJk2ruwpfhEi8.

QutieBot added a project: QTE-TestingOverview.Nov 17 2021, 6:06 PM

QutieBot moved this task from Inbox to Rummana on the QTE-TestingOverview board.

In T294616#7510297, @EAkinloose wrote:

I tested this and captured the behavior. https://photos.app.goo.gl/iArXRJk2ruwpfhEi8.

This issue is specific to the behaviour of the on-screen keyboard on mobile devices, but I don't see that in the screen capture.

Here's a recording of how it works on an actual device. My observation here is that any interaction with the keyboard closes it. "space" and "delete" is captured in the recording.

ppelberg assigned this task to Esanders.Nov 18 2021, 6:15 PM

ppelberg moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

Esanders updated the task description. (Show Details)Nov 18 2021, 6:30 PM

Thanks @Esanders for updating the task description. Here is a recording of the expected behaviour.

EAkinloose moved this task from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.Nov 18 2021, 9:37 PM

EAkinloose edited projects, added Verified; removed Editing QA.

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

ppelberg closed this task as Resolved.Nov 20 2021, 1:37 AM

Pressing space after inserting an @-mention causes keyboard to close Closed, ResolvedPublicActions