Page MenuHomePhabricator
Create Task
Maniphest T297362

Sticky header: ensure correct language presentation on multi-language wikis
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
Dec 9 2021, 10:37 AM
Tags
Referenced Files
F34888720: Screen Shot 2021-12-18 at 1.33.22 PM.png
Dec 18 2021, 9:35 PM
F34888719: Screen Shot 2021-12-18 at 1.34.34 PM.png
Dec 18 2021, 9:35 PM
F34888710: Screen Shot 2021-12-18 at 1.29.43 PM.png
Dec 18 2021, 9:31 PM
F34888711: Screen Shot 2021-12-18 at 1.28.35 PM.png
Dec 18 2021, 9:31 PM
F34869289: Screen Shot 2021-12-09 at 2.39.31 PM.png
Dec 9 2021, 1:40 PM
F34869269: Screen Shot 2021-12-09 at 2.37.13 PM.png
Dec 9 2021, 1:40 PM
Subscribers
Aklapper
bwang
Edtadros
IKhitron
Jdlrobson

Description

Steps to reproduce

See AC3: https://phabricator.wikimedia.org/T289815#7556851.

  1. Go to commons and enable the sticky header using the url parameter
  2. Scroll down the page until the sticky header appears

Expected: no language switcher appears
Observed: language switcher appears with "0 languages"

Wikis with multiple languages within the same wiki (eg. commons, wikidata) are not expected to show the language switcher within the sticky header

Developer notes

Happens with:

$wgVectorLanguageInHeader =  [
	"logged_in" => false,
	"logged_out" => false,
];

$wgMFMwApiContentProviderBaseUri = "https://commons.wikimedia.org/w/api.php";

QA Results - Beta

ACStatusDetails
1✅T297362#7579291

QA Results - Prod

ACStatusDetails
1✅T297362#7579294

Details

SubjectRepoBranchLines +/-
Don't add language button to sticky header on pages without languages in contentmediawiki/skins/Vectormaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva triaged this task as High priority.Dec 9 2021, 10:37 AM
ovasileva created this task.
ovasileva mentioned this in T289815: Sticky header: Add language switching functionality to sticky header.
ovasileva removed subscribers: • alexhollender_WMF, XanonymusX, • nray and 7 others.
ovasileva added subscribers: bwang, Jdlrobson.Dec 9 2021, 1:40 PM

@Jdlrobson, @bwang - noting some more oddity around this one. Either way, not a blocker for deployment as wikidata and commons have been removed from the deploy list:

ovasileva assigned this task to Jdlrobson.Dec 9 2021, 6:12 PM
Jdlrobson updated the task description. (Show Details)Dec 9 2021, 8:04 PM
gerritbot added a comment.Dec 9 2021, 8:08 PM

Change 745596 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Don't add language button to sticky header on pages without languages in content

https://gerrit.wikimedia.org/r/745596

gerritbot added a project: Patch-For-Review.Dec 9 2021, 8:08 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Dec 9 2021, 8:09 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
LGoto moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.Dec 13 2021, 6:33 PM
LGoto set the point value for this task to 2.
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 13 2021, 6:42 PM
gerritbot added a comment.Dec 13 2021, 8:28 PM

Change 745596 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Don't add language button to sticky header on pages without languages in content

https://gerrit.wikimedia.org/r/745596

cjming assigned this task to Edtadros.Dec 13 2021, 8:40 PM
cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 13 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 13 2021, 9:10 PM
ovasileva mentioned this in T294926: Sticky header: full feature QA.Dec 17 2021, 3:19 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 18 2021, 9:31 PM

Test Result - Beta

Status: ✅ PASS
Environment: betacommons, betawikidata
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to commons and enable the sticky header using the url parameter
Scroll down the page until the sticky header appears
✅ AC1: Expected: no language switcher appears

Screen Shot 2021-12-18 at 1.29.43 PM.png (932×859 px, 89 KB)

Screen Shot 2021-12-18 at 1.28.35 PM.png (932×859 px, 346 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Dec 18 2021, 9:35 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: commons, wikidata
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to commons and enable the sticky header using the url parameter
Scroll down the page until the sticky header appears
✅ AC1: Expected: no language switcher appears

Screen Shot 2021-12-18 at 1.34.34 PM.png (932×859 px, 227 KB)

Screen Shot 2021-12-18 at 1.33.22 PM.png (932×859 px, 130 KB)

Edtadros updated the task description. (Show Details)Dec 18 2021, 9:36 PM
ovasileva closed this task as Resolved.Dec 20 2021, 3:06 PM
bwang mentioned this in T298705: Sticky header: ensure language button only shows when multiple languages.Jan 6 2022, 4:26 PM
IKhitron subscribed.Jan 12 2022, 12:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits