Current language shown in missing languages banner
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Nux
	May 5 2022, 8:17 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Use Vector 2022.
Open en.wiki article e.g. https://en.wikipedia.org/wiki/Simone_Giertz
Open language menu.
Type in "English".

What happens?:

The message Cx-uls-relevant-languages-banner-text-multiple-missing is shown with "English" which is the current page lang. I think this is related with T290972

Missing in English, română and more
This page is not available in the language you searched for.

And when I click on "...and more":

This page is missing in some languages you may know. You can translate it in minutes!
+ English + română

Same thing on Polish Wikipedia (when you search for Polish/polski).

What should have happened instead?:

Current page language should be omitted from this search / suggestions.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

MediaWiki 1.39.0-wmf.10 (6139f98)
01:02, 3 May 2022

FF 99

I have some modifications, but I know this happens for other users too.

Details

	Subject	Repo	Branch	Lines +/-
	ULS entrypoint: Do not show current language, fix domain redirects	mediawiki/extensions/ContentTranslation	wmf/1.39.0-wmf.10	+17 -19
	ULS entrypoint: Do not show current language, fix domain redirects	mediawiki/extensions/ContentTranslation	master	+17 -19

Customize query in gerrit

Related Objects

Mentioned In: T298032: Surface missing languages in current mobile language selector to access Section Translation
Mentioned Here: T298032: Surface missing languages in current mobile language selector to access Section Translation
T290972: Add "relevant missing languages" to the current language selector
rMW6139f984d223: Merge "Move bad file tests to mediaParserTests"

Event Timeline

Nux created this task.May 5 2022, 8:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2022, 8:17 PM

Nux updated the task description. (Show Details)May 5 2022, 8:19 PM

Also note that the menu is not working.

When I click on "English" I'm redirected to a wrong domain (should be en): https://english.wikipedia.org/wiki/Special:ContentTranslation?from=en&to=English&page=Simone+Giertz
When I click on "română" I'm redirected to a wrong domain: https://română.wikipedia.org/wiki/Special:ContentTranslation?from=en&to=English&page=Simone+Giertz
When I click on "•••" I see an error:
1. TypeError: domain is null
2. getPageUrl https://en.wikipedia.org/wiki/Simone_Giertz line 10 > injectedScript:22
3. getCXUrl https://en.wikipedia.org/wiki/Simone_Giertz line 10 > injectedScript:24
4. redirectToCX https://en.wikipedia.org/wiki/Simone_Giertz line 10 > injectedScript:18
5. jQuery 4

Same error in debug mode:

22:26:11.720 TypeError: domain is null
load.php:11768:11
    jQuery 66
    doPropagation https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:880
    (asynchroniczny: requestIdleCallback handler)
    setAndPropagate https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:937
    markModuleReady https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1316
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1323
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1328
    queueModuleScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1185
    onerror https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1156
    (asynchroniczny: EventHandlerNonNull)
    addScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1151
    queueModuleScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1180
    queueModuleScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1196
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1327
    runScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1334
    execute https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1474
    doPropagation https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:864
    (asynchroniczny: requestIdleCallback handler)
    setAndPropagate https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:937
    markModuleReady https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1316
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1323
    nestedAddScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1328
    queueModuleScript https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1185
    onerror https://en.wikipedia.org/w/load.php?debug=1&lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:1156

data from intake-analytics.wikimedia.org :-)

hasty=true :-)
client_dt: 2022-05-05T20:25:41.473Z
token: 1571e7521e18e05c7084

Aklapper triaged this task as High priority.May 6 2022, 7:03 AM

Aklapper merged a task: T307670: All "Translate this page" entrypoint links in compact language selector go to non-existing hostnames.

Aklapper added projects: ContentTranslation, Regression.

Aklapper added a subscriber: Unite_together.

KartikMistry subscribed.May 6 2022, 7:51 AM

Change 789775 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789775

gerritbot added a project: Patch-For-Review.May 6 2022, 8:38 AM

Func merged a task: T307786: ContentTranslation is suggesting unexisting "missing languages".May 6 2022, 2:27 PM

Func added a subscriber: valerio.bozzolan.

Change 789832 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/extensions/ContentTranslation@wmf/1.39.0-wmf.10] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789832

Aklapper merged a task: T307835: The prompt in "Languages" is incorrectly displayed when using Vector 2022.May 7 2022, 2:09 PM

Aklapper added subscribers: Yining_Chen, MilkyDefer, Stang.

KartikMistry merged a task: T307858: CX is not working in the new language selector.May 8 2022, 8:34 AM

KartikMistry added subscribers: Ladsgroup, ngkountas.

Change 789832 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.39.0-wmf.10] ULS entrypoint: Do not show current language, fix domain redirects

Reason:

Will cherry-pick new change.

https://gerrit.wikimedia.org/r/789832

santhosh claimed this task.May 9 2022, 5:38 AM

santhosh added a project: Language-Team (Language-2022-April-June).

santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-April-June) board.

Change 789832 restored by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.39.0-wmf.10] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789832

Change 789775 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789775

Change 789832 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.39.0-wmf.10] ULS entrypoint: Do not show current language, fix domain redirects

https://gerrit.wikimedia.org/r/789832

Mentioned in SAL (#wikimedia-operations) [2022-05-09T13:37:15Z] <taavi@deploy1002> Synchronized php-1.39.0-wmf.10/extensions/ContentTranslation/modules/entrypoints: Backport: [[gerrit:789832|ULS entrypoint: Do not show current language, fix domain redirects (T307745 T298032)]] (duration: 00m 50s)