Page MenuHomePhabricator
Create Task
Maniphest T316915

It's 2022 and we still can't use Parsoid in production
Closed, InvalidPublic
Actions

Description

In order to generate data needed for DiscussionTools permalinks, we need to parse newly saved talk pages using Parsoid. I was going to use the ParsoidOutputAccess service in MW for this, but at the last minute I was told it has some caching problems, and had to switch to using HTTP requests to Parsoid/RESTBase like we do in VisualEditor (see: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/815289, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/771974/21..22). It turns out that this barely works.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT314973 Improve Topic Subscription support for discussions that are merged, moved, or deleted
 OpenNoneT315050 Enable people to visit the page the discussion they were subscribed to has been moved to
 OpenNoneT318449 [Tracking] Improve the sharing of MediaWiki content
 OpenNoneT318446 [Tracking] Improve sharing link functionality of pages
 OpenNoneT315507 Introduce support for topic and comment permanent links within the Android and iOS apps
 OpenNoneT349353 Expose comment/topic permanent links on Special:Contributions
 OpenNoneT265269 Assist with linking to other comments within the Reply Tool
 ResolvedppelbergT302011 [Release Ticket] Introduce permalinks on wikitext talk pages
 ResolvedDLynchT365974 Deploy talk page permalinks to en.wiki
 ResolvedmatmarexT315353 Create database tables for permalinks in production wikis, and enable the feature
 ResolvedmatmarexT315510 Start maintenance script to backfill talk page comment database
 InvalidmatmarexT316915 It's 2022 and we still can't use Parsoid in production
 ResolvedPRODUCTION ERRORmatmarexT315383 MWException: Error contacting the Parsoid/RESTBase server (HTTP 404) from DiscussionTools (on closed wikis)
 ResolvedmatmarexT315688 MWException: Error contacting the Parsoid/RESTBase server (HTTP 404) from DiscussionTools (on open wikis) – permalinks unavailable for some edits
 ResolvedmatmarexT315689 MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): (no message) from DiscussionTools (on private wikis) – permalinks unavailable
 ResolvedmatmarexT316914 MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): Rerenders for this article are blacklisted in the config from DiscussionTools – permalinks unavailable for some pages

Event Timeline

matmarex created this task.Sep 2 2022, 4:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2022, 4:22 AM
matmarex added subtasks: T315383: MWException: Error contacting the Parsoid/RESTBase server (HTTP 404) from DiscussionTools (on closed wikis), T315688: MWException: Error contacting the Parsoid/RESTBase server (HTTP 404) from DiscussionTools (on open wikis) – permalinks unavailable for some edits, T315689: MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): (no message) from DiscussionTools (on private wikis) – permalinks unavailable, T316914: MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): Rerenders for this article are blacklisted in the config from DiscussionTools – permalinks unavailable for some pages.Sep 2 2022, 4:23 AM
matmarex added a parent task: T315510: Start maintenance script to backfill talk page comment database.
Amire80 awarded a token.Sep 2 2022, 7:00 AM
ppelberg closed subtask T315689: MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): (no message) from DiscussionTools (on private wikis) – permalinks unavailable as Resolved.Oct 22 2022, 12:41 AM
ppelberg closed subtask T316914: MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): Rerenders for this article are blacklisted in the config from DiscussionTools – permalinks unavailable for some pages as Resolved.Oct 28 2022, 11:23 PM
ppelberg closed subtask T315688: MWException: Error contacting the Parsoid/RESTBase server (HTTP 404) from DiscussionTools (on open wikis) – permalinks unavailable for some edits as Resolved.Oct 28 2022, 11:35 PM
matmarex closed this task as Invalid.Nov 3 2022, 8:00 PM
matmarex claimed this task.

I ended up adding fallbacks to ParsoidOutputAccess in cases where the HTTP requests to Parsoid/RESTBase fail (see subtasks). They're rare enough that the lack of caching isn't a problem.

I'm still hopeful that we will be able to replace this with a single reliable method, but I don't think this task is helpful any more. I was in a bad mood when filing it ;)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits