Page MenuHomePhabricator

Suggested edit question mark overlaps with fixed width toggle
Closed, ResolvedPublic1 Estimated Story Points

Description

The fixed width toggle created in T319449 overlaps with the suggested edit question mark. The question mark is also considerably bigger. Both are functional, but going forward we'll likely want to think about how we coordinate and use this area.

QA steps

Expected:
There are two controls in the bottom right corner

Actual:
There are two overlapping controls

Screen Shot 2022-11-07 at 4.10.10 PM.png (1×2 px, 558 KB)

Screen Shot 2022-11-07 at 4.18.06 PM.png (190×158 px, 8 KB)

Developer notes

One possible option is to add an explicit Vector menu here that extensions can look for.
e.g.

var item = mw.util.addPortletLink('p-bottom-navigation-bar', '#url", "Label", "id-used-to-create-menu-icon");
if (!item) {
  // menu doesn't exist.. keep doing what you are doing.
}

Screen Shot 2022-11-07 at 4.16.20 PM.png (1×2 px, 559 KB)

A quick fix would be to add a skin style that relocates the element in Vector 2022.

  1. open questions
  2. Is the size difference a problem?
  3. Do we want these icons stacked vertically or horizontally?

Event Timeline

Jdlrobson created this task.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Edtadros.

Yes, we would still want the question mark to be shown as this is moreso a starting point to edit than reading. This help icon appears in reading mode when a Growth experiments selects a (non-structured task) Suggested edit to work on, where the question mark opens up the guidance panel giving them guidance to start editing.

Speaking to @ovasileva earlier, we discussed that may be preferable to not show the toggle in this situation instead.
Adding in a Growth eng @kostajh - is there an easy way for Web to know when the guidance panel appears in Read mode and not show toggle button here?

Yes, we would still want the question mark to be shown as this is moreso a starting point to edit than reading. This help icon appears in reading mode when a Growth experiments selects a (non-structured task) Suggested edit to work on, where the question mark opens up the guidance panel giving them guidance to start editing.

For the QA steps noted, I am not sure it makes sense to include the query parameter arbitrarily. As Rita noted, it's only added when the user is following a specific workflow (clicking on a task from Special:Homepage) and in that scenario, the help panel appears expanded.

Speaking to @ovasileva earlier, we discussed that may be preferable to not show the toggle in this situation instead.
Adding in a Growth eng @kostajh - is there an easy way for Web to know when the guidance panel appears in Read mode and not show toggle button here?

(FWIW this came up in another context, with an overlap with ContentTranslation feedback, T211803.)

Web team could look for #mw-ge-help-panel-cta-button to know if the button is there.

I am not sure if we have a task for it, but one idea that Growth team has been talking about is making "help button" / "help panel" first class concepts in MediaWiki, so there would be a standard region in the skin where the markup would be output. And then presumably we could also have some convenience methods in a mediawiki.help module like mw.isHelpButtonVisible() and mw.showHelpButton(), mw.isHelpPanelOpen(), etc etc.

Change 855063 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Hide width toggle when performing suggested edit

https://gerrit.wikimedia.org/r/855063

Change 855063 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide width toggle when performing suggested edit

https://gerrit.wikimedia.org/r/855063

ovasileva triaged this task as Medium priority.Nov 15 2022, 8:43 PM
ovasileva updated the task description. (Show Details)

Hi @kostajh, I can no longer see the fixed width toggle when in Suggested Edit mode. Please confirm if this has been removed as suggested in @RHo's comment?

image.png (1×2 px, 1 MB)

Hi @kostajh, I can no longer see the fixed width toggle when in Suggested Edit mode. Please confirm if this has been removed as suggested in @RHo's comment?

image.png (1×2 px, 1 MB)

Yes, it was removed in https://gerrit.wikimedia.org/r/855063

Hello! I understand correctly that the toggle will be unavailable in all spaces where the help panel is enabled in reading mode? It's just for ruwiki, for example, NS Wikipedia, User and Help. The most active namespaces, and I would like to see a switch there, I think.

The max width preference is available on Special:Preferences page and will still apply to pages with the help icon.

We'll be looking at data to understand how people want to use this feature (perhaps the toggle is redundant if people either opt in or opt out across all pages)

@Jdlrobson @kostajh @ovasileva I noticed a small bug:

expected: when I enter edit mode the full-width toggle goes away and the suggest edit button appears
unexpected: when I exit edit mode the full-width toggle does not reappear

@Jdlrobson @kostajh @ovasileva I noticed a small bug:

expected: when I enter edit mode the full-width toggle goes away and the suggest edit button appears
unexpected: when I exit edit mode the full-width toggle does not reappear

Looked into the issue on wmf.12:
(1) described in @alexhollender_WMF comment - the full-width toggle disappear after exiting VE. A page needs to reload (or Read should be clicked twice) for the toggle to re-appear
(2) When Add link (structured) edit is being published, the toggle will momentarily appear before the post-edit dialog loads.

If a user enters the Source editor, and then exits - the full-width toggle reappears without any issues.

Otherwise, the full-width toggle looks good; it doesn't interfere with the Help button or with the layout of other pages (checked Special:MentorDashboard, Special:EditGrowthConfig, Special:ManageMentors, and RC/Watchlist).

LGoto set the point value for this task to 1.Dec 5 2022, 6:33 PM

@ovasileva suggest a new ticket if you want to address the issue above. The main focus with this initial pass was to do the minimum work possible so they didn't clash,