Hi @Sgs - @KStoller-WMF and I went over all strings and QQQ today so the spreadsheet has all the finalised copy for adding and updating. Thanks!

In T322890#8418423, @RHo wrote:

Hi @Sgs - @KStoller-WMF and I went over all strings and QQQ today so the spreadsheet has all the finalised copy for adding and updating. Thanks!

I'm sorry I am late commenting here–and we don't need this for the release next week–but while we have our attention here: could we please come up with copy to show in the impact module when you are viewing the Impact module for a user other than yourself?

We allow users to view impact data for other users in Special:Impact/{username} . At the top it has Showing impact data for {Showing impact data for OllieMacaluso} but it would be better to have alternative strings. I think in many cases it would just involve dropping "Your"/"you've"/"You" from text strings. Ideally, we could find ways to reduce "your/you've/you" language and use a single string, e.g. use "Impact" instead of "Your impact", or "Recent activity (last 60 days)" instead of "Your recent activity (last 60 days)" to reduce translator burden and code complexity.

This would also be relevant for T219025: Impact Module Extensibility: allow transcluding Special:Impact on wikitext pages with {{Special:Impact/username}}: if a user wants to show off their impact data by transcluding the module on their user page, the text needs to be generic.

In T322890#8419275, @kostajh wrote:

In T322890#8418423, @RHo wrote:

Hi @Sgs - @KStoller-WMF and I went over all strings and QQQ today so the spreadsheet has all the finalised copy for adding and updating. Thanks!

I'm sorry I am late commenting here–and we don't need this for the release next week–but while we have our attention here: could we please come up with copy to show in the impact module when you are viewing the Impact module for a user other than yourself?

We allow users to view impact data for other users in Special:Impact/{username} . At the top it has Showing impact data for {Showing impact data for OllieMacaluso} but it would be better to have alternative strings. I think in many cases it would just involve dropping "Your"/"you've"/"You" from text strings. Ideally, we could find ways to reduce "your/you've/you" language and use a single string, e.g. use "Impact" instead of "Your impact", or "Recent activity (last 60 days)" instead of "Your recent activity (last 60 days)" to reduce translator burden and code complexity.

This would also be relevant for T219025: Impact Module Extensibility: allow transcluding Special:Impact on wikitext pages with {{Special:Impact/username}}: if a user wants to show off their impact data by transcluding the module on their user page, the text needs to be generic.

Yes that makes sense, though I would like to propose keeping the module heading as Your impact for the personalised tone, and when the module is shown in Special:Impact the module header replaces Your impact with $Username: Impact.
There's about 12 strings that refer to gender which I have added a non-2nd person alternative (not including unactivated strings and some "more info" popups as these seem fine to keep as is) in case this is non-controversial to include this week, and then it'd save having translation done twice.

Change 860986 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: update copy texts based on copy doc v0.2

https://gerrit.wikimedia.org/r/860986

Change 860987 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: use 2nd person copy texts in Special:Impact/<username>

https://gerrit.wikimedia.org/r/860987

Change 860986 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: update copy texts based on copy doc v0.2

https://gerrit.wikimedia.org/r/860986

Change 861342 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: use plural in pageviews chart title

https://gerrit.wikimedia.org/r/861342

Change 861347 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: inject username value in ErrorDisplay

https://gerrit.wikimedia.org/r/861347

Change 861342 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: use plural in pageviews chart title

https://gerrit.wikimedia.org/r/861342

In T322890#8419751, @RHo wrote:

There's about 12 strings that refer to gender which I have added a non-2nd person alternative (not including unactivated strings and some "more info" popups as these seem fine to keep as is) in case this is non-controversial to include this week, and then it'd save having translation done twice.

Thanks for adding these, when gerrit 860987 is merged all copy texts including the "other person" ones for Special:Impact/username should be in place.

Derived from @Tgr code review comments:

is isSuggestedEditsActivatedForUser about the current user, or the user whose data is displayed? I think the current user makes more sense. Or we could just treat the user as always activated when another user looks at their stats - the call to action for activating suggested edits doesn't really make sense in that context (and it leaks private information, although a pretty harmless one).

We've realized when a user (eg: user1 ) visits another user's impact page (eg: Special:Impact/user2) AND user2 has not edited yet they would get the module on its unactivated state (screenshot "Current") and has the problems mentioned above. The proposal is to show the module as activated (screenshot "No changes"), and maybe hide some of the empty sections ( screenshots "Proposal A & B" ).

Current	No changes	Proposal A	Proposal B
		{F36259380}

Does that sound ok @KStoller-WMF ?

That sounds good to me!
A simplified version, like "Proposal B," is my preference, but I'm fine with "No changes" if we want to keep it simple.
(I don't see a difference between "No changes" and "Proposal A").

In T322890#8524151, @KStoller-WMF wrote:

That sounds good to me!
A simplified version, like "Proposal B," is my preference, but I'm fine with "No changes" if we want to keep it simple.
(I don't see a difference between "No changes" and "Proposal A").

Apologies, I updated Proposal A, the only change there is no "Articles list" section is added. Implementing Proposal B.

Change 860987 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: use third person copy texts in Special:Impact/<username>

https://gerrit.wikimedia.org/r/860987