Steps to replicate the issue (include links if applicable):
https://en.wikipedia.org/wiki/Special:MyContributions
QA Results - Prod
AC | Status | Details |
---|---|---|
1 | ✅ | T327715#8576414 |
TheDJ | |
Jan 23 2023, 9:42 PM |
F36571438: Screenshot 2023-01-31 at 2.13.36 PM.png | |
Jan 31 2023, 10:21 PM |
F36571437: Screenshot 2023-01-31 at 2.18.08 PM.png | |
Jan 31 2023, 10:21 PM |
F36455947: LintHint box in the wrong part of the grid.png | |
Jan 23 2023, 10:00 PM |
F36455921: Screenshot 2023-01-23 at 22.41.15.png | |
Jan 23 2023, 9:42 PM |
Steps to replicate the issue (include links if applicable):
https://en.wikipedia.org/wiki/Special:MyContributions
AC | Status | Details |
---|---|---|
1 | ✅ | T327715#8576414 |
This seems like high prio to me, we can't show this to all logged in users like this (and another reminder as to why eternal beta's are bad).
This is also happening with the LintHint tool (https://en.wikipedia.org/wiki/User:PerfektesChaos/js/lintHint). Its output, which is supposed to appear in the grid section that contains the article title, is appearing in the upper right. Something has maybe changed in the grid; I can't tell if the grid has a bug or if all of these tools need to be told to put their output in a new place.
Change 882749 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@master] Add extra grid-area for content translation extension
@Jonesey95 regarding linthint I raised this on https://de.wikipedia.org/wiki/Benutzer_Diskussion:PerfektesChaos/js/lintHint
Hi @Pginer-WMF @santhosh relatively urgent ping here - the contributions page seems to add 2 headers to the page and that's causing some issues with the latest iteration of the layout, which we missed in QA due to the fact ContentTranslation is in beta and this was a very specific page. This is not compatible with our current direction with the Vector skin and we'd like to discuss this more and understand more about what would be a better approach going forward, preferably using our existing APIs.
Several options that come to mind:
In the short term we've arranged a short term fix to keep the status quo which we'll backport tomorrow, but we'd prefer this not to become the long term solution.
Thanks in advance!
Thanks @Jdlrobson for flagging this. The intention is to replace this with the new Contribute entry point (T322740) as you mentioned in your 2nd bullet point above. That will provide a more clean, extensible and consistent integration.
In terms of next steps, once instrumentation is in place (T321386) we plan to do a small launch on mobile (T319362), and consider enablement on desktop after it (using the responsive adjustments from T321550).
I am creator of lintHint mentioned above. This tool, some more of mine and I guess a pile of other tools are affected by the Vector 2022 change.
First thing to remedy all these issues is to agree upon a long-term method supported by all skins and mobile how to place any large message in full width of content area on top of every content.
In earlier times there has been some mw.util.message() feature (or something like that, IIRC) which did exactly what is required now, but it has been removed many years ago in favour of mw.notification() (or something like that).
A similar-looking problem has been reported with Preview and the 2017 Wikitext Editor: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&curid=3252662&diff=1135371060&oldid=1135370646#Preview_broken_on_2017_wikitext_editor
Change 882749 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Add temporary extra grid-area for content translation extension
Change 883212 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@wmf/1.40.0-wmf.19] Add temporary extra grid-area for content translation extension
Change 883217 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@wmf/1.40.0-wmf.20] Add temporary extra grid-area for content translation extension
Change 883217 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.40.0-wmf.20] Add temporary extra grid-area for content translation extension
Change 883212 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.40.0-wmf.19] Add temporary extra grid-area for content translation extension
Mentioned in SAL (#wikimedia-operations) [2023-01-24T22:37:56Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:883212|Add temporary extra grid-area for content translation extension (T327715)]], [[gerrit:883217|Add temporary extra grid-area for content translation extension (T327715)]]
Mentioned in SAL (#wikimedia-operations) [2023-01-24T22:39:43Z] <samtar@deploy1002> jdrewniak and samtar: Backport for [[gerrit:883212|Add temporary extra grid-area for content translation extension (T327715)]], [[gerrit:883217|Add temporary extra grid-area for content translation extension (T327715)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet
Mentioned in SAL (#wikimedia-operations) [2023-01-24T22:47:01Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:883212|Add temporary extra grid-area for content translation extension (T327715)]], [[gerrit:883217|Add temporary extra grid-area for content translation extension (T327715)]] (duration: 09m 04s)
Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Buttons appear above the user contributions title.