Page MenuHomePhabricator
Create Task
Maniphest T32956

Make ResourceLoader a standalone library
Open, LowPublic
Actions

Description

Frontend

mw.loader is naturally quite separate from other MediaWiki JS modules. Mainly, because it has to - it's the first thing that loads.

  • Implement an abstraction for mw.loader (e.g. factory function or class)? Or find another way to inject MW-specific config (e.g. where load.php is mounted).
  • ???

Progress:

Backend

When ResourceLoader was first written, and shortly before this task was filed, it was mostly MW-agnostic.

Having said that, a few things have crept in over the years.

Original task description

Just like the backend, the front-end should be less tied into MediaWiki base as well.

It sounds more complicated than it really is though. All we need to do is move mw.loader into a separate file and create an instance of it in mw.loader.

It's already an object constructor, except that right now it is instantly-instantiating an anonymous object constructor (this.loader = new (function(){ ... }));

Details

Reference
bz30956
SubjectRepoBranchLines +/-
CitoidDataModule: Avoid use of global ResourceLoader::inDebugModemediawiki/extensions/Citoidmaster+2 -5
ResourceLoader: Migrate wfGetDB call to ICP and move to WikiModulemediawiki/coremaster+21 -27
Keep the test language code 'en-rtl' out of resourceloadermediawiki/coremaster+8 -2
ResourceLoader: Make internal encodeJsonForScript privatemediawiki/coremaster+1 -3
ResourceLoader: Remove makeMessageSetScript() methodmediawiki/coremaster+2 -12
SearchnamespaceTokenModule: Avoid global ResourceLoader::inDebugModemediawiki/extensions/AdvancedSearchmaster+1 -2
ve-score: Switch from Xml::encodeJsCall to RL\Content::encodeJsonmediawiki/extensions/Scoremaster+11 -12
ResourceLoader: Switch Image.php to injected log channelmediawiki/corewmf/1.39.0-wmf.19+2 -1
ResourceLoader: Switch Image.php to injected log channelmediawiki/coremaster+2 -1
ResourceLoader: Let Image throw RuntimeException instead of MWExceptionmediawiki/coremaster+3 -4
resourceloader: Decouple some internal constructor argsmediawiki/coremaster+73 -70
resourceloader: Remove Xml::encodeJsCall() from test casemediawiki/coremaster+2 -5
resourceloader: Improve wgResourceLoaderMaxage docs, minor clean upmediawiki/coremaster+71 -75
resourceloader: Remove support for $algo param in FileContentsHashermediawiki/coremaster+32 -35
resourceloader: Decouple FileContentsHasher from MW ObjectCachemediawiki/coremaster+1 -1
resourceloader: Remove internal debug check in makeLoaderImplementScript()mediawiki/coremaster+8 -49
maintenance: Use 'ResoureLoader' service instead of unstable ctor callmediawiki/extensions/GlobalCssJsmaster+2 -4
resourceloader: Remove obsolete logic for handheld=yes pageviewsmediawiki/coremaster+32 -73
resourceloader: Require a Config object in ResourceLoader::__construct()mediawiki/coremaster+4 -6
resourceloader: Export ResourceModuleSkinStyles as extension attributemediawiki/coremaster+36 -23
resourceloader: Export ResourceModules as extension attributemediawiki/coremaster+13 -14
resourceloader: Replace Xml::encodeJsCall by encodeJsonForScriptmediawiki/coremaster+27 -38
resourceloader: Replace some Xml::encodeJs calls with RL's own encodeJsonmediawiki/coremaster+100 -108
resourceloader: Switch Xml::encodeJsCall call in getDeprecationInformationmediawiki/coremaster+4 -7
resourceloader: Deprecate ResourceLoaderContext::getConfig and ::getLoggermediawiki/coremaster+11 -2
resourceloader: Warn on ResourceLoader::construct without Configmediawiki/coremaster+39 -34
resourceloader: Move remaining module registrations to ServiceWiringmediawiki/corewmf/1.34.0-wmf.1+22 -22
resourceloader: Move remaining module registrations to ServiceWiringmediawiki/coremaster+22 -22
resourceloader: Remove needless MW-specific fallbackmediawiki/coremaster+10 -8
resourceloader: Move registration of Resources.php to ServiceWiringmediawiki/coremaster+5 -10
resourceloader: Move registering of custom sources to ServiceWiringmediawiki/coremaster+10 -14
resourceloader: Replace ResourceLoaderDebug config use with contextmediawiki/coremaster+8 -10
resourceloader: Instantiate main class via ServiceWiringmediawiki/coremaster+45 -18
Show related patches Customize query in gerrit

Revisions and Commits

rMW MediaWiki
rMW450da07f3a39 resourceloader: Remove MW cacheEpoch from module version hash
rMWdc3fc6cf81ec resourceloader: Audit use of JSON encoding and use json_encode directly
rMW0138f69bc04f resourceloader: Don't localise hidden exception
rMW19349af14016 resourceloader: Don't localise hidden exception

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 13 2019, 8:00 PM
Fomafix mentioned this in T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor.Jun 18 2019, 7:55 AM
gerritbot added a comment.Jun 19 2019, 2:40 PM

Change 517873 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Switch Xml::encodeJsCall call in getDeprecationInformation

https://gerrit.wikimedia.org/r/517873

gerritbot added a project: Patch-For-Review.Jun 19 2019, 2:40 PM
gerritbot added a comment.Jun 20 2019, 10:50 AM

Change 517873 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Switch Xml::encodeJsCall call in getDeprecationInformation

https://gerrit.wikimedia.org/r/517873

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.11; 2019-06-26); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 20 2019, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 11:11 AM
Krinkle updated the task description. (Show Details)Jul 14 2019, 7:27 PM
gerritbot added a comment.Jul 16 2019, 12:16 AM

Change 523371 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Replace some Xml::encodeJs calls with RL's own encodeJson

https://gerrit.wikimedia.org/r/523371

gerritbot added a project: Patch-For-Review.Jul 16 2019, 12:16 AM
gerritbot added a comment.Jul 16 2019, 6:26 AM

Change 523371 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Replace some Xml::encodeJs calls with RL's own encodeJson

https://gerrit.wikimedia.org/r/523371

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.14; 2019-07-16); removed MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jul 16 2019, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 16 2019, 7:10 AM
gerritbot added a comment.Sep 10 2019, 6:30 AM

Change 535354 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] resourceloader: Replace Xml::encodeJsCall by encodeJsonForScript

https://gerrit.wikimedia.org/r/535354

gerritbot added a project: Patch-For-Review.Sep 10 2019, 6:30 AM
Fomafix subscribed.Sep 10 2019, 7:44 AM
gerritbot added a comment.Sep 11 2019, 3:54 AM

Change 535354 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Replace Xml::encodeJsCall by encodeJsonForScript

https://gerrit.wikimedia.org/r/535354

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.23; 2019-09-17); removed MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Sep 11 2019, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2019, 4:10 AM
gerritbot added a comment.Mar 9 2020, 8:14 PM

Change 578382 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Export ResourceModuleSkinStyles as extension attribute

https://gerrit.wikimedia.org/r/578382

gerritbot added a project: Patch-For-Review.Mar 9 2020, 8:14 PM
gerritbot added a comment.Mar 9 2020, 8:23 PM

Change 578383 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Export ResourceModules as extension attribute

https://gerrit.wikimedia.org/r/578383

Krinkle mentioned this in T247265: Export extension.json "ResourceModules" as attribute instead of config.Mar 9 2020, 8:26 PM
gerritbot added a comment.Mar 30 2020, 11:24 PM

Change 578382 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Export ResourceModuleSkinStyles as extension attribute

https://gerrit.wikimedia.org/r/578382

gerritbot added a comment.Mar 30 2020, 11:26 PM

Change 578383 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Export ResourceModules as extension attribute

https://gerrit.wikimedia.org/r/578383

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2020, 12:10 AM
DannyS712 subscribed.Jul 13 2020, 5:41 AM
Krinkle closed subtask T88914: CSSMin library calls global function wfExpandUrl() as Resolved.Nov 13 2020, 9:11 PM
Krinkle added a subtask: T273247: Publish wikimedia/minify as its own repo and package.Jan 28 2021, 11:18 PM
Jdforrester-WMF closed subtask T273247: Publish wikimedia/minify as its own repo and package as Resolved.Feb 25 2021, 8:05 PM
Krinkle added a subtask: T190129: Consolidate language metadata into a 'language-data' library and use in MediaWiki.Mar 18 2021, 12:04 AM

Marking T190129 as subtask. While resourceloader will most likely not use language-data directly (it takes lang and dir parameters instead), I'd like to be able to document wikimedia/language-data as a suggested package for any consumer that uses it in multilingual context since we don't want to encourage consumers to maintain their own lang->direction map.

Krinkle removed a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Mar 18 2021, 1:52 AM
Krinkle updated the task description. (Show Details)
gerritbot added a comment.Mar 18 2021, 5:04 PM

Change 673308 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Require a Config object in ResourceLoader::__construct()

https://gerrit.wikimedia.org/r/673308

gerritbot added a project: Patch-For-Review.Mar 18 2021, 5:04 PM
gerritbot added a comment.Mar 24 2021, 10:02 PM

Change 673308 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Require a Config object in ResourceLoader::__construct()

https://gerrit.wikimedia.org/r/673308

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 24 2021, 11:00 PM
gerritbot added a comment.Jun 2 2021, 10:10 PM

Change 523967 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Keep the test language code 'en-rtl' out of resourceloader

https://gerrit.wikimedia.org/r/523967

R4356th subscribed.Jun 18 2021, 4:21 PM
Krinkle closed subtask T225992: Get language fallback chain from URL parameter instead of from Language::getFallbacksFor as Declined.Aug 24 2021, 7:04 PM
Krinkle closed subtask T277728: Deprecate non-injected accesss to ResourceLoaderModule::getConfig as Resolved.Sep 2 2021, 7:21 PM
gerritbot added a comment.Oct 9 2021, 1:16 AM

Change 728728 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] resourceloader: Remove internal debug check in makeLoaderImplementScript()

https://gerrit.wikimedia.org/r/728728

gerritbot added a comment.Oct 9 2021, 1:48 AM

Change 728758 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] resourceloader: Remove obsolete logic for handheld=yes pageviews

https://gerrit.wikimedia.org/r/728758

gerritbot added a comment.Oct 13 2021, 10:28 PM

Change 728758 merged by jenkins-bot:

[mediawiki/core@master] resourceloader: Remove obsolete logic for handheld=yes pageviews

https://gerrit.wikimedia.org/r/728758

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 13 2021, 11:00 PM
gerritbot added a comment.Nov 11 2021, 1:48 AM

Change 738047 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] resourceloader: Remove support for $algo param in FileContentsHasher

https://gerrit.wikimedia.org/r/738047

gerritbot added a comment.Nov 14 2021, 12:43 AM

Change 738568 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/GlobalCssJs@master] maintenance: Use 'ResoureLoader' service instead of unstable ctor call

https://gerrit.wikimedia.org/r/738568

gerritbot added a comment.Nov 15 2021, 3:48 AM

Change 738600 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] resourceloader: Improve wgResourceLoaderMaxage docs, minor clean up

https://gerrit.wikimedia.org/r/738600

gerritbot added a comment.Nov 15 2021, 1:32 PM

Change 738568 merged by jenkins-bot:

[mediawiki/extensions/GlobalCssJs@master] maintenance: Use 'ResoureLoader' service instead of unstable ctor call

https://gerrit.wikimedia.org/r/738568

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.9; 2021-11-16); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Nov 15 2021, 2:00 PM
gerritbot added a comment.Nov 17 2021, 1:18 AM

Change 728728 merged by jenkins-bot:

[mediawiki/core@master] resourceloader: Remove internal debug check in makeLoaderImplementScript()

https://gerrit.wikimedia.org/r/728728

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 17 2021, 2:00 AM
gerritbot added a comment.Nov 19 2021, 4:56 PM

Change 740206 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] resourceloader: Decouple FileContentsHasher from MW ObjectCache

https://gerrit.wikimedia.org/r/740206

gerritbot added a comment.Nov 23 2021, 3:40 AM

Change 740206 merged by jenkins-bot:

[mediawiki/core@master] resourceloader: Decouple FileContentsHasher from MW ObjectCache

https://gerrit.wikimedia.org/r/740206

gerritbot added a comment.Dec 13 2021, 8:33 PM

Change 738047 merged by jenkins-bot:

[mediawiki/core@master] resourceloader: Remove support for $algo param in FileContentsHasher

https://gerrit.wikimedia.org/r/738047

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.13; 2021-12-13); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 13 2021, 9:00 PM
gerritbot added a comment.Jan 6 2022, 7:33 PM

Change 738600 merged by jenkins-bot:

[mediawiki/core@master] resourceloader: Improve wgResourceLoaderMaxage docs, minor clean up

https://gerrit.wikimedia.org/r/738600

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.17; 2022-01-10); removed MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Jan 6 2022, 8:00 PM
gerritbot added a comment.Jan 6 2022, 9:02 PM

Change 751995 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] resourceloader: Remove Xml::encodeJsCall() from test case

https://gerrit.wikimedia.org/r/751995

gerritbot added a comment.Feb 15 2022, 11:36 PM

Change 751995 merged by jenkins-bot:

[mediawiki/core@master] resourceloader: Remove Xml::encodeJsCall() from test case

https://gerrit.wikimedia.org/r/751995

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.23; 2022-02-21); removed MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Feb 16 2022, 12:00 AM
gerritbot added a comment.Apr 3 2022, 5:34 PM

Change 776355 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] [WIP] resourceloader: Decouple some internal constructor args

https://gerrit.wikimedia.org/r/776355

gerritbot added a comment.Jun 6 2022, 1:05 AM

Change 776355 merged by jenkins-bot:

[mediawiki/core@master] resourceloader: Decouple some internal constructor args

https://gerrit.wikimedia.org/r/776355

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 6 2022, 2:00 AM
Universal_Omega subscribed.Jun 10 2022, 8:07 PM
gerritbot added a comment.Jun 21 2022, 11:26 PM

Change 807234 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Let Image throw RuntimeException instead of MWException

https://gerrit.wikimedia.org/r/807234

gerritbot added a comment.Jun 22 2022, 12:24 AM

Change 807234 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Let Image throw RuntimeException instead of MWException

https://gerrit.wikimedia.org/r/807234

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.18; 2022-06-27); removed MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 22 2022, 1:00 AM
gerritbot added a comment.Jul 7 2022, 12:40 AM

Change 811791 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Switch Image.php to injected log channel

https://gerrit.wikimedia.org/r/811791

gerritbot added a comment.Jul 8 2022, 4:02 AM

Change 812108 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@wmf/1.39.0-wmf.19] ResourceLoader: Switch Image.php to injected log channel

https://gerrit.wikimedia.org/r/812108

gerritbot added a comment.Jul 8 2022, 4:15 AM

Change 811791 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Switch Image.php to injected log channel

https://gerrit.wikimedia.org/r/811791

gerritbot added a comment.Jul 9 2022, 1:38 AM

Change 812108 merged by jenkins-bot:

[mediawiki/core@wmf/1.39.0-wmf.19] ResourceLoader: Switch Image.php to injected log channel

https://gerrit.wikimedia.org/r/812108

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 12 2022, 5:01 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.19; 2022-07-04); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 6:02 AM
Krinkle mentioned this in T36738: ResourceLoader should use context/config instead of global variables.Jul 27 2022, 2:58 AM
gerritbot added a comment.Sep 8 2022, 1:29 PM

Change 830865 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Score@master] ve-score: Switch from Xml::encodeJsCall to RL\Content::encodeJson

https://gerrit.wikimedia.org/r/830865

Krinkle updated the task description. (Show Details)Sep 8 2022, 1:29 PM
gerritbot added a comment.Sep 10 2022, 2:45 AM

Change 830865 merged by jenkins-bot:

[mediawiki/extensions/Score@master] ve-score: Switch from Xml::encodeJsCall to RL\Content::encodeJson

https://gerrit.wikimedia.org/r/830865

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 10 2022, 3:00 AM
Krinkle mentioned this in T329330: TypeError: Cannot read properties of null (reading 'toLowerCase') at at mw.language.getData.Feb 14 2023, 11:21 PM
gerritbot added a comment.Mar 6 2023, 1:37 AM

Change 894232 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Citoid@master] CitoidDataModule: Avoid use of global ResourceLoader::inDebugMode

https://gerrit.wikimedia.org/r/894232

gerritbot added a comment.Mar 6 2023, 1:43 AM

Change 894233 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/AdvancedSearch@master] SearchnamespaceTokenModule: Avoid global ResourceLoader::inDebugMode

https://gerrit.wikimedia.org/r/894233

gerritbot added a comment.Mar 6 2023, 1:53 AM

Change 894234 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Remove makeMessageSetScript() method

https://gerrit.wikimedia.org/r/894234

gerritbot added a comment.Mar 6 2023, 1:55 AM

Change 894235 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Make internal encodeJsonForScript private

https://gerrit.wikimedia.org/r/894235

gerritbot added a comment.Mar 6 2023, 8:24 AM

Change 894233 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] SearchnamespaceTokenModule: Avoid global ResourceLoader::inDebugMode

https://gerrit.wikimedia.org/r/894233

gerritbot added a comment.Mar 6 2023, 8:28 AM

Change 894232 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] CitoidDataModule: Avoid use of global ResourceLoader::inDebugMode

https://gerrit.wikimedia.org/r/894232

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.26; 2023-03-06); removed MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Mar 6 2023, 9:00 AM
gerritbot added a comment.Mar 6 2023, 6:07 PM

Change 894234 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Remove makeMessageSetScript() method

https://gerrit.wikimedia.org/r/894234

gerritbot added a comment.Mar 7 2023, 8:43 PM

Change 894235 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Make internal encodeJsonForScript private

https://gerrit.wikimedia.org/r/894235

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.27; 2023-03-13); removed MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).Mar 9 2023, 6:00 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 8 2023, 5:17 PM
Krinkle edited projects, added MediaWiki-Platform-Team (Radar); removed Patch-Needs-Improvement, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), MW-1.39-notes (1.39.0-wmf.19; 2022-07-04), MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Performance-Team.Aug 28 2023, 5:55 AM
Krinkle removed subscribers: • Niedzielski, AndyRussG, • TrevorParscal.
gerritbot added a comment.Sep 18 2023, 1:07 PM

Change 523967 abandoned by Krinkle:

[mediawiki/core@master] Keep the test language code 'en-rtl' out of resourceloader

Reason:

Closing per task, change in direction

https://gerrit.wikimedia.org/r/523967

gerritbot added a comment.Mar 9 2024, 9:25 PM

Change 1009595 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Migrate wfGetDB call to ICP and move to WikiModule

https://gerrit.wikimedia.org/r/1009595

gerritbot added a project: Patch-For-Review.Mar 9 2024, 9:25 PM
gerritbot added a comment.Mar 11 2024, 7:51 PM

Change 1009595 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Migrate wfGetDB call to ICP and move to WikiModule

https://gerrit.wikimedia.org/r/1009595

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL