Page MenuHomePhabricator
Create Task
Maniphest T340460

Allow .vue files to be used in Gadgets
Open, Needs TriagePublicFeature
Actions

Description

ResourceLoader currently does not allow .vue files to be used in on-wiki modules (only .js, .css and .json) files. We want to allow .vue files, but we don't want to allow Less (via <style lang="less">) in these, only CSS. This is because we decided not to make Less available in user-authored modules in T56864#6153179, for fear that arbitrary user-authored Less code could take arbitrarily long to execute.

Because all the code for .vue file handling is currently in FileModule, some of it will need to be moved to Module, while preserving the ability of FileModule to allow Less to be used and the ability of WikiModule to forbid it.

  • Add a content model for .vue pages, with the same special treatment as .js pages
  • Move (most) .vue handling code from FileModule to Module
  • Allow .vue pages to be used in WikiModule
  • Do not allow Less to be used in WikiModule (but continue to allow it in FileModule)

Details

SubjectRepoBranchLines +/-
[WIP] Support .vue files in packaged gadgetsmediawiki/extensions/Gadgetsmaster+14 -1
[WIP] Support loading .vue pages in the MediaWiki namespacemediawiki/coremaster+301 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Jun 26 2023, 4:28 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptJun 26 2023, 4:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jun 26 2023, 4:29 PM

Change 907557 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/extensions/Gadgets@master] [WIP] Support .vue files in packaged gadgets

https://gerrit.wikimedia.org/r/907557

gerritbot added a project: Patch-For-Review.Jun 26 2023, 4:29 PM

Change 907556 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] [WIP] Support loading .vue pages in the MediaWiki namespace

https://gerrit.wikimedia.org/r/907556

Catrope mentioned this in T313945: [EPIC] Enable gadget and user-script developers to use Vue and Codex.Jun 26 2023, 4:29 PM
Izno subscribed.Jun 26 2023, 5:20 PM

This is because we decided not to make Less available in user-authored modules in T56864#6153179, for fear that arbitrary user-authored Less code could take arbitrarily long to execute.

Is this not also a concern for Vue, which must be transpiled to Javascript?

Catrope mentioned this in T330349: [Spike] Determine the extent to which the Gadgets extension supports .vue files.Jun 26 2023, 5:40 PM
Tacsipacsi subscribed.Jun 26 2023, 10:26 PM
CCiufo-WMF moved this task from Inbox to Backlog on the Design-System-Team board.Jun 27 2023, 12:39 PM
Izno changed the subtype of this task from "Task" to "Feature Request".Jul 24 2023, 3:15 PM
Michael subscribed.Jul 26 2023, 7:56 PM
Krinkle edited projects, added MediaWiki-Platform-Team (Radar); removed Performance-Team.Aug 17 2023, 1:27 PM
Krinkle moved this task from Inbox to External on the MediaWiki-ResourceLoader board.Aug 21 2023, 4:30 PM
Jdlrobson moved this task from Backlog to Architecture on the MediaWiki-extensions-Gadgets board.Sep 8 2023, 9:41 PM
SD0001 mentioned this in T353174: Specify all source pages in a single array in gadget definitions.Dec 11 2023, 5:15 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Dec 27 2023, 8:06 PM
SD0001 subscribed.Mar 18 2024, 1:01 PM

Upstream, Ace just last month added support for syntax highlighting vue (https://github.com/ajaxorg/ace/pull/5483).

For syntax highlighting in action=view mode though, Pygments doesn't yet support it. But they appear to be open to contribution - https://github.com/pygments/pygments/issues/2111

Jdforrester-WMF subscribed.Mar 18 2024, 1:19 PM
In T340460#9637739, @SD0001 wrote:

Upstream, Ace just last month added support for syntax highlighting vue (https://github.com/ajaxorg/ace/pull/5483).

Brilliant; I just made an Ace update last week for T342387 that includes this feature; it will go out this week, but isn't wired up (compare https://en.wikipedia.beta.wmflabs.org/wiki/User:Foo/Bar.js?action=edit which loads CodeEditor vs. https://en.wikipedia.beta.wmflabs.org/wiki/User:Foo/Bar.vue?action=edit which loads your wikitext editor, so there's a little more work needed to support nice editing of .vue on-wiki pages (the first checklist point in this task's list).

Daimona subscribed.Apr 21 2024, 8:27 AM
Sophivorus awarded a token.May 9 2024, 1:35 PM
Sophivorus subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits