| Mabualruz | |
| Jul 10 2023, 3:38 PM |
| F37136492: Screen Recording 2023-07-11 at 7.21.31 PM.mov.gif | |
| Jul 12 2023, 2:23 AM |
| F37135010: Screenshot 2023-07-10 at 11.11.27 AM.png | |
| Jul 10 2023, 6:16 PM |
| F37134938: image.png | |
| Jul 10 2023, 4:33 PM |
As shown on pixel's https://pixel.wmcloud.org/ portal, when clicking the notifications icon they shrink.
We found:
Echo (3) regressions: https://pixel.wmcloud.org/reports/echo/index.html
Expected: No visual change to icons, overlay opens
Actual:
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T341490#9007530 |
| 2 | ✅ | T341490#9007530 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix echo icon sizing after ULS enhances them | mediawiki/skins/Vector | master | +8 -2 |
This has been caused by the new Codex release. Doing a git bisect I traced it to "Update Codex from v0.13.0 to v0.14.0" Idd664a0a114701286e48a5cd262286e4e31f8766
Specifically the issue seems to be the removal of this rule:
.cdx-button:not(.cdx-button--size-large) {
min-width: 32px;
min-height: 32px;
}Change 936780 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Fix echo icon sizing after ULS enhances them
@AnneT and I spent some time investigating this just now – here's what we think is going on.
The .vector-icon class is also applied to these button elements. That class applies a min-width of 20px to the element, while Codex's cdx-button class applies a min-width of 32px.
Previously the Codex styles won out because of the way we wrote them using :not(). But we thought this was excessively specific and difficult to override downstream, so we changed it here.
Now the Codex min-width style is the same specificity as the conflicting style supplied by vector-icon, and the latter rule wins out presumably due to being later in the source order.
Here's a graphic comparing the specificity of our styles before and after that linked change.
As far as how to address this change, @bwang thinks that he can just go into the appropriate code on the Vector side and apply a correct min-width there. If for some reason this isn't feasible, DST cound consider releasing a Codex version that has our change reverted, but we'll want to re-introduce it in the next release since we believe this is an improvement overall.
Though unfortunate, I do not think this qualifies as a train blocker or as a stand-alone UBN task.
Change 936780 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix echo icon sizing after ULS enhances them
From https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Major_stylistic_problems_affecting_all_pages this falls under "For other issues, avoid passing individual judgment from rollback and block decisions."
For context, web team classed this as UBN as we expect it would likely lead to many duplicate bug tickets being raised by community members (with a high likelihood of mis-classing it as UBN) as it rolled out. We judged it should be simple enough to fix today before the train rolls out so we decided to make it a train blocker rather than risk a predictable delay. This reminded me personally of a similar issue T300100 - where a UI regression in Timeless with no loss of functionality caused disruption during a deployment week.
The issue is now patched so this is no longer a deployment blocker.
Yes, I see that update was added in as part of T300169. I stand by my comment. UBN is a big hammer that disrupts lots of people's time, and should be used sparingly.
Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Visit https://en.wikipedia.beta.wmflabs.org/wiki/Spain?vectorzebradesign=0&safemode=1
Click the notifications icon
Expected:
✅ AC1: No visual change to icons,
✅ AC2: overlay opens
