I'll call out that we added a new property that we called confirmation for the message that a user would see after interacting with the new actions, Donate now and Maybe later.

@spatton @Pcoombe Thanks for this! Personally I would like to avoid adding confirmation text to give apps more control, and instead have this config only power the text on the modal. We can bundle the confirmation text translations into the app.

Our apps have the reminder delay hardcoded into the app as 1 day. If @JTannerWMF decides she wants to change it to three days, we now have to release a new app version. Changing the config confirmation text to "We will remind you in three days" would break older versions out in the wild (which still have a 1 day delay), so then we would need to bump the config version so that only apps pointing to version 2 will use the new "three days" text. You could argue that perhaps we could have both a confirmation key and a reminderDelayDays key for that flexibility. If we do that, what if later @JTannerWMF wants "Maybe later" to kick off three reminders for 3, 5, and 10 days later. Our config structure breaks again.

Of course this is the whole reason we added a version key here - to change the structure as-needed while retaining older app version structures. I just see a lot more version bumping in our near future once we give the config control over things that happen after tapping a button in the modal. I would like us to avoid taking that on until after the waters have settled a bit on these new flows. Let me know what you think, thanks.

Thanks @Tsevener, great points about compatibility. That's fine to keep the confirmation text translations in the app, and I removed them from the donatewiki JSON.

@Pcoombe great thanks, this all looks good! I updated your Sandbox config with a minor thing - adding an extra <br> before the body text to address some design feedback. Then I copied it over to the testing config that the apps are pointed to for testing (with modified start date easier testing for us), and then copied it over to the donate wiki config.

Please let us know if you have any feedback on structure / etc. and if you'd prefer a different phab task format. Up til now we've created individual tasks for each country and OS.

I'm fine with having it together in one Phab task like you did here and tagging both app backlogs. To echo what Dmitry mentioned in the last meeting, I think app leads should own updating the donate wiki config for now. Maybe a good order of operations would be:

1. FR provides proposed campaign json (can be in your Sandbox config or added directly to the Phab task description)
2. Apps engineers copy it into the test wiki config, with a modified start date if-needed for easier testing. They take screenshots for final OK.
3. Apps engineering leads then copy FR campaign json into donate wiki.

I'll post a couple of screenshots of what it's looking like so far. Thanks!

Here's some screenshots! I tried to get both extreme screen sizes and middle screen sizes. Also tagging @cmadeo:

iPhone SE:

iPhone 15:

iPad 9.7 inch:

iPad 12.9 inch:

In terms of clipping on the SE size - the content is scrollable, if that helps any.

Screenshots from Android devices:

Samsung S9 (small device)

Samsung S23 Ultra (large device)

Huawei Tablet

The content is also scrollable, and the position of buttons and footer text is fixed. cc @cmadeo

https://github.com/wikimedia/wikipedia-ios/pull/4651

In T348278#9231645, @Tsevener wrote:

In terms of clipping on the SE size - the content is scrollable, if that helps any.

@Tsevener would it be possible at all to add a bottom blur (similar to the scrolling behavior on onboarding) to this modal? It can be hard to tell on some languages and sizes that there's more content below.

@cmadeo We decided to add a flashing scroll indicator when the campaign modal appears in planning yesterday, since it's a much lighter lift / behavior provided by the platform. It's slightly better, though the red border distracts from it, in my opinion. Maybe we can make a followup task for this one?

Flashing scroll indicator PR: https://github.com/wikimedia/wikipedia-ios/pull/4653

Thanks @Tsevener, happy to have a follow-up task for the blur, I'll make a child ticket

Looks good to me on 7.4.3 (2811)

Looks good on Android as well on 2.7.50455-r-2023-10-10