Page MenuHomePhabricator

[IP Masking] Temporary account to registered account creation flow (layout fixes)
Closed, ResolvedPublic

Description

Follow up to: T300273: [IP Masking] Temporary account to registered account creation flow

Fix issues discovered in testing:
I listed below two issues (probably it makes sense to keep them as part of this task's scope since they are directly related to the re-designed Create account page for temp users).
(1) The benefit block is obscured by the tools side menu

  • a temp user clicks on Create account and gets redirected to the Login page where the benefits block is not presented:
Screen Shot 2023-11-08 at 2.41.40 PM.png (1×3 px, 383 KB)
Screen Shot 2023-11-08 at 2.26.55 PM.png (1×3 px, 566 KB)
  • since uncollapsed side menus are present by default, users will not discover the benefits block

(2) The benefits block on mobile (as @Tgr mentioned in https://phabricator.wikimedia.org/T300273#9052228) is visible and it has some display issues:

Screen Shot 2023-11-08 at 2.30.37 PM.png (1×1 px, 258 KB)

Note: the regular Create account side block text is presented reasonably well:

Screen Shot 2023-11-08 at 2.32.25 PM.png (1×854 px, 149 KB)

Event Timeline

KStoller-WMF triaged this task as Medium priority.
KStoller-WMF created this task.
KStoller-WMF moved this task from Inbox to Backlog on the Growth-Team board.
KStoller-WMF added a subscriber: Cyndymediawiksim.
Cyndymediawiksim changed the task status from Open to In Progress.Nov 14 2023, 11:39 AM
Cyndymediawiksim claimed this task.

Change 974190 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/skins/MinervaNeue@master] Temporary account to registered account creation flow (layout fixes)

https://gerrit.wikimedia.org/r/974190

Test wiki created on Patch demo by Martin Urbanec using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/714bf7b9f0/w

Checked patchdemo

(1) The benefit block is obscured by the tools side menu

DONE

Screen Shot 2023-11-27 at 2.16.47 PM.png (1×3 px, 606 KB)

The overflow issue (2) looks better but it still needs to be fully addressed as @Urbanecm_WMF mentioned in https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/974190/.

Screen Shot 2023-11-27 at 2.18.09 PM.png (1×902 px, 285 KB)

Test wiki created on Patch demo by Martin Urbanec (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/2eced17bbc/w

Change 980896 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/core@master] Temporary account to registered account creation flow (layout fixes)

https://gerrit.wikimedia.org/r/980896

Change 974190 abandoned by Cyndywikime:

[mediawiki/skins/MinervaNeue@master] Temporary account to registered account creation flow (layout fixes)

Reason:

This patch has been abandoned in favour of this one : https://gerrit.wikimedia.org/r/c/mediawiki/core/+/980896

https://gerrit.wikimedia.org/r/974190

Checked the following patchdemo:

Test wiki created on Patch demo by Martin Urbanec (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/2eced17bbc/w

Still there are some overlapping for the title:

Screen Shot 2023-12-06 at 5.41.43 PM.png (1×804 px, 195 KB)

Waiting for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/980896 to be merged,

Change 980896 merged by jenkins-bot:

[mediawiki/core@master] Temporary account to registered account creation flow (layout fixes)

https://gerrit.wikimedia.org/r/980896