Page MenuHomePhabricator
Create Task
Maniphest T350923

[IP Masking] Temporary account to registered account creation flow (layout fixes)
Closed, ResolvedPublic
Actions

Assigned To
Cyndymediawiksim
Authored By
KStoller-WMF
Nov 10 2023, 12:06 AM
Tags
Referenced Files
F41615270: Screen Shot 2023-12-20 at 6.09.08 PM.png
Dec 21 2023, 2:15 AM
F41569373: Screen Shot 2023-12-06 at 5.41.43 PM.png
Dec 7 2023, 1:45 AM
F41541442: Screen Shot 2023-11-27 at 2.18.09 PM.png
Nov 27 2023, 10:23 PM
F41541440: Screen Shot 2023-11-27 at 2.16.47 PM.png
Nov 27 2023, 10:23 PM
F41474308: Screen Shot 2023-11-08 at 2.32.25 PM.png
Nov 10 2023, 12:06 AM
F41474303: Screen Shot 2023-11-08 at 2.30.37 PM.png
Nov 10 2023, 12:06 AM
F41474274: Screen Shot 2023-11-08 at 2.26.55 PM.png
Nov 10 2023, 12:06 AM
F41474267: Screen Shot 2023-11-08 at 2.41.40 PM.png
Nov 10 2023, 12:06 AM
Subscribers
Aklapper
Cyndymediawiksim
Etonkovidova
JFernandez-WMF
KStoller-WMF
• Niharika
Sgs
View All 9 Subscribers

Description

Follow up to: T300273: [IP Masking] Temporary account to registered account creation flow

Fix issues discovered in testing:
I listed below two issues (probably it makes sense to keep them as part of this task's scope since they are directly related to the re-designed Create account page for temp users).
(1) The benefit block is obscured by the tools side menu

  • a temp user clicks on Create account and gets redirected to the Login page where the benefits block is not presented:
Screen Shot 2023-11-08 at 2.41.40 PM.png (1×3 px, 383 KB)
Screen Shot 2023-11-08 at 2.26.55 PM.png (1×3 px, 566 KB)
  • since uncollapsed side menus are present by default, users will not discover the benefits block

(2) The benefits block on mobile (as @Tgr mentioned in https://phabricator.wikimedia.org/T300273#9052228) is visible and it has some display issues:

Screen Shot 2023-11-08 at 2.30.37 PM.png (1×1 px, 258 KB)

Note: the regular Create account side block text is presented reasonably well:

Screen Shot 2023-11-08 at 2.32.25 PM.png (1×854 px, 149 KB)

Details

SubjectRepoBranchLines +/-
Temporary account to registered account creation flow (layout fixes)mediawiki/coremaster+3 -15
Temporary account to registered account creation flow (layout fixes)mediawiki/skins/MinervaNeuemaster+30 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

KStoller-WMF removed Cyndymediawiksim as the assignee of this task.Nov 10 2023, 12:06 AM
KStoller-WMF triaged this task as Medium priority.
KStoller-WMF created this task.
KStoller-WMF moved this task from Inbox to Backlog on the Growth-Team board.
KStoller-WMF added a subscriber: Cyndymediawiksim.
Cyndymediawiksim changed the task status from Open to In Progress.Nov 14 2023, 11:39 AM
Cyndymediawiksim claimed this task.
gerritbot added a comment.Nov 14 2023, 1:59 PM

Change 974190 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/skins/MinervaNeue@master] Temporary account to registered account creation flow (layout fixes)

https://gerrit.wikimedia.org/r/974190

gerritbot added a project: Patch-For-Review.Nov 14 2023, 1:59 PM
PatchDemoBot added a comment.Nov 23 2023, 3:10 PM

Test wiki created on Patch demo by Martin Urbanec using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/714bf7b9f0/w

Etonkovidova attached a referenced file: F41474308: Screen Shot 2023-11-08 at 2.32.25 PM.png. (Show Details)Nov 27 2023, 10:11 PM
Etonkovidova attached a referenced file: F41474303: Screen Shot 2023-11-08 at 2.30.37 PM.png. (Show Details)
Etonkovidova attached a referenced file: F41474274: Screen Shot 2023-11-08 at 2.26.55 PM.png. (Show Details)
Etonkovidova attached a referenced file: F41474267: Screen Shot 2023-11-08 at 2.41.40 PM.png. (Show Details)
Etonkovidova added a comment.Nov 27 2023, 10:23 PM

Checked patchdemo

(1) The benefit block is obscured by the tools side menu

DONE

Screen Shot 2023-11-27 at 2.16.47 PM.png (1×3 px, 606 KB)

The overflow issue (2) looks better but it still needs to be fully addressed as @Urbanecm_WMF mentioned in https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/974190/.

Screen Shot 2023-11-27 at 2.18.09 PM.png (1×902 px, 285 KB)

PatchDemoBot added a comment.Dec 4 2023, 10:43 AM

Test wiki created on Patch demo by Martin Urbanec (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/2eced17bbc/w

gerritbot added a comment.Dec 6 2023, 4:07 PM

Change 980896 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/core@master] Temporary account to registered account creation flow (layout fixes)

https://gerrit.wikimedia.org/r/980896

gerritbot added a comment.Dec 6 2023, 4:32 PM

Change 974190 abandoned by Cyndywikime:

[mediawiki/skins/MinervaNeue@master] Temporary account to registered account creation flow (layout fixes)

Reason:

This patch has been abandoned in favour of this one : https://gerrit.wikimedia.org/r/c/mediawiki/core/+/980896

https://gerrit.wikimedia.org/r/974190

Etonkovidova added a comment.Dec 7 2023, 1:45 AM

Checked the following patchdemo:

In T350923#9378276, @PatchDemoBot wrote:

Test wiki created on Patch demo by Martin Urbanec (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/2eced17bbc/w

Still there are some overlapping for the title:

Screen Shot 2023-12-06 at 5.41.43 PM.png (1×804 px, 195 KB)

Waiting for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/980896 to be merged,

Sgs moved this task from Backlog to Sprint 5 (Growth Team) on the Growth-Team board.Dec 19 2023, 11:54 AM
Sgs edited projects, added Growth-Team (Sprint 5 (Growth Team)); removed Growth-Team.
Sgs moved this task from Incoming to QA on the Growth-Team (Sprint 5 (Growth Team)) board.
gerritbot added a comment.Dec 19 2023, 12:09 PM

Change 980896 merged by jenkins-bot:

[mediawiki/core@master] Temporary account to registered account creation flow (layout fixes)

https://gerrit.wikimedia.org/r/980896

Maintenance_bot removed a project: Patch-For-Review.Dec 19 2023, 12:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 19 2023, 1:00 PM
Etonkovidova closed this task as Resolved.Dec 21 2023, 2:14 AM
Etonkovidova mentioned this in T341839: [QA task] IP masking - temp users testing in production.

Checked on cswiki beta - works as expected:

Screen Shot 2023-12-20 at 6.09.08 PM.png (1×820 px, 218 KB)

Added to T341839: [QA task] IP masking - temp users testing in production.

PatchDemoBot added a comment.Tue, Apr 23, 4:33 PM

Test wiki on Patch demo by Martin Urbanec using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/714bf7b9f0/w/

PatchDemoBot added a comment.Tue, Apr 23, 4:33 PM

Test wiki on Patch demo by Martin Urbanec (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/2eced17bbc/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL