Page MenuHomePhabricator

With parsoid categories are not shown
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
No categories while the article definitely has categories

grafik.png (995×1 px, 392 KB)

What should have happened instead?:
Categories to be shown, similar to seeing it in non-parsoid:

grafik.png (849×1 px, 444 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • I think sometimes it is shown but I can't understand when or where, might be after VE edit that it gets hidden?

Event Timeline

Restricted Application added subscribers: Huji, Aklapper. · View Herald Transcript

Categories are outside of PC to my knowledge, I'm a bit confused how it can possibly even happen.

This is a subset of T310512: Parsoid and the legacy parser should emit exactly the same ParserOutput metadata -- Parsoid isn't currently adding category links to the ParserOutput it generates.

Change 1007899 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/services/parsoid@master] Add category in metadata when parsing links

https://gerrit.wikimedia.org/r/1007899

This is happening for me today at https://en.wikipedia.org/wiki/Template:Random_slideshow on the English Wikipedia. If I switch to non-Parsoid, two normal categories and two hidden categories are shown. If it matters, I am using Vector 2022.

Strangely, I see categories in Preview. Does this mean that even when I have "always render in Parsoid" selected, that my Previews are not being rendered in Parsoid? Or is something more subtle happening here?

In case it is unclear: this should be a show-stopper bug for moving to Parsoid. Categories are necessary display elements on Wikipedia pages. Because some of my gnome work involves ensuring that pages have appropriate categories, I have had to stop testing Parsoid rendering for now and will be able to resume using it only when categories are consistently shown.

Change 1007899 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add category in metadata when parsing links

https://gerrit.wikimedia.org/r/1007899

Change 1011398 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a23

https://gerrit.wikimedia.org/r/1011398

Change 1011398 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a23

https://gerrit.wikimedia.org/r/1011398

Change #1013720 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[integration/visualdiff@master] Remove adaptor to suppress catlinks - Parsoid generates them now

https://gerrit.wikimedia.org/r/1013720

Change #1013720 merged by jenkins-bot:

[integration/visualdiff@master] Remove adaptor to suppress catlinks - Parsoid generates them now

https://gerrit.wikimedia.org/r/1013720

Pending from initial parsoid patch:

  • Tests for
    • [[Category:Foo|{{1x|}}]] (missing sort key)
    • [[Category:Foo|Category:Foo]] (category as sort key)
    • [[Category:Foo|\n]] (newline as sort key)
    • Sort key that is language converted