MediaWiki\Linter\MissingCategoryException: Cannot find id for 'night-mode-unaware-background-color'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	dancy
	Mar 20 2024, 6:44 PM

Description

Error

mwversion: 1.42.0-wmf.22
reqId: 1e0f1214-e0bf-4718-9a6c-5178590f35b8
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   MediaWiki\Linter\MissingCategoryException: Cannot find id for 'night-mode-unaware-background-color'

exception.trace

from /srv/mediawiki/php-1.42.0-wmf.22/extensions/Linter/includes/CategoryManager.php(223)
#0 /srv/mediawiki/php-1.42.0-wmf.22/extensions/Linter/includes/Database.php(182): MediaWiki\Linter\CategoryManager->getCategoryId(string, NULL)
#1 [internal function]: MediaWiki\Linter\Database->buildErrorRow(MediaWiki\Linter\LintError)
#2 /srv/mediawiki/php-1.42.0-wmf.22/extensions/Linter/includes/Database.php(289): array_map(array, array)
#3 /srv/mediawiki/php-1.42.0-wmf.22/extensions/Linter/includes/RecordLintJob.php(60): MediaWiki\Linter\Database->setForPage(array)
#4 /srv/mediawiki/php-1.42.0-wmf.22/extensions/EventBus/includes/JobExecutor.php(80): MediaWiki\Linter\RecordLintJob->run()
#5 /srv/mediawiki/rpc/RunSingleJob.php(60): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#6 {main}

Impact

Thousands of hits for this error when promoting the 1.42.0-wmf.23 train to group1 today.

I'm rolling back the train.

Details

Request URL: https://mw-jobrunner.discovery.wmnet/rpc/RunSingleJob.php

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add inline background color	mediawiki/extensions/Linter	wmf/1.42.0-wmf.22	+11 -0
	Revert "Add inline background color"	mediawiki/extensions/Linter	master	+0 -11

Customize query in gerrit

Related Objects

Mentioned In: T361759: Touch base with Jon and the content transform team about parsoid train blocker
T359205: Deployment Ticket - Linting Rule for Template Style Fixes
Mentioned Here: T359205: Deployment Ticket - Linting Rule for Template Style Fixes

Event Timeline

dancy created this task.Mar 20 2024, 6:44 PM

dancy triaged this task as Unbreak Now! priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2024, 6:44 PM

dancy added a parent task: T354441: 1.42.0-wmf.23 deployment blockers.Mar 20 2024, 6:44 PM

Note that though I rolled 1.42.0-wmf.23 to group1, the errors are being reported against .22

And rolling back the train did not fix the problem. :-(

In T360565#9647065, @dancy wrote:

And rolling back the train did not fix the problem. :-(

Correction. The error rate did drop off eventually after the rollback process reached more servers.

brennen added projects: Content-Transform-Team, MediaWiki-extensions-Linter.Mar 20 2024, 6:54 PM

Zabe subscribed.Mar 20 2024, 6:54 PM

@KSarabia-WMF any thoughts here?

Kim is on PTO this week, but our team is looking at this now! Apologies for the disruption

Ladsgroup subscribed.Mar 20 2024, 6:58 PM

Daimona subscribed.Mar 20 2024, 7:04 PM

dr0ptp4kt subscribed.Mar 20 2024, 7:12 PM

cscott mentioned this in T359205: Deployment Ticket - Linting Rule for Template Style Fixes.Mar 20 2024, 7:15 PM

Change 1012780 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Linter@master] Revert "Add inline background color"

https://gerrit.wikimedia.org/r/1012780

gerritbot added a project: Patch-For-Review.Mar 20 2024, 7:18 PM

This might be a transient; I don't think reverting the Linter extension patch is the solution, I think you need to turn off the lint error in Parsoid. Parsoid is reporting the lint to Linter, and Linter (transiently?) doesn't recognize the category name being given.

Rather than revert that patch, it could be backported to .22

Change 1012780 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Revert "Add inline background color"

https://gerrit.wikimedia.org/r/1012780

I think both Scott and Arlo are right ... we just need to confirm that the names in Parsoid and linter are the same and there is no typo in the names that we overlooked.

Change 1012781 had a related patch set uploaded (by Zabe; author: Kimberly Sarabia):

[mediawiki/extensions/Linter@wmf/1.42.0-wmf.22] Add inline background color

https://gerrit.wikimedia.org/r/1012781

On group 0 (mediawiki.org) https://www.mediawiki.org/wiki/Special:LintErrors/night-mode-unaware-background-color shows lint errors which means this is working right .. and so the errors may have been transient. @Arlolra's suggestion is right.

Parsoid servers get 700 reqs / sec ... so, even if a fraction of those have these new lint error, and if there is a delay in how code is updated / services restarted, you would get these errors. So, backporting to wmf.22 should avoid this.

We've agreed to backport to .22 - thank you so much everybody for all of your help!

Change 1012781 merged by jenkins-bot:

[mediawiki/extensions/Linter@wmf/1.42.0-wmf.22] Add inline background color

https://gerrit.wikimedia.org/r/1012781

Mentioned in SAL (#wikimedia-operations) [2024-03-20T20:20:01Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:1012781|Add inline background color (T359205 T360565)]]

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2024, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-20T20:45:34Z] <catrope@deploy2002> catrope and zabe: Backport for [[gerrit:1012781|Add inline background color (T359205 T360565)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Backport complete and looks good, so this ought to unblock the train.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 20 2024, 9:00 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-20T21:02:59Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:1012781|Add inline background color (T359205 T360565)]] (duration: 42m 57s)

dancy lowered the priority of this task from Unbreak Now! to Medium.Mar 20 2024, 9:50 PM

dancy removed a parent task: T354441: 1.42.0-wmf.23 deployment blockers.

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.24; 2024-03-26); removed MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 21 2024, 1:00 AM

thcipriani moved this task from Untriaged to Mar 2024 on the Wikimedia-production-error board.Mar 21 2024, 3:21 PM

Given that the group1 train rolled forward without further errors of this sort, I'm going to say this is closed.

SToyofuku-WMF mentioned this in T361759: Touch base with Jon and the content transform team about parsoid train blocker.Apr 3 2024, 9:49 PM

MediaWiki\Linter\MissingCategoryException: Cannot find id for 'night-mode-unaware-background-color'Closed, ResolvedPublicPRODUCTION ERRORActions