Regression: mobile watchlist's text overlaps
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Titore
	Oct 9 2024, 3:15 PM

Description

Since 1.43.0-wmf.26, on the mobile watchlist there is noticeable overlap between page names and usernames. The issue has been reported on itwiki. The screenshot below is from testwiki using safemode=1. Caused by T375975

Steps to replicate the issue (include links if applicable):

Login and disable advanced mode (the default experience)
Visit Watchlist
usernames are on wrong line

What happens?:
Items flushed together

Screenshot 2024-10-09 at 5.48.20 PM.png (688×2 px, 138 KB)

What should have happened instead?:
Items stacked on different lines

Screenshot 2024-10-09 at 5.47.34 PM.png (510×2 px, 74 KB)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

It does not happen using advanced mode.

Screenshot From 2024-10-09 16-55-13.png (913×547 px, 116 KB)

Requirement

Ensure that on the mobile watchlist, usernames are displayed on separate lines and do not overlap with page names. The issue of text overlap must be resolved, and usernames should be properly stacked in non-advanced mode.

BDD

Feature: Prevent text overlap on mobile watchlist

  Scenario: Display usernames correctly in mobile watchlist
    Given the user has disabled advanced mode
    When the user visits their watchlist
    Then usernames should be displayed on separate lines, not overlapping with page names

Test Steps

Test Case 1: Verify Correct Display of Usernames in Mobile Watchlist

Log in to the test environment and disable advanced mode.
Visit the Watchlist page.
AC1: Confirm that usernames are displayed on separate lines without overlapping with page names.

QA Results - Beta

AC	Status	Details
1	✅	T376814#10232175

QA Results - Prod

AC	Status	Details
1	✅	T376814#10257284

Details

	Subject	Repo	Branch	Lines +/-
	Fix regressions around use of <bdi> in ChangesList	mediawiki/core	master	+9 -6
	Revert "Use HTML markup instead of bidi control chars in wiki changes"	mediawiki/core	wmf/1.43.0-wmf.26	+25 -29

Customize query in gerrit

Related Objects

Mentioned In: T377246: Verify 1.43.0-wmf.27 deployment
T377533: Recent changes doesn't have space after target title and before the reason part
T377555: Edit comment is misplaced in mobile view
T377503: Username overlaps watched categories
T375657: 1.43.0-wmf.26 deployment blockers
T375975: Reduce relying on hidden direction marks in MediaWiki
Mentioned Here: T377503: Username overlaps watched categories
T375975: Reduce relying on hidden direction marks in MediaWiki

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 9 2024, 3:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Titore renamed this task from Regression: mobile watchlist text overlaps to Regression: mobile watchlist's text overlaps.Oct 9 2024, 3:20 PM

valcio subscribed.Oct 9 2024, 3:22 PM

Titore updated the task description. (Show Details)Oct 9 2024, 3:24 PM

Etonkovidova added a project: Web-Team-Backlog.Oct 10 2024, 12:14 AM

Etonkovidova added a subscriber: Jdlrobson.

Confirmed on wmf.26 - Special:Watchlist on mobile with Advanced mode off displays long title overlapping with a user name row.
NOTES:

The issue seems specific to Special:Watchlist - RecentChanges, Contributions, Notifications do not display the issue.

Screen Shot 2024-10-09 at 5.12.14 PM.png (1×848 px, 155 KB)

wmf.25 doesn't display the issue:

Screen Shot 2024-10-09 at 5.22.32 PM.png (1×870 px, 223 KB)

It looks like the mw-title element is now wrapped in a bdi tag - which was introduced by T375975. Since that task is low priority if we want to treat this a deploy blocker, we should roll back that change for now, and adapt mobile first.

Jdlrobson updated the task description. (Show Details)Oct 10 2024, 12:48 AM

Jdlrobson mentioned this in T375975: Reduce relying on hidden direction marks in MediaWiki.

Jdlrobson added a parent task: T375657: 1.43.0-wmf.26 deployment blockers.

Jdlrobson added subscribers: Ladsgroup, Ebrahim.

Marking as high priority as it's a significant visual regression for all logged-in users on mobile. I think rolling back the lower priority change makes sense.

Jdlrobson mentioned this in T375657: 1.43.0-wmf.26 deployment blockers.Oct 10 2024, 12:52 AM

IKhitron subscribed.Oct 10 2024, 12:57 AM

Agusbou2015 subscribed.Oct 10 2024, 1:02 AM

Change #1079146 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Bring ChangesList user link out of <bdi>

https://gerrit.wikimedia.org/r/1079146

gerritbot added a project: Patch-For-Review.Oct 10 2024, 6:45 AM

https://gerrit.wikimedia.org/r/1079146 should fix this as locally it turns

into

Hopefully that be enough if not guess we should go for revert

@ovasileva: Would you know who could review this patch rather soon, as it's the train deployment window right now?

(How am I supposed to contact this team in real time? Cannot spot it on https://office.wikimedia.org/wiki/Team_interfaces , I don't see contact info on https://www.mediawiki.org/wiki/Reading/Web , and https://phabricator.wikimedia.org/project/profile/67/ says #wikimedia-mobile on IRC which is a strange name.)

If this is really supposed to block the entire deployment train, this should be "Unbreak now" priority instead of "High" priority

Change #1079218 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/core@wmf/1.43.0-wmf.26] Revert "Use HTML markup instead of bidi control chars in wiki changes"

https://gerrit.wikimedia.org/r/1079218

Change #1079218 merged by Aklapper:

[mediawiki/core@wmf/1.43.0-wmf.26] Revert "Use HTML markup instead of bidi control chars in wiki changes"

https://gerrit.wikimedia.org/r/1079218

Mentioned in SAL (#wikimedia-operations) [2024-10-10T08:55:39Z] <aklapper@deploy2002> Started scap sync-world: Backport for [[gerrit:1079218|Revert "Use HTML markup instead of bidi control chars in wiki changes" (T375975 T376814)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-10T08:57:52Z] <aklapper@deploy2002> hashar, aklapper: Backport for [[gerrit:1079218|Revert "Use HTML markup instead of bidi control chars in wiki changes" (T375975 T376814)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.26; 2024-10-08).Oct 10 2024, 9:00 AM

Mentioned in SAL (#wikimedia-operations) [2024-10-10T09:07:49Z] <aklapper@deploy2002> Finished scap sync-world: Backport for [[gerrit:1079218|Revert "Use HTML markup instead of bidi control chars in wiki changes" (T375975 T376814)]] (duration: 12m 09s)

Decided to revert the patch in .26 only per the "Hopefully that be enough if not guess we should go for revert" comment above, as this task was marked as a train blocker and its proposed patch had not been reviewed so far. Removing this task as a train blocker.

Aklapper removed a parent task: T375657: 1.43.0-wmf.26 deployment blockers.Oct 10 2024, 9:13 AM

Test wiki created on Patch demo by Ebrahim using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/fb52d9c14a/w/

Can confirm the patch demo looks good!

In T376814#10216680, @Aklapper wrote:

@ovasileva: Would you know who could review this patch rather soon, as it's the train deployment window right now?

(How am I supposed to contact this team in real time? Cannot spot it on https://office.wikimedia.org/wiki/Team_interfaces , I don't see contact info on https://www.mediawiki.org/wiki/Reading/Web , and https://phabricator.wikimedia.org/project/profile/67/ says #wikimedia-mobile on IRC which is a strange name.)

The quickest way to reach us is the talk-to-web channel on Slack. Thank you for calling this out - we're currently in the process of overhauling some of our team documentation and we'll make a note to make this available and explicit within our documentation.

Jdlrobson moved this task from Incoming to FY2024-25 Q2 Sprint 1 on the Web-Team-Backlog board.Oct 10 2024, 5:17 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q2 Sprint 1); removed Web-Team-Backlog.

Jdlrobson assigned this task to Edtadros.Oct 10 2024, 5:57 PM

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.

How it should look:

Screenshot 2024-10-10 at 2.21.58 PM.png (1×2 px, 218 KB)

How it current looks with new patch:

Screenshot 2024-10-10 at 2.22.07 PM.png (1×2 px, 239 KB)

Adding as blocker for next deploy as this has not been fixed on master - only production.

Jdlrobson added a parent task: T375658: 1.43.0-wmf.27 deployment blockers.Oct 10 2024, 9:28 PM

phuedx unsubscribed.Oct 11 2024, 5:07 PM

Part of the issue that I'm bringing back a dir mark call there even though it doesn't have to be dir mark, a nbsp, zwj, zwnj could do the trick also, one surprising thing I'm seeing with HTML but I guess it has something to do with whitespace collapsing.

Test wiki on Patch demo by Ebrahim using patch(es) linked to this task was deleted:

~~http://patchdemo.wmcloud.org/wikis/fb52d9c14a/w/~~

Ebrahim attached a referenced file: F57606766: A.webm. (Show Details)Oct 12 2024, 2:54 AM

Change #1079146 merged by jenkins-bot:

[mediawiki/core@master] Fix regressions around use of <bdi> in ChangesList

https://gerrit.wikimedia.org/r/1079146

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2024, 3:30 AM

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.27; 2024-10-15); removed MW-1.43-notes (1.43.0-wmf.26; 2024-10-08).Oct 12 2024, 4:00 AM

Jdlrobson removed a parent task: T375658: 1.43.0-wmf.27 deployment blockers.Oct 14 2024, 4:12 PM

ovasileva moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2024-25 Q2 Sprint 2) board.Oct 15 2024, 4:56 PM

Jdlrobson lowered the priority of this task from High to Medium.Oct 15 2024, 8:22 PM

Edtadros updated the task description. (Show Details)Oct 16 2024, 1:39 AM

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Correct Display of Usernames in Mobile Watchlist

Log in and disable advanced mode.
Visit the Watchlist page on the mobile site.
✅ AC1: Confirm that usernames are displayed on separate lines and do not overlap with page names.

Edtadros updated the task description. (Show Details)Oct 16 2024, 1:44 AM

While this looks fixed for the most part, it's still broken for watched categories.

Screenshot From 2024-10-17 15-27-34.png (822×556 px, 100 KB)

Jdlrobson assigned this task to ovasileva.Oct 17 2024, 4:47 PM

I can't see the issue locally so guess I need help for reproducing this

In T376814#10239083, @Ebrahim wrote:

I can't see the issue locally so guess I need help for reproducing this

This happens when you enable showing pages being added or removed from categories.

To reproduce:

add a category to your watchlist;
add a page to said category;
open the desktop watchlist;
add the filter "Category changes";
save the current filter settings and set them as default;
open the mobile watchlist.

Change #1081249 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/skins/MinervaNeue@master] Make sure contributor's name is on its line

https://gerrit.wikimedia.org/r/1081249

Change #1081251 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Remove no longer needed workaround

https://gerrit.wikimedia.org/r/1081251

In T376814#10239188, @Titore wrote:

In T376814#10239083, @Ebrahim wrote:

I can't see the issue locally so guess I need help for reproducing this

This happens when you enable showing pages being added or removed from categories.
[..]

I reproduced this locally, it needed $wgRCWatchCategoryMembership = true; on LocalSettings.php and doesn't happen on default installation of MediaWiki, that 'hist' shows this wasn't a supported use case from a long time ago but I've uploaded my fix anyway which includes removal of two ugly workarounds also in addition to fix of it.

I've opened a new ticket since this looks like a different issue:
T377503

Change #1081249 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/skins/MinervaNeue@master] Make sure contributor's name is on its line

https://gerrit.wikimedia.org/r/1081249

Ebrahim mentioned this in T377555: Edit comment is misplaced in mobile view.Oct 18 2024, 9:10 AM

Pikne mentioned this in T377533: Recent changes doesn't have space after target title and before the reason part.Oct 18 2024, 6:20 PM

Edtadros mentioned this in T377246: Verify 1.43.0-wmf.27 deployment.Oct 18 2024, 7:07 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS
Browser: Chrome
Device: MS
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Correct Display of Usernames in Mobile Watchlist

Log in and disable advanced mode.
Visit the Watchlist page on the mobile site.
✅ AC1: Confirm that usernames are displayed on separate lines and do not overlap with page names.

Edtadros updated the task description. (Show Details)Oct 24 2024, 2:13 AM

	F57621815: Screenshot From 2024-10-17 15-27-34.png
	Oct 17 2024, 1:29 PM

	F57605110: Screenshot 2024-10-10 at 2.22.07 PM.png
	Oct 10 2024, 9:27 PM

	F57605108: Screenshot 2024-10-10 at 2.21.58 PM.png
	Oct 10 2024, 9:27 PM

	F57638254: screenshot 118.png
	Oct 24 2024, 2:12 AM

	F57622220: image.png
	Oct 17 2024, 5:47 PM

	F57618247: screenshot 101.png
	Oct 16 2024, 1:43 AM

	F57606751: A.webm
	Oct 11 2024, 7:31 PM

Regression: mobile watchlist's text overlapsClosed, ResolvedPublicBUG REPORTActions

Description

Requirement

BDD

Test Steps

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Steps

Test Steps

Regression: mobile watchlist's text overlaps
Closed, ResolvedPublicBUG REPORT
Actions