| Fomafix | |
| Nov 18 2012, 1:04 PM |
| F9562: bug42241.patch | |
| Nov 22 2014, 12:44 AM |
Patch for Vector.php
Skin Vector contains <a href="#"></a> for variants and for actions. This generates a annoying link to # when clicking with a middle click or when JavaScript is disabled.
Please remove href="#".
Version: unspecified
Severity: normal
attachment Vector.php.patch ignored as obsolete
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use <div> instead of <a> for action menu | mediawiki/skins/Vector | master | +15 -8 |
Removing href="#" does not solve the problem. That will instead create a link to the current url (and the behaviour is unstable in older browsers).
This is likely a case of a forgotten call to e.preventDefault().
Also, these anchor tags on the headings shouldn't exist afaik. Are they still there? I thought we're styling the <h5> directory now, or at least adding them dynamically.
With e.preventDefault() it is not possible to prevent a middle click to open a new tab at least in Firefox 16 and Opera 12. And when JavaScript is disabled the link is always active. This is annoying.
Why is there a <a href="#"></a>? Would a simple <div></div> be enough?
(In reply to comment #3)
With e.preventDefault() it is not possible to prevent a middle click to open a
new tab at least in Firefox 16 and Opera 12. And when JavaScript is disabled
the link is always active. This is annoying.Why is there a <a href="#"></a>? Would a simple <div></div> be enough?
Yes, as I said already:
(comment #2)
[..] these anchor tags on the headings shouldn't exist.
They are only there for style (blue links, and pointy cursor). Which is already being handled on the javascript side. Without javascript, the links don't belong there.
Patch for Bug 42241
Replace <a href="#"></a> by <div></div>
attachment bug42241.patch ignored as obsolete
Fomafix:
You are welcome to use Developer access
https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
https://www.mediawiki.org/wiki/Git/Tutorial
Putting your branch in Git makes it easier for us to review it quickly.
Patch for Bug 42241
Rebased patch with <h3> instead of <h5>.
Simplified because display: block is default for <div>.
With <div> there is no workaround for Internet Explorer 6 necessary. Tested with Internet Explorer 6.
Attached:
Unfortunately, this patch does not apply cleanly to master.
Fomafix, you can also submit patches using the web-based uploader at https://tools.wmflabs.org/gerrit-patch-uploader . Please use 'Bug: 42241' in your commit message to link it to this bug.
Change 136711 had a related patch set uploaded by Gerrit Patch Uploader:
Vector: Use <div> instead of <a> for action menu
Change 139795 had a related patch set uploaded by Gerrit Patch Uploader:
Use <a> instead of <a href="#"> for JavaScript click events
Change 154453 had a related patch set uploaded by Gerrit Patch Uploader:
Use <div> instead of <a> for action menu
Change 136711 abandoned by Bartosz Dziewoński:
Vector: Use <div> instead of <a> for action menu
Reason:
Thank you.
Because most patches are abandoned, and any solution will involve too much payload just to solve an edge case.
That may be true for https://gerrit.wikimedia.org/r/139795, but that patch isn't really related to this bug, to be honest.
The actual patch for this is https://gerrit.wikimedia.org/r/154453 and it doesn't have this problem (in fact it decreases the payload ever so slightly), although it needs some work. It seems like a worthwhile thing to do, though.
Change 154453 had a related patch set uploaded (by Bartosz Dziewoński):
Use <div> instead of <a> for action menu
Not convinced this needs action. It will also break any script interacting with the menu... again.
Also, as @Krinkle hase pointed out in the patch, divs cannot have focus and thus cannot be navigated using the keyboard. That hurts accessability more then the purported middle-click would.
Then I was partly wrong, and it still presents a problem.
One of the criteria of MediaWiki, is that basic functionality must work without JavaScript. If you can't tab to basic links (without JavaScript), then that functionality is broken.
When JavaScript is disabled the menu is currently not accessible by keyboard only. Was this ever possible? This change does not change the current behavior.
I propose we go ahead and merge https://gerrit.wikimedia.org/r/#/c/154453/
That patch does seem to fix this problem.
Any objections?
Change 154453 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Use <div> instead of <a> for action menu