Page MenuHomePhabricator
Create Task
Maniphest T48248

[Story] Use HTMLForm in the special pages
Closed, ResolvedPublic
Actions

Assigned To
Ricordisamoa
Authored By
jeblad
Mar 17 2013, 8:43 PM
Tags
Referenced Files
F2359975: dopo2-cropped.png
Aug 25 2015, 2:11 PM
F2330752: dopo-cropped.png
Aug 24 2015, 7:31 PM
F2330750: prima-cropped.png
Aug 24 2015, 7:31 PM
Subscribers
Aklapper
Bene
gerritbot
JanZerebecki
jeblad
Ladsgroup
LikeLifer
View All 11 Subscribers
Tokens
"Like" token, awarded by Legoktm.

Description

To get better security the special pages should use HTMLForm especially the special pages for setting some value, that is editing the entity.

Details

Reference
bz46248
SubjectRepoBranchLines +/-
Fixups to OOUI conversion of SpecialModifyEntity and subclassesmediawiki/extensions/Wikibasemaster+14 -8
Convert SpecialModifyEntity and subclasses to HTMLForm in 'ooui' modemediawiki/extensions/Wikibasemaster+227 -299
Convert SpecialItemByTitle to HTMLForm in 'ooui' modemediawiki/extensions/Wikibasemaster+60 -76
Convert SpecialMergeItems to HTMLForm in 'ooui' modemediawiki/extensions/Wikibasemaster+61 -106
Convert SpecialEntitiesWithoutPage to HTMLFormmediawiki/extensions/Wikibasemaster+37 -63
Convert SpecialNewEntity and subclasses to HTMLForm in 'ooui' modemediawiki/extensions/Wikibasemaster+116 -161
Convert SpecialItemDisambiguation to HTMLFormmediawiki/extensions/Wikibasemaster+38 -61
Convert SpecialListProperties to HTMLFormmediawiki/extensions/Wikibasemaster+50 -59
Convert SpecialRedirectEntity to HTMLForm in 'ooui' modemediawiki/extensions/Wikibasemaster+69 -98
Convert SpecialGoToLinkedPage to HTMLFormmediawiki/extensions/Wikibasemaster+36 -57
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
daniel unsubscribed.Aug 26 2015, 2:12 PM
• Jonas added a project: Wikidata-Sprint-2015-08-18.Aug 27 2015, 10:35 AM
• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2015-08-18 board.
• Jonas moved this task from Doing to Review on the Wikidata-Sprint-2015-08-18 board.Aug 27 2015, 12:03 PM
gerritbot added a comment.Aug 27 2015, 5:03 PM

Change 234317 had a related patch set uploaded (by Ricordisamoa):
Convert SpecialRedirectEntity to HTMLForm

https://gerrit.wikimedia.org/r/234317

gerritbot added a comment.Aug 28 2015, 8:43 AM

Change 234317 merged by jenkins-bot:
Convert SpecialRedirectEntity to HTMLForm in 'ooui' mode

https://gerrit.wikimedia.org/r/234317

Ricordisamoa mentioned this in rMEXT46b1feebab46: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 28 2015, 8:43 AM
Addshore mentioned this in rEWBA4c93d7ba13f1: Convert SpecialRedirectEntity to HTMLForm in 'ooui' mode.Aug 28 2015, 8:44 AM
gerritbot added a comment.Aug 28 2015, 9:11 AM

Change 233898 merged by jenkins-bot:
Convert SpecialGoToLinkedPage to HTMLForm

https://gerrit.wikimedia.org/r/233898

Addshore mentioned this in rEWBAe8454a96d124: Convert SpecialGoToLinkedPage to HTMLForm.Aug 28 2015, 9:11 AM
Diffusion mentioned this in rMEXTb84305716686: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 28 2015, 9:11 AM
• Jonas closed this task as Resolved.Aug 28 2015, 9:24 AM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2015-08-18 board.
Ricordisamoa reopened this task as Open.Aug 28 2015, 10:52 AM

Ehm no.
https://gerrit.wikimedia.org/r/233423 is still in review, and Special:EntitiesWithout*, Special:MergeItems, etc. haven't been converted yet.

Ricordisamoa moved this task from Done to Doing on the Wikidata-Sprint-2015-08-18 board.Aug 28 2015, 10:53 AM
gerritbot added a comment.Aug 29 2015, 2:26 PM

Change 234732 had a related patch set uploaded (by Ricordisamoa):
Convert SpecialListProperties to HTMLForm

https://gerrit.wikimedia.org/r/234732

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Aug 31 2015, 10:05 AM
gerritbot added a comment.Sep 1 2015, 9:30 AM

Change 234732 merged by jenkins-bot:
Convert SpecialListProperties to HTMLForm

https://gerrit.wikimedia.org/r/234732

Diffusion mentioned this in rMEXT4c78a0f91cca: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 1 2015, 9:30 AM
• Jonas mentioned this in rEWBA7d9f28421ebf: Convert SpecialListProperties to HTMLForm.Sep 1 2015, 9:30 AM
Lydia_Pintscher added a comment.Sep 1 2015, 3:05 PM

@Ricordisamoa: Can you add a listto the description of the remaining special pages that need conversion? I lost overview tbh :D

Ricordisamoa updated the task description. (Show Details)Sep 1 2015, 3:19 PM
gerritbot added a comment.Sep 1 2015, 4:01 PM

Change 235258 had a related patch set uploaded (by Ricordisamoa):
Convert SpecialEntitiesWithoutPage to HTMLForm

https://gerrit.wikimedia.org/r/235258

Ricordisamoa updated the task description. (Show Details)Sep 1 2015, 4:04 PM
gerritbot added a comment.Sep 2 2015, 2:58 AM

Change 235394 had a related patch set uploaded (by Ricordisamoa):
Convert SpecialItemDisambiguation to HTMLForm

https://gerrit.wikimedia.org/r/235394

Ricordisamoa updated the task description. (Show Details)Sep 2 2015, 2:58 AM
gerritbot added a comment.Sep 2 2015, 6:26 AM

Change 235407 had a related patch set uploaded (by Ricordisamoa):
Convert SpecialNewEntity and subclasses to HTMLForm

https://gerrit.wikimedia.org/r/235407

Ricordisamoa updated the task description. (Show Details)Sep 2 2015, 6:31 AM
gerritbot added a comment.Sep 2 2015, 9:36 AM

Change 235394 merged by jenkins-bot:
Convert SpecialItemDisambiguation to HTMLForm

https://gerrit.wikimedia.org/r/235394

Ricordisamoa mentioned this in rMEXTe6228bcf0b67: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 2 2015, 9:36 AM
Ricordisamoa mentioned this in rEWBA2a25cd4e4038: Convert SpecialItemDisambiguation to HTMLForm.
gerritbot added a comment.Sep 2 2015, 2:41 PM

Change 235407 merged by jenkins-bot:
Convert SpecialNewEntity and subclasses to HTMLForm in 'ooui' mode

https://gerrit.wikimedia.org/r/235407

Ricordisamoa mentioned this in rEWBA8cffac6301ab: Convert SpecialNewEntity and subclasses to HTMLForm in 'ooui' mode.Sep 2 2015, 2:41 PM
Diffusion mentioned this in rMEXTcdefd2535a19: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 2 2015, 2:41 PM
Ricordisamoa updated the task description. (Show Details)Sep 2 2015, 2:45 PM
gerritbot added a comment.Sep 2 2015, 2:51 PM

Change 235258 merged by jenkins-bot:
Convert SpecialEntitiesWithoutPage to HTMLForm

https://gerrit.wikimedia.org/r/235258

Diffusion mentioned this in rMEXT9a4af9d6b225: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 2 2015, 2:51 PM
Ricordisamoa mentioned this in rEWBAc2133ed6510c: Convert SpecialEntitiesWithoutPage to HTMLForm.Sep 2 2015, 2:51 PM
Ricordisamoa updated the task description. (Show Details)Sep 2 2015, 2:57 PM
matej_suchanek added a parent task: T96040: Wikibase special pages (tracking).Sep 2 2015, 3:25 PM
Ricordisamoa updated the task description. (Show Details)Sep 2 2015, 3:51 PM
Ricordisamoa mentioned this in T96035: Support $wgUseMediaWikiUIEverywhere in Wikibase forms.Sep 2 2015, 10:25 PM
gerritbot added a comment.Sep 4 2015, 10:12 AM

Change 235999 had a related patch set uploaded (by Ricordisamoa):
Convert SpecialItemByTitle to HTMLForm in 'ooui' mode

https://gerrit.wikimedia.org/r/235999

Ricordisamoa updated the task description. (Show Details)Sep 4 2015, 10:12 AM
gerritbot added a comment.Sep 4 2015, 10:35 AM

Change 236002 had a related patch set uploaded (by Ricordisamoa):
Convert SpecialMergeItems to HTMLForm in 'ooui' mode

https://gerrit.wikimedia.org/r/236002

Ricordisamoa updated the task description. (Show Details)Sep 4 2015, 10:37 AM
gerritbot added a comment.Sep 7 2015, 12:47 PM

Change 236002 merged by jenkins-bot:
Convert SpecialMergeItems to HTMLForm in 'ooui' mode

https://gerrit.wikimedia.org/r/236002

Addshore mentioned this in rEWBAa8fe942f6305: Convert SpecialMergeItems to HTMLForm in 'ooui' mode.Sep 7 2015, 12:47 PM
Ricordisamoa mentioned this in rMEXTc5a36d1e4ac4: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 7 2015, 12:48 PM
Ricordisamoa updated the task description. (Show Details)Sep 7 2015, 12:56 PM
Ricordisamoa updated the task description. (Show Details)Sep 7 2015, 1:37 PM
Ricordisamoa added a comment.Sep 7 2015, 8:23 PM

This task is for repo only, but FYI https://gerrit.wikimedia.org/r/236617 converts Special:PagesWithBadges.

Ricordisamoa added a comment.Sep 9 2015, 8:53 PM

4 special pages just got the new style:

Lydia_Pintscher added a comment.Sep 9 2015, 9:14 PM

They look great!

Legoktm added a project: UI-Standardization.Sep 9 2015, 11:03 PM
Legoktm awarded a token.
Lydia_Pintscher renamed this task from Use HTMLForm in the special pages to [Story] Use HTMLForm in the special pages.Sep 10 2015, 10:28 AM
gerritbot added a comment.Sep 15 2015, 2:31 PM

Change 235999 merged by jenkins-bot:
Convert SpecialItemByTitle to HTMLForm in 'ooui' mode

https://gerrit.wikimedia.org/r/235999

Ricordisamoa mentioned this in rEWBA1dcc287e7d43: Convert SpecialItemByTitle to HTMLForm in 'ooui' mode.Sep 15 2015, 2:31 PM
Diffusion mentioned this in rMEXTf06d44353974: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 15 2015, 2:31 PM
hoo updated the task description. (Show Details)Sep 15 2015, 2:35 PM
Ricordisamoa updated the task description. (Show Details)Sep 15 2015, 2:36 PM
JanZerebecki moved this task from in progress to ready to go on the Wikidata board.Sep 18 2015, 4:02 PM
Ricordisamoa added a subtask: T38210: HtmlForm unconditionally loads form values from request.Sep 23 2015, 11:00 PM
JanZerebecki added a project: Story.Sep 25 2015, 8:32 PM
Ricordisamoa added a comment.Oct 1 2015, 10:00 PM

1 special page just got the new style:

LikeLifer subscribed.Oct 11 2015, 10:59 PM
Jdlrobson added a project: Front-end-Standards-Group.Nov 4 2015, 4:56 PM
Jdlrobson added a parent task: T107037: Convert all MW core special pages to OOUI.May 10 2016, 6:36 PM
Ricordisamoa removed a parent task: T107037: Convert all MW core special pages to OOUI.May 10 2016, 6:40 PM
Sjoerddebruin mentioned this in T38210: HtmlForm unconditionally loads form values from request.Jun 22 2016, 2:30 PM
Florian closed subtask T38210: HtmlForm unconditionally loads form values from request as Declined.Jun 23 2016, 12:08 AM
Florian changed the status of subtask T38210: HtmlForm unconditionally loads form values from request from Declined to Invalid.
Sjoerddebruin added a comment.Jul 5 2016, 5:04 PM

@Ricordisamoa, have you seen the notes on the subtask? Hope you can finish this!

Volker_E moved this task from Inbox to Needs code review on the Front-end-Standards-Group board.Jul 13 2016, 5:18 PM
Ricordisamoa added a comment.Jan 23 2017, 9:34 AM
In T48248#2430588, @Sjoerddebruin wrote:

@Ricordisamoa, have you seen the notes on the subtask? Hope you can finish this!

Hi, sorry for the delay. The last change is not ready yet but is also not blocked anymore :)

Liuxinyu970226 subscribed.Feb 3 2017, 2:43 AM
Ricordisamoa added a comment.Feb 18 2017, 6:34 PM

Since https://gerrit.wikimedia.org/r/233423 was first published, browser tests have appeared and PHPUnit tests were almost rewritten because of T69122. Nonetheless, it has got very few comments from the team :(

Lydia_Pintscher added a comment.Feb 18 2017, 6:48 PM

I pinged people about it. Sorry we lost track of it.

Ricordisamoa added a comment.Feb 18 2017, 8:47 PM
In T48248#3038449, @Lydia_Pintscher wrote:

I pinged people about it. Sorry we lost track of it.

Thanks for the quick response. Being low priority, even the slightest bit of feedback is welcome.

gerritbot added a comment.Feb 23 2017, 4:37 PM

Change 339432 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fixups to OOUI conversion of SpecialModifyEntity and subclasses

https://gerrit.wikimedia.org/r/339432

gerritbot added a comment.Feb 24 2017, 10:51 AM

Change 233423 merged by jenkins-bot:
Convert SpecialModifyEntity and subclasses to HTMLForm in 'ooui' mode

https://gerrit.wikimedia.org/r/233423

Ricordisamoa updated the task description. (Show Details)Feb 24 2017, 4:12 PM
Ladsgroup subscribed.Feb 24 2017, 4:14 PM

So should we mark this resolved?

Ricordisamoa updated the task description. (Show Details)EditedFeb 24 2017, 4:14 PM
In T48248#3053236, @Ladsgroup wrote:

So should we mark this resolved?

https://gerrit.wikimedia.org/r/339432 is waiting, after that we're done 😃

gerritbot added a comment.Feb 24 2017, 9:24 PM

Change 339432 merged by jenkins-bot:
Fixups to OOUI conversion of SpecialModifyEntity and subclasses

https://gerrit.wikimedia.org/r/339432

Ladsgroup closed this task as Resolved.Feb 24 2017, 9:28 PM
matej_suchanek moved this task from Needs code review to Done on the Front-end-Standards-Group board.Feb 24 2017, 9:31 PM
matej_suchanek removed a project: Patch-For-Review.
matej_suchanek removed subscribers: matej_suchanek, Wikidata-bugs.
Liuxinyu970226 unsubscribed.Feb 25 2017, 5:04 AM
Lydia_Pintscher added a comment.Feb 27 2017, 7:15 PM

Thanks, Ricordisamoa :)

thiemowmde added a parent task: T159317: [Bug] Special:SetLabel browser tests failing, but unable to run tests locally.Mar 6 2017, 12:07 PM
Ricordisamoa mentioned this in T159702: remove unneccessary CSS that leads to large margins on ooui special pages.Mar 8 2017, 12:10 PM
Ricordisamoa added a comment.Mar 9 2017, 1:15 PM

The last 5 are live, unfortunately without the margin fix:

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL