In RTL (hewiki and arwiki) wikis, can't remove categories
Closed, ResolvedPublic

Description

Pressing the Category button (under "page Settings") in RTL wikis do not open the "single category form" (like it does on enwiki), so one can't remove the category (one can still add new categories through "page settings", though).

the problem is not specific to hewiki or arwiki, but rather to "uselang=he" or "uselang=ar".

REPRODUCTION INSTRUCTIONS

  1. open [[en:Ido Pariente]]
  2. press "edit"
  3. add "&uselang=he" to the address line and press <Enter> (should get you here: https://en.wikipedia.org/w/index.php?title=Ido_Pariente&veaction=edit&uselang=he )
  4. click the cog next to "הגדרות עמוד" (this is "page settings" in hebrew)
  5. click on one of the category buttons

WHAT YOU EXPECT
the category form should open. the form contains the little trashcan that lets you remove the category.
(try it without "&uselang=he" to see the form)

WHAT ACTUALLY HAPPENS
nothing.

TESTED WITH BROWSERS
chrome and ff.

peace.


Version: unspecified
Severity: blocker

bzimport set Reference to bz51490.
Kipod created this task.Via LegacyJul 16 2013, 11:25 PM
Kipod added a comment.Via ConduitJul 16 2013, 11:33 PM

(not sure whether this warrants a different bug):

while in "&uselang=he" state, try to add new category: though it is possible, notice that the autocomplete feature is missing

REPRODUCTION:
0-4) steps 0-4 same as comment 0

  1. begin typing a category name. notice therre is no autocomplete.

peace.

Kipod added a comment.Via ConduitJul 16 2013, 11:47 PM

(In reply to comment #0)
...

category (one can still add new categories through "page settings", though).

peace.

my bad: the "add category" input line exists on the form, but does not work: when you add a new category and press "החלת שינויים" (i.e., "Appy chnages"), the category is not actually added to the page.

peace.

Kipod added a comment.Via ConduitJul 16 2013, 11:57 PM

(In reply to comment #2)

(In reply to comment #0)
...
> category (one can still add new categories through "page settings", though).
>
> peace.

my bad: the "add category" input line exists on the form, but does not work:
when you add a new category and press "החלת שינויים" (i.e., "Appy chnages"),
the category is not actually added to the page.

peace.

my bad second time: my confusion was because of the autocomplete problem, but one *can* add new category: you just have to press <Enter> explicitly. (with autocomplete, you normally click on the new cat name with the mouse - without autocomplete, you don't have this option).

peace.

jayvdb added a comment.Via ConduitJul 17 2013, 4:51 AM

Can confirm that Categories dialog is busted in RTL. No autocomplete, and clicking on existing categories does not allow category removal.

gerritbot added a comment.Via ConduitJul 20 2013, 11:06 AM

Change 74835 had a related patch set uploaded by Mooeypoo:
RTL Fix for Category Popup

https://gerrit.wikimedia.org/r/74835

Mooeypoo added a comment.Via ConduitJul 20 2013, 7:17 PM

Okay, I know (more or less) how to solve it, but there are a couple of issues I must raise with the VE team so I can figure out a proper solution.

The problem is that the menu element has its left position calculated dynamicallym and when we have an RTL widget, the positions are all flipped.

I can fix it by making a quickfix for RTL using this.$.parent as the wrapper to flip against (basically, "flip the coordinates of anything inside that parent").

However, if I do that, the link widget (which uses the same menu widget class) gets all messy and out of position.

The issue as far as I understand it is that the frame parents change between the link (parent being the editable surface) and the category menu (parent being the page settings widget). I need to find a general-enough "parent" call, or find a way to call the 'position' method on the category-menu only, leaving the link alone.

This will have to wait until after the weekend, when the VE team are available for some help on this.

Amire80 added a comment.Via ConduitJul 20 2013, 9:28 PM

This is a blocker for wider deployment on right-to-left wikis.

Mooeypoo added a comment.Via ConduitJul 22 2013, 4:33 AM

Problem appeared to be solved in the newest Patchset. Awaiting review and confirmation.

Amire80 added a comment.Via ConduitJul 22 2013, 7:25 AM

I confirm that the latest patch set solves the problem functionally. Thanks, Moriel.

Jdforrester-WMF added a comment.Via ConduitJul 24 2013, 2:53 AM

Done and will be deployed tomorrow. Thank you, Moriel! :-)

Kipod removed a subscriber: Kipod.Via WebDec 1 2014, 8:22 PM
Etonkovidova added a subscriber: Etonkovidova.Via WebDec 22 2014, 10:02 PM

Checked in production (just in case) - categories in hewiki can be removed&added.

Etonkovidova set Security to None.

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.