Page MenuHomePhabricator

APIEditBeforeSave isn't replacing sections like the documentation claims
Closed, ResolvedPublic

Details

Reference
bz52077

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz52077.
bzimport added a subscriber: Unknown Object (MLST).
greg created this task.Jul 26 2013, 3:49 AM
greg added a comment.Jul 26 2013, 3:51 AM

Marius, can you take a look at these? Chris is on vacation right now.

Hoo suspects that this is a problem with VisualEditor. Copying a few folks accordingly.

hoo added a comment.Jul 26 2013, 11:12 AM

After some investigation it turns out, that this is an issue with the edit API. I'm just preparing a fix, but takes some time as both the API and EditPage itself are rather messy.

Change 76082 had a related patch set uploaded by Hoo man:
Make APIEditBeforeSave give the whole revision

https://gerrit.wikimedia.org/r/76082

See also:

  • [[Wikipedia talk:Edit filter#Abusefilter bug on mobile version]]

Change 76082 merged by jenkins-bot:
Make APIEditBeforeSave give the whole revision

https://gerrit.wikimedia.org/r/76082

hoo added a comment.Aug 14 2013, 2:33 PM
  • Bug 52062 has been marked as a duplicate of this bug. ***
  • Bug 52895 has been marked as a duplicate of this bug. ***

I think this really was a problem with AbuseFilter and not the hook; the hook documentation was unclear. My fix for T73947 fixes this too, so I proposed that the patch be reverted at https://gerrit.wikimedia.org/r/282101.