Page MenuHomePhabricator
Create Task
Maniphest T58381

Change DOM rendering of <nowiki /> to be <span typeof="mw:Nowiki"></span> or similar?
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

VisualEditor deliberately drops <span typeof="mw:Nowiki"> annotations on changed content to prevent originally-necessary <nowiki> blocks interfering with editing. This means that HTML editors don't need to know or care about <nowiki>s, and they are just magically sorted out in the back-end so the resultant wikitext is the most like what a human would create.

However, <nowiki />s come out as a <meta typeof="mw:Placeholder">, which VisualEditor doesn't show to users but also won't ever remove, leading to potential issues where a no-longer-needed <nowiki /> sits in the wikitext, disruptively confusing to wikitext editors.

If Parsoid instead represented it as <span typeof="mw:Nowiki"></span> or similar, VisualEditor could do the same (well, a bit more work) and so drop it when the context has been edited, letting Parsoid re-generate it if needed.

Version: unspecified
Severity: minor
URL: https://en.wikipedia.org/w/index.php?title=Footprints_%28film%29&curid=39472392&diff=579475542&oldid=579357688

Details

Reference
bz56381
SubjectRepoBranchLines +/-
Treat html pre and nowiki as extension tagsmediawiki/services/parsoidmaster+271 -327
WIP: Edited nowiki content should invalidate the nowikimediawiki/services/parsoidmaster+261 -86
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:22 AM
• bzimport added a project: Parsoid-DOM.
• bzimport set Reference to bz56381.
Jdforrester-WMF created this task.Oct 30 2013, 7:31 PM
• GWicke added a comment.Nov 15 2013, 12:15 AM

If we want to perform clean-up like this, then we should perhaps implement that in Parsoid rather than VE so that other users benefit from it as well.

Jdforrester-WMF added a comment.Nov 15 2013, 2:05 AM

(In reply to comment #1)

If we want to perform clean-up like this, then we should perhaps implement
that in Parsoid rather than VE so that other users benefit from it as well.

Happy for it to be done in Parsoid instead, and for us to remove the dropping from VE.

Jdforrester-WMF added a comment.Jan 18 2014, 5:41 AM
  • Bug 59829 has been marked as a duplicate of this bug. ***
Jdforrester-WMF added a comment.Jan 18 2014, 5:41 AM
  • Bug 53659 has been marked as a duplicate of this bug. ***
Jdforrester-WMF added a comment.Jan 18 2014, 5:42 AM
  • Bug 59650 has been marked as a duplicate of this bug. ***
• marcoil removed • GWicke as the assignee of this task.Nov 25 2014, 6:30 PM
• marcoil added a project: Parsoid.
• marcoil set Security to None.
Jdforrester-WMF moved this task from Needs Triage to Requests from VE/Flow/others on the Parsoid board.Nov 25 2014, 7:53 PM
ssastry moved this task from Requests from VE/Flow/others to VE Q3 on the Parsoid board.Feb 2 2015, 11:02 PM
• marcoil added a project: VisualEditor 2014/15 Q3 blockers.Feb 10 2015, 3:00 PM
Jdforrester-WMF moved this task from Nominated to Dependencies on the VisualEditor 2014/15 Q3 blockers board.Feb 10 2015, 7:43 PM
Jdforrester-WMF edited a custom field.Feb 10 2015, 8:31 PM
Jdforrester-WMF added a project: Blocked-on-Parsoid.Feb 13 2015, 9:39 PM
ssastry added a subscriber: Esanders.Feb 17 2015, 6:30 PM

How about <meta typeof="mw:Nowiki" ../>. Can VE handle that instead?

gerritbot added a project: Patch-For-Review.Feb 17 2015, 6:35 PM
gerritbot subscribed.

Change 191096 had a related patch set uploaded (by Subramanya Sastry):
WIP: T58381: Represent <nowiki/> as a mw:Nowiki meta tag

https://gerrit.wikimedia.org/r/191096

Patch-For-Review

ssastry added a comment.Feb 17 2015, 6:39 PM

Uploaded a WIP there in case that would work. The meta tag seems the right approach and fits in with the use of marker meta tags for various other wikitext constructs.

ssastry claimed this task.Feb 17 2015, 10:48 PM
Esanders added a comment.Feb 17 2015, 11:51 PM

<meta> tags will be metadata in VE, so may end up somewhere else if content is deleted. Also <meta> and <link> tags suffer from being destroyed by copy/paste and so require special treatment (we also do this for HTML comments).

ssastry added a comment.EditedFeb 20 2015, 10:04 PM

Based on an IRC discussion y'day during the VE/Parsoid/Services check-in, it seems that more than fixing the representation for nowiki, VE wants Parsoid html2wt to be more aggressive removing existing <nowiki/> from edited content rather than emit those back as is. Something to be considered.

A related idea that came up during the discussion was: maybe Parsoid shouldn't emit the nowiki markup anymore in its HTML. This will work only if:
(a) selser is smart enough to add nowikis wherever required (even for unedited content)
(b) selser is smart enough to not introduce dirty diffs by optimizing / moving around nowikis because of (a). This is especially a concern fwiki, itwiki, etc. where quotes are used in non-italic/non-bold scenarios more heavily. So, any fixes we do should be tested more heavily against these wikis.

A related discussion around (a)/(b) here can be found in https://phabricator.wikimedia.org/T87708#1055269 and later comments.

But, based on all this, I am not sure that this task should be on the VE Q3 blocker list anymore. These fixes are more of a longer-term nature than what is required immediately for VE in Q3. @Jdforrester-WMF, thoughts?

Jdforrester-WMF added a comment.Feb 20 2015, 10:58 PM
In T58381#1055479, @ssastry wrote:

Based on all this, I am not sure that this task should be on the VE Q3 blocker list anymore. These fixes are more of a longer-term nature than what is required immediately for VE in Q3. @Jdforrester-WMF, thoughts?

I'm not sure. Reducing the frequency of <nowiki>s is a key "corruption" concern of users, and as such is a key blocking focus for Q3. I don't particularly see this task as the one-true-fix, and happy for this to be removed if the other work in this area addresses the concerns. What do you think?

ssastry added a comment.Feb 20 2015, 11:18 PM

I agree that fixing nowiki issues are important. But, we should add specific nowiki corruption tasks to the board rather than have a generic longer-term solution like this. I will go over our current nowiki list and add any specific nowiki corruption scenarios to the VE Q3 board. Sound good?

Jdforrester-WMF added a comment.Feb 20 2015, 11:19 PM

Works for me.

Jdforrester-WMF removed a project: VisualEditor 2014/15 Q3 blockers.Feb 20 2015, 11:19 PM
ssastry moved this task from VE Q3 to Needs Triage on the Parsoid board.Feb 23 2015, 3:43 PM
gerritbot added a comment.Aug 19 2015, 10:05 PM

Change 232313 had a related patch set uploaded (by Arlolra):
T58381: Edited nowiki content should invalidate the nowiki

https://gerrit.wikimedia.org/r/232313

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 10:05 PM
Arlolra mentioned this in T115717: Interim fix for trailing <nowiki />.Oct 16 2015, 3:58 PM
gerritbot added a comment.Dec 3 2015, 9:25 PM

Change 232313 had a related patch set uploaded (by Arlolra):
WIP: Edited nowiki content should invalidate the nowiki

https://gerrit.wikimedia.org/r/232313

gerritbot added a comment.Dec 18 2015, 9:16 PM

Change 191096 abandoned by Subramanya Sastry:
WIP: T58381: Represent <nowiki/> as a mw:Nowiki meta tag

Reason:
Once we figure out how to not generate HTML for <nowiki>s and instead add them back where needed, this is going to be irrelevant.

https://gerrit.wikimedia.org/r/191096

Arlolra removed a project: Patch-For-Review.Feb 25 2016, 2:06 AM
gerritbot added a comment.Apr 4 2016, 10:41 PM

Change 232313 abandoned by Arlolra:
WIP: Edited nowiki content should invalidate the nowiki

Reason:
For now ... until I pick it up again.

https://gerrit.wikimedia.org/r/232313

Arlolra claimed this task.Apr 28 2016, 12:03 AM
gerritbot added a comment.Dec 7 2016, 12:58 AM

Change 281076 had a related patch set uploaded (by Arlolra):
WIP: Tokenize html pre as an extension tag

https://gerrit.wikimedia.org/r/281076

gerritbot added a project: Patch-For-Review.Dec 7 2016, 12:58 AM
gerritbot added a comment.Feb 7 2017, 6:44 PM

Change 281076 merged by jenkins-bot:
Treat html pre and nowiki as extension tags

https://gerrit.wikimedia.org/r/281076

Arlolra closed this task as Resolved.Feb 7 2017, 6:55 PM

Parsoid now represents them as <span typeof="mw:Nowiki"></span>, but VisualEditor still needs to do the work to drop them when the context has been edited.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 7 2017, 6:55 PM
Jdforrester-WMF added a comment.Feb 7 2017, 7:07 PM

Thank you!

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Feb 7 2017, 10:38 PM
Stashbot subscribed.Feb 14 2017, 6:39 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-14T18:39:24Z] <arlolra> Updated Parsoid to 79ccfb93 (T58381, T108216)

Stashbot mentioned this in T108216: Indented pre blocks just broken.Feb 14 2017, 6:39 PM
matmarex subscribed.Mar 1 2017, 4:07 PM

@Jdforrester-WMF Do we actually need any work in VE? This seems to be magically working okay in my testing. If I'm missing something, is there a task?

Ryasmeen moved this task from Verified to Non verifiable/Task on the User-Ryasmeen board.Apr 13 2017, 9:17 PM
Arlolra mentioned this in T173911: Remove <nowiki/> after a trail is separated from the link.Sep 8 2017, 12:01 AM
matmarex mentioned this in T264027: <nowiki/> tag removed inside template parameter.Aug 23 2021, 1:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits