Page MenuHomePhabricator

Remove HHVM revision tag
Open, NormalPublic

Description

https://test.wikipedia.org/wiki/Special:Contributions/MZMcBride

My edits are being marked with HHVM revision tags. This is gross. It's a very internal implementation detail that's being permanently attached to my edits and I'm pretty sure I never even opted in.


Version: wmf-deployment
Severity: normal

Details

Reference
bz73181

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz73181.
bzimport added a subscriber: Unknown Object (MLST).
MZMcBride created this task.Nov 8 2014, 5:26 PM

The "Faster servers with HHVM" checkbox at https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures is unchecked. I guess I'm being opted in at a higher level.

ori added a comment.Nov 8 2014, 6:47 PM

(In reply to MZMcBride from comment #1)

I guess I'm being opted in at a higher level.

Not exactly. testwiki is a special case: it is served by a single host on the cluster, mw1017. So unlike other wikis, it cannot be served using either HHVM or Zend: it's one or the other. We converted testwiki to HHVM early on (for obvious reasons), so all edits are tagged.

(In reply to MZMcBride from comment #0)

My edits are being marked with HHVM revision tags. This is gross. It's a
very internal implementation detail that's being permanently attached to my
edits and I'm pretty sure I never even opted in.

Not permanently: I've indicated elsewhere that the tag will be expunged once the migration is complete. We can keep this bug open as a way of tracking that commitment.

I agree that it is ugly and bothersome. The tag was initially added at Mark Bergsma's request as a precaution, to help us clean up if we discover that HHVM is mangling edits somehow. We're also using it to investigate whether the improved response times correlate with increased productivity for new users, as documented https://meta.wikimedia.org/wiki/Research:HHVM_newcomer_engagement_experiment.

gerritadmin wrote:

Change 172097 had a related patch set uploaded by Ori.livneh:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172097

(In reply to Gerrit Notification Bot from comment #3)

Change 172097 had a related patch set uploaded by Ori.livneh:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172097

That's reasonable enough given Ori's comments, but personally I think there isn't any urgency.

gerritadmin wrote:

Change 172294 had a related patch set uploaded by Ori.livneh:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172294

gerritadmin wrote:

Change 172295 had a related patch set uploaded by Ori.livneh:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172295

gerritadmin wrote:

Change 172097 merged by jenkins-bot:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172097

gerritadmin wrote:

Change 172294 merged by jenkins-bot:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172294

gerritadmin wrote:

Change 172295 merged by jenkins-bot:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172295

All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

hashar set Security to None.

Next step is presumably to drop to tag, once it's implicit?

Aklapper triaged this task as Normal priority.Dec 15 2014, 6:14 PM
Se4598 added a subscriber: Se4598.Dec 27 2014, 7:29 PM
TTO added a subscriber: TTO.Feb 20 2015, 9:02 AM

DELETE FROM change_tag WHERE ct_tag = "HHVM";

That's easy enough, but it also needs to be removed from tag_summary, which will require a maintenance script of some sort. Essentially just copy and paste the code of ChangeTags::deleteTagEverywhere and alter it to work in batches.

Do we want to just do this at some point? Randomly or scheduled?

Legoktm claimed this task.Apr 7 2015, 6:36 PM

Change 203970 had a related patch set uploaded (by Legoktm):
Add maintenance script to remove HHVM revision tag

https://gerrit.wikimedia.org/r/203970

@ori can (and is willing to) do the review and merge of https://gerrit.wikimedia.org/r/203970. We should be able to resolve this task in June.

Restricted Application added a subscriber: Luke081515. · View Herald TranscriptAug 23 2015, 2:55 PM
TTO added a comment.Jan 20 2017, 6:59 AM

We should be able to resolve this task in June [2015].

Is @ori still willing to take this on?

Krinkle added a subscriber: Krinkle.Apr 9 2018, 8:20 PM