I demoed this to @Lydia_Pintscher and got approval to add this to #wikidata-sprint. I spend most time on figuring out why the test behaves different from the production code, and found https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/MediaWiki.php;69fab9a8179350fc01876d9ea3a253d6e080e1db$179 *shudder*. All solved in https://gerrit.wikimedia.org/r/343851.
you can print without using printable=yes […] This is what CSS media queries are for […]
Both should work. It appears the later was never a problem, but printable=yes was.
- When calling a page with printable=yes, section editing is disabled on wikitext pages. The Wikibase UI should respect this and not initialize it's edit toolbars. Fixed with https://gerrit.wikimedia.org/r/343851.
- When printing a page without calling the printable version first, a print stylesheet is applied, which already works fine, as far as I can see.
Well i include a screenshot what of what I currently see when hitting print:
The blocks are a bug with svg images in print mode in Safari, but i clearly get edit buttons atm, I see no evidence that they are being hidden for me. Am I misunderstanding the problem ?