Just because the schema is written in JSON isn't a justification for the schema data itself to not be retrievable using other supported API formats.
If you wait for Gerrit change 182858 to be merged, you won't even have to worry about getting indexed tag names right for format=xml.
In fact, you simply need to remove the implemented getCustomPrinter method and test the change.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | zeljkofilipin | T206676 1.33.0-wmf.22 deployment blockers | ||
| Resolved | Krinkle | T91454 ApiJsonSchema implements ApiBase::getCustomPrinter for no good reason |
Change 264494 had a related patch set uploaded (by Anomie):
Remove getCustomPrinter() from ApiJsonSchema
Change 264591 had a related patch set uploaded (by Florianschmidtwelzow):
Remove getCustomPrinter() from ApiJsonSchema
Adding @greg and @20after4 because of the comment from @Anomie on the change: https://gerrit.wikimedia.org/r/#/c/264494/
From my perspective, the best solution would be:
Maybe Greg or 20after4 has a better idea? :)
Change 264591 abandoned by Florianschmidtwelzow:
Remove getCustomPrinter() from ApiJsonSchema
Reason:
we should do this for the next branching point :)
Change 265219 had a related patch set uploaded (by Florianschmidtwelzow):
Remove getCustomPrinter() from ApiJsonSchema
So, the new plan is:
From my perspective, the best solution would be:
@greg Do I need to add a special notice to the Deployments page in wikitech, so you (or the deployer) doesn't miss this special change while deploying to group1? :)
Yeah, getting it on the deployments wiki page so it's not missed is important (I'm mostly good about seeing pings in Phab, but not always as quickly as needed, see: this task ;) ).
:P Ok, thanks for the answer! :) I'll edit wikitech:Deployments, here's the diff. I hope that's ok so, if not... it's a wiki, feel free to edit :)
Update on wmf.11 rollout:
We had to rollback to wmf.10 last week (ie: right now all wikis are on wmf.10).
We are going to redo wmf.11 this week (with appropriate backports) following the normal schedule (just maybe an hour earlier for coverage reasons).
In summary: This is delayed another week.
Change 265219 abandoned by Krinkle:
Remove getCustomPrinter() from ApiJsonSchema
Reason:
Unused branch.
The problem seems to be that it has to be very carefully deployed, and the people who can do that forgot about it after unrelated troubles in wmf/1.27.0-wmf.11.
Or the patch at https://gerrit.wikimedia.org/r/#/c/264494/ could be split into two parts: one to add format=json to future-proof the requests, and the second to be deployed a week later that actually removes the custom printer.
Change 264494 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Remove getCustomPrinter() from ApiJsonSchema
FYI, remember the discussion above (starting at T91454#1939833) about care that needs to be taken when rolling this out.
Note there's nothing to unbreak here, this is more of a "Don't Break Later!". See T206676#5033394 for details.
To summarise for here: I've merged a change in the master branch. This change should be deployed to all wikis at once.
Riding the train would cause problems between group 1 and group 2 on Wednesday/Thursday.
I'll backport the change to wmf.21 (now on all wikis) before wmf.22 goes out to group 0 on Tuesday.
Change 497417 had a related patch set uploaded (by Jforrester; owner: IoannisKydonis):
[mediawiki/extensions/EventLogging@wmf/1.33.0-wmf.21] Remove getCustomPrinter() from ApiJsonSchema
Change 497417 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@wmf/1.33.0-wmf.21] Remove getCustomPrinter() from ApiJsonSchema
@Krinkle the commit is merged in wmf.21, but not deployed? Is there anything I need to do?
Deployed, but not up with the on-wiki SAL; they appear in the SAL tool https://tools.wmflabs.org/sal:
02:12 <krinkle@deploy1001> Synchronized php-1.33.0-wmf.21/extensions/EventLogging/includes/ApiJsonSchema.php: If280a4056a (duration: 00m 48s)
02:11 <krinkle@deploy1001> Synchronized php-1.33.0-wmf.21/extensions/EventLogging/includes/RemoteSchema.php: If280a4056a (duration: 00m 51s)