Page MenuHomePhabricator
Create Task
Maniphest T93607

Make mw.wikibase.getEntity and mw.wikibase.getEntityObject the same function
Closed, ResolvedPublic
Actions

Description

Make the old mw.wikibase.getEntity use the same logic/ code mw.wikibase.getEntityObject uses, removing the backwards compatibility.

Details

SubjectRepoBranchLines +/-
Make mw.wikibase.getEntity == mw.wikibase.getEntityObjectmediawiki/extensions/Wikibasemaster+25 -55
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT142093 Decide how to do usage tracking for strings used to lookup entities (page titles, external ids, …)
 ResolvedLydia_PintscherT146637 Wikidata 2016 Q4 goals
 ResolvedLydia_PintscherT150179 Wikidata 2017 Q1 goals
 ResolvedLydia_PintscherT76007 [Epic] add ability to link/refer to foreign items and properties (federation)
 ResolvedLydia_PintscherT89594 Use the arbitrary access to Wikidata feature on Commons (tracking)
 ResolvedJarektT89599 Convert Template:Institution to Lua and use Wikidata
 InvalidNoneT112073 Lua in Wikibase (tracking)
 ResolvedTptT74815 [Task] Add Lua function to get Wikibase entity by site link (title)
 ResolvedNoneT49930 [Epic] Allow accessing data from a Wikidata item not connected to the current page - arbitrary access
 ResolvedhooT93607 Make mw.wikibase.getEntity and mw.wikibase.getEntityObject the same function
 ResolvedLucieT88950 Migrate all relevant Lua modules from mw.wikibase.getEntity to mw.wikibase.getEntityObject
 DeclinedNoneT133498 Detect and extend known title <-> entity links in a semi-automatic way

Event Timeline

hoo created this task.Mar 23 2015, 5:40 PM
hoo raised the priority of this task from to Needs Triage.
hoo updated the task description. (Show Details)
hoo added projects: Wikidata, MediaWiki-extensions-WikibaseClient.
hoo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 5:40 PM
hoo added a subtask: T88950: Migrate all relevant Lua modules from mw.wikibase.getEntity to mw.wikibase.getEntityObject.Mar 23 2015, 5:41 PM
hoo added a parent task: T49930: [Epic] Allow accessing data from a Wikidata item not connected to the current page - arbitrary access.
gerritbot subscribed.Mar 23 2015, 6:26 PM

Change 198771 had a related patch set uploaded (by Hoo man):
Make mw.wikibase.getEntity == mw.wikibase.getEntityObject

https://gerrit.wikimedia.org/r/198771

gerritbot added a project: Patch-For-Review.Mar 23 2015, 6:26 PM
hoo triaged this task as Medium priority.Mar 23 2015, 6:30 PM
Ricordisamoa subscribed.Mar 23 2015, 10:51 PM

Does this mean mw.wikibase.getEntity will become the preferred way of calling it?

hoo added a comment.Mar 23 2015, 10:57 PM
In T93607#1143412, @Ricordisamoa wrote:

Does this mean mw.wikibase.getEntity will become the preferred way of calling it?

They are going to be the same thing, so it totally wont matter which one you're calling. I think, I prefer getEntity because it's shorter, but in the end it doesn't matter.

gerritbot added a comment.Mar 26 2015, 5:23 PM

Change 198771 merged by jenkins-bot:
Make mw.wikibase.getEntity == mw.wikibase.getEntityObject

https://gerrit.wikimedia.org/r/198771

Diffusion mentioned this in rMEXT5af527caff14: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 26 2015, 5:23 PM
daniel mentioned this in rEWBA6b1b0eff791f: Make mw.wikibase.getEntity == mw.wikibase.getEntityObject.Mar 26 2015, 5:24 PM
hoo closed this task as Resolved.Mar 26 2015, 5:27 PM
hoo claimed this task.

To be deployed April 7 (non-Wikipedias) and 8 (Wikipedias).

Ricordisamoa added a comment.Mar 27 2015, 10:23 AM
In T93607#1143434, @hoo wrote:
In T93607#1143412, @Ricordisamoa wrote:

Does this mean mw.wikibase.getEntity will become the preferred way of calling it?

They are going to be the same thing, so it totally wont matter which one you're calling. I think, I prefer getEntity because it's shorter, but in the end it doesn't matter.

From the commit mw.wikibase.getEntity is going to be the 'main' function. Yay for brevity!

Ricordisamoa added a parent task: T112073: Lua in Wikibase (tracking).Sep 29 2015, 6:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits