Page MenuHomePhabricator

Make mw.wikibase.getEntity and mw.wikibase.getEntityObject the same function
Closed, ResolvedPublic

Description

Make the old mw.wikibase.getEntity use the same logic/ code mw.wikibase.getEntityObject uses, removing the backwards compatibility.

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
StalledNone
OpenNone
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedJarekt
InvalidNone
ResolvedTpt
ResolvedNone
Resolvedhoo
ResolvedLucie
DeclinedNone

Event Timeline

hoo created this task.Mar 23 2015, 5:40 PM
hoo updated the task description. (Show Details)
hoo raised the priority of this task from to Needs Triage.
hoo added a subscriber: hoo.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 5:40 PM

Change 198771 had a related patch set uploaded (by Hoo man):
Make mw.wikibase.getEntity == mw.wikibase.getEntityObject

https://gerrit.wikimedia.org/r/198771

hoo triaged this task as Normal priority.Mar 23 2015, 6:30 PM

Does this mean mw.wikibase.getEntity will become the preferred way of calling it?

hoo added a comment.Mar 23 2015, 10:57 PM

Does this mean mw.wikibase.getEntity will become the preferred way of calling it?

They are going to be the same thing, so it totally wont matter which one you're calling. I think, I prefer getEntity because it's shorter, but in the end it doesn't matter.

Change 198771 merged by jenkins-bot:
Make mw.wikibase.getEntity == mw.wikibase.getEntityObject

https://gerrit.wikimedia.org/r/198771

hoo closed this task as Resolved.Mar 26 2015, 5:27 PM
hoo claimed this task.

To be deployed April 7 (non-Wikipedias) and 8 (Wikipedias).

In T93607#1143434, @hoo wrote:

Does this mean mw.wikibase.getEntity will become the preferred way of calling it?

They are going to be the same thing, so it totally wont matter which one you're calling. I think, I prefer getEntity because it's shorter, but in the end it doesn't matter.

From the commit mw.wikibase.getEntity is going to be the 'main' function. Yay for brevity!