Page MenuHomePhabricator
Feed Advanced Search

Jan 2 2015

Jsahleen added a comment to T78133: Adapt red links on the translation - part 1.

I will refactor my patch set on Monday so that it incorporates Santhosh's comments. Most of the comments have to do with parameter documentation or method naming, but there are some places where the code could be optimized and the file could be shortened by combining similar methods and (possibly) moving them into the selection utility class.

Jan 2 2015, 1:44 PM · OKR-Work, WMF-deploy-2015-06-23_(1.26wmf11), ContentTranslation
Jsahleen added a comment to T78133: Adapt red links on the translation - part 1.

Note that with option (b) in Santhosh's comment above any grayed out links in the translation column are removed when publishing and left as plain text. The grayed out links also only show when the section being translated has focus, per Pau's design. However, I am fine with removing the link entirely if that is what Pau suggests.

Jan 2 2015, 1:21 PM · OKR-Work, WMF-deploy-2015-06-23_(1.26wmf11), ContentTranslation

Dec 23 2014

Jsahleen moved T85200: Inconsistent link adaptation in nn-nb translations from In Progress to In Review on the LE-Sprint-81 board.
Dec 23 2014, 10:51 PM · ContentTranslation, ContentTranslation-Release3, LE-Sprint-81
Jsahleen moved T74265: Clicking on source link shows remove link control even after the target link has been removed from Backlog to In Review on the LE-Sprint-81 board.
Dec 23 2014, 10:51 PM · Patch-For-Review, LE-Sprint-81, ContentTranslation-Release3, ContentTranslation
Jsahleen added a comment to T85200: Inconsistent link adaptation in nn-nb translations.

We should retest this after the red links patch is merged.

Dec 23 2014, 10:50 PM · ContentTranslation, ContentTranslation-Release3, LE-Sprint-81
Jsahleen added a comment to T74265: Clicking on source link shows remove link control even after the target link has been removed.

This should be resolved with the red links patch:

Dec 23 2014, 10:49 PM · Patch-For-Review, LE-Sprint-81, ContentTranslation-Release3, ContentTranslation
Jsahleen added a comment to T78133: Adapt red links on the translation - part 1.

I just uploaded the revised version of my red links patch. I implemented the functionality Pau discussed in the meeting on Monday and in general cleaned things up and added the graphics. Everything is working quite well now. :-) There may still be a few cases where links that actually have corresponding articles are not adapted automatically after machine translation, but these issues have to do with what is returned from wikidata so there’s not much we can do. At any rate, they’re fairly rare and can still be manually adapted by the user.

Dec 23 2014, 9:57 PM · OKR-Work, WMF-deploy-2015-06-23_(1.26wmf11), ContentTranslation
Jsahleen claimed T74265: Clicking on source link shows remove link control even after the target link has been removed.
Dec 23 2014, 3:09 PM · Patch-For-Review, LE-Sprint-81, ContentTranslation-Release3, ContentTranslation
Jsahleen added a comment to T85200: Inconsistent link adaptation in nn-nb translations.

For ES to CA, here is a sample:

Dec 23 2014, 2:04 PM · ContentTranslation, ContentTranslation-Release3, LE-Sprint-81
Jsahleen added a comment to T85200: Inconsistent link adaptation in nn-nb translations.

I think this may be related to annotation mapping rather than link adaptation. I tried translating something from EN to CA with link adaptation commented out and saw that several link tags were not properly mapped over to the translation html from the source html. They just disappeared. Because link adaptation works on the target html produced by the annotation mapping algorithm rather than on the source html, if the link tags are not mapped over to the target the links cannot be adapted.

Dec 23 2014, 12:49 PM · ContentTranslation, ContentTranslation-Release3, LE-Sprint-81

Dec 22 2014

Jsahleen closed T76180: Existing translation: warning and options as Resolved.
Dec 22 2014, 2:05 PM · LE-Sprint-82, ContentTranslation-Release4, Patch-For-Review, ContentTranslation, Language-Team
Jsahleen closed T76464: Show publishing options dialog when publishing if target title exists in user space as Resolved.
Dec 22 2014, 2:05 PM · LE-Sprint-80, Patch-For-Review, Language-Team, ContentTranslation, ContentTranslation-Release3
Jsahleen closed T76464: Show publishing options dialog when publishing if target title exists in user space, a subtask of T76180: Existing translation: warning and options, as Resolved.
Dec 22 2014, 2:05 PM · LE-Sprint-82, ContentTranslation-Release4, Patch-For-Review, ContentTranslation, Language-Team
Jsahleen moved T76180: Existing translation: warning and options from In Review to Done on the LE-Sprint-80 board.
Dec 22 2014, 2:04 PM · LE-Sprint-82, ContentTranslation-Release4, Patch-For-Review, ContentTranslation, Language-Team
Jsahleen moved T76464: Show publishing options dialog when publishing if target title exists in user space from In Review to Done on the LE-Sprint-80 board.
Dec 22 2014, 2:04 PM · LE-Sprint-80, Patch-For-Review, Language-Team, ContentTranslation, ContentTranslation-Release3
Jsahleen committed rECTXed7f80bba621: Publishing: Add publishing options dialog.
Publishing: Add publishing options dialog
Dec 22 2014, 1:55 PM
Jsahleen committed rECTX93962a541f5e: ULS width according to the number of languages (authored by Amire80).
ULS width according to the number of languages
Dec 22 2014, 12:48 PM
Jsahleen committed rECTX3e25a7e1073c: Override beta feature preference if Special:CX accessed with valid token (authored by santhosh).
Override beta feature preference if Special:CX accessed with valid token
Dec 22 2014, 12:42 PM
Jsahleen committed rECTX41637902a1ca: Make sure translator see license text even if use manually created URL (authored by santhosh).
Make sure translator see license text even if use manually created URL
Dec 22 2014, 12:41 PM
Jsahleen committed rECTXfd8c74cf7e71: Correct positioning of the selector dialog for RTL (authored by Amire80).
Correct positioning of the selector dialog for RTL
Dec 22 2014, 11:59 AM

Dec 21 2014

Jsahleen moved T78133: Adapt red links on the translation - part 1 from In Progress to In Review on the LE-Sprint-80 board.
Dec 21 2014, 10:48 PM · OKR-Work, WMF-deploy-2015-06-23_(1.26wmf11), ContentTranslation

Dec 16 2014

Jsahleen added a comment to T76464: Show publishing options dialog when publishing if target title exists in user space.

Patch has been refactored along the lines suggested by Santhosh. I just needs a quick review and merge. Styling may need some adjustment by Pau.

Dec 16 2014, 8:56 PM · LE-Sprint-80, Patch-For-Review, Language-Team, ContentTranslation, ContentTranslation-Release3
Jsahleen committed rETRA4a3e27914fda: Fixing some white space errors.
Fixing some white space errors
Dec 16 2014, 4:52 PM
Jsahleen committed rETRA846b899d5754: Revert "Request csrf tokens in JS when supported" (authored by Nikerabbit).
Revert "Request csrf tokens in JS when supported"
Dec 16 2014, 4:21 PM

Dec 15 2014

Jsahleen closed T1388: Source selector Cancel and Start Translation buttons sometime require two clicks as Resolved.
Dec 15 2014, 11:32 AM · ContentTranslation, Language-Team
Jsahleen closed T76847: Source selector "Start translation" button not enabled when pasting in source title, a subtask of T78241: Must fix bugs for January 2015 deployment, as Resolved.
Dec 15 2014, 11:31 AM · Tracking-Neverending, LE-Sprint-81, ContentTranslation-Release3, ContentTranslation
Jsahleen closed T76847: Source selector "Start translation" button not enabled when pasting in source title as Resolved.
Dec 15 2014, 11:31 AM · ContentTranslation, LE-Sprint-80, ContentTranslation-Release3
Jsahleen closed T76832: Both of language selectors are set to language of the wiki by default, a subtask of T78241: Must fix bugs for January 2015 deployment, as Resolved.
Dec 15 2014, 11:30 AM · Tracking-Neverending, LE-Sprint-81, ContentTranslation-Release3, ContentTranslation
Jsahleen closed T76832: Both of language selectors are set to language of the wiki by default as Resolved.
Dec 15 2014, 11:30 AM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation
Jsahleen closed T76832: Both of language selectors are set to language of the wiki by default, a subtask of T76700: Page name auto completion does not work on Special:ContentTranslation, as Resolved.
Dec 15 2014, 11:30 AM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation, Language-Team
Jsahleen closed T76700: Page name auto completion does not work on Special:ContentTranslation as Resolved.
Dec 15 2014, 11:30 AM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation, Language-Team
Jsahleen closed T76700: Page name auto completion does not work on Special:ContentTranslation, a subtask of T78241: Must fix bugs for January 2015 deployment, as Resolved.
Dec 15 2014, 11:30 AM · Tracking-Neverending, LE-Sprint-81, ContentTranslation-Release3, ContentTranslation

Dec 14 2014

Jsahleen moved T76568: Link adaptation broken for text written by the user from Blocked to Done on the LE-Sprint-80 board.
Dec 14 2014, 9:40 AM · Patch-For-Review, LE-Sprint-80, ContentTranslation-Release3, ContentTranslation
Jsahleen moved T78004: Publish button disappear after publishing till new change happen from Blocked to Done on the LE-Sprint-80 board.
Dec 14 2014, 9:40 AM · Patch-For-Review, ContentTranslation-Release3, LE-Sprint-80, ContentTranslation
Jsahleen moved T78004: Publish button disappear after publishing till new change happen from In Review to Blocked on the LE-Sprint-80 board.
Dec 14 2014, 9:40 AM · Patch-For-Review, ContentTranslation-Release3, LE-Sprint-80, ContentTranslation
Jsahleen moved T76568: Link adaptation broken for text written by the user from In Review to Blocked on the LE-Sprint-80 board.
Dec 14 2014, 9:40 AM · Patch-For-Review, LE-Sprint-80, ContentTranslation-Release3, ContentTranslation

Dec 12 2014

Jsahleen added a comment to T76464: Show publishing options dialog when publishing if target title exists in user space.

Since Santhosh is out next week, I will try to refactor the patch along the lines he suggested instead of waiting for him to do it as previously planned.

Dec 12 2014, 6:47 PM · LE-Sprint-80, Patch-For-Review, Language-Team, ContentTranslation, ContentTranslation-Release3
Jsahleen added a comment to T76196: Improve language selection when creating a translation.

@pginer These regressions are fixed in the following patch which has not been merged yet. I took care of all language selection issues, I believe.

Dec 12 2014, 6:28 PM · ContentTranslation-Release5, ContentTranslation, Language-Team
Jsahleen committed rECTXf38ae84414c9: If autosave is possible, do not show the page unload prompt (authored by santhosh).
If autosave is possible, do not show the page unload prompt
Dec 12 2014, 2:00 PM
Jsahleen committed rECTX23c6fdb215eb: Do not adapt links and references if they are restored from draft (authored by santhosh).
Do not adapt links and references if they are restored from draft
Dec 12 2014, 1:54 PM
Jsahleen committed rECTX441adefa3f1e: Links: Fix bug with links from user text.
Links: Fix bug with links from user text
Dec 12 2014, 12:20 PM
Jsahleen committed rECTXefe3bb139e66: Publishing: Fix publishing button disappearing on publish.
Publishing: Fix publishing button disappearing on publish
Dec 12 2014, 12:16 PM

Dec 11 2014

Jsahleen moved T78133: Adapt red links on the translation - part 1 from Backlog to In Progress on the LE-Sprint-80 board.
Dec 11 2014, 9:36 PM · OKR-Work, WMF-deploy-2015-06-23_(1.26wmf11), ContentTranslation
Jsahleen removed projects from T78134: Adapt red links on the translation - part 2: ContentTranslation-Release3, LE-Sprint-80.
Dec 11 2014, 9:35 PM · OKR-Work, Wikidata, ContentTranslation
Jsahleen moved T76568: Link adaptation broken for text written by the user from Backlog to In Review on the LE-Sprint-80 board.
Dec 11 2014, 9:34 PM · Patch-For-Review, LE-Sprint-80, ContentTranslation-Release3, ContentTranslation
Jsahleen added a comment to T76568: Link adaptation broken for text written by the user.

Adding links by clicking on source link was fixed in this patch:

Dec 11 2014, 9:33 PM · Patch-For-Review, LE-Sprint-80, ContentTranslation-Release3, ContentTranslation
Jsahleen moved T78004: Publish button disappear after publishing till new change happen from In Progress to In Review on the LE-Sprint-80 board.
Dec 11 2014, 9:19 PM · Patch-For-Review, ContentTranslation-Release3, LE-Sprint-80, ContentTranslation
Jsahleen moved T78004: Publish button disappear after publishing till new change happen from Backlog to In Progress on the LE-Sprint-80 board.
Dec 11 2014, 9:19 PM · Patch-For-Review, ContentTranslation-Release3, LE-Sprint-80, ContentTranslation
Jsahleen added a comment to T76700: Page name auto completion does not work on Special:ContentTranslation.

Fixed by the following patch:

Dec 11 2014, 8:50 PM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation, Language-Team
Jsahleen moved T76832: Both of language selectors are set to language of the wiki by default from In Progress to In Review on the LE-Sprint-80 board.
Dec 11 2014, 8:49 PM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation
Jsahleen moved T76847: Source selector "Start translation" button not enabled when pasting in source title from In Progress to In Review on the LE-Sprint-80 board.
Dec 11 2014, 8:49 PM · ContentTranslation, LE-Sprint-80, ContentTranslation-Release3
Jsahleen moved T76700: Page name auto completion does not work on Special:ContentTranslation from In Progress to In Review on the LE-Sprint-80 board.
Dec 11 2014, 8:49 PM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation, Language-Team
Jsahleen added a subtask for T76700: Page name auto completion does not work on Special:ContentTranslation: T76832: Both of language selectors are set to language of the wiki by default.
Dec 11 2014, 2:54 PM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation, Language-Team
Jsahleen committed rECTX276f731dec7a: Preserve translation selection when clicking source link.
Preserve translation selection when clicking source link
Dec 11 2014, 11:59 AM

Dec 10 2014

Jsahleen moved T76832: Both of language selectors are set to language of the wiki by default from Backlog to In Progress on the LE-Sprint-80 board.
Dec 10 2014, 10:47 PM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation
Jsahleen moved T76847: Source selector "Start translation" button not enabled when pasting in source title from Backlog to In Progress on the LE-Sprint-80 board.
Dec 10 2014, 10:46 PM · ContentTranslation, LE-Sprint-80, ContentTranslation-Release3
Jsahleen moved T76700: Page name auto completion does not work on Special:ContentTranslation from Backlog to In Progress on the LE-Sprint-80 board.
Dec 10 2014, 10:46 PM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation, Language-Team
Jsahleen moved T76464: Show publishing options dialog when publishing if target title exists in user space from In Progress to In Review on the LE-Sprint-80 board.
Dec 10 2014, 10:46 PM · LE-Sprint-80, Patch-For-Review, Language-Team, ContentTranslation, ContentTranslation-Release3
Jsahleen moved T76180: Existing translation: warning and options from In Progress to In Review on the LE-Sprint-80 board.
Dec 10 2014, 10:46 PM · LE-Sprint-82, ContentTranslation-Release4, Patch-For-Review, ContentTranslation, Language-Team
Gerrit Code Review <gerrit@wikimedia.org> committed rETRA535b3c6d919a: Merge "Use pointer cursor for the navitoggle icon" (authored by Jsahleen).
Merge "Use pointer cursor for the navitoggle icon"
Dec 10 2014, 6:51 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rETRA4e3816541982: Merge "Add parameterless GENDER as insertable" (authored by Jsahleen).
Merge "Add parameterless GENDER as insertable"
Dec 10 2014, 6:51 PM
Jsahleen moved T76180: Existing translation: warning and options from Backlog to In Progress on the LE-Sprint-80 board.
Dec 10 2014, 4:45 PM · LE-Sprint-82, ContentTranslation-Release4, Patch-For-Review, ContentTranslation, Language-Team
Jsahleen moved T76464: Show publishing options dialog when publishing if target title exists in user space from Backlog to In Progress on the LE-Sprint-80 board.
Dec 10 2014, 4:45 PM · LE-Sprint-80, Patch-For-Review, Language-Team, ContentTranslation, ContentTranslation-Release3
Jsahleen committed rECTXf3c7d547f14c: Use "all translations" link on the translation view when drafts enabled (authored by santhosh).
Use "all translations" link on the translation view when drafts enabled
Dec 10 2014, 4:30 PM
Jsahleen committed rECTX41409f41206f: Template, Images, References: Use attributeContains selector for typeof… (authored by santhosh).
Template, Images, References: Use attributeContains selector for typeof…
Dec 10 2014, 4:30 PM
Jsahleen committed rECTXd02c778b7596: Do not add placeholder for zero height source sections (authored by santhosh).
Do not add placeholder for zero height source sections
Dec 10 2014, 4:30 PM
Jsahleen committed rECTXd0a30f8b9903: ULS for source and target selectors (authored by Amire80).
ULS for source and target selectors
Dec 10 2014, 4:30 PM
Jsahleen committed rECTXea0b3dbcb4fd: Warnings: Show warning on translation title change.
Warnings: Show warning on translation title change
Dec 10 2014, 4:30 PM
Jsahleen committed rECTXdc9d452ee5cd: When removing figures, use a placeholder instead of empty figure (authored by santhosh).
When removing figures, use a placeholder instead of empty figure
Dec 10 2014, 4:30 PM
Jsahleen committed rECTX426948546d23: For target title use User:UserName prefix only for publishing (authored by santhosh).
For target title use User:UserName prefix only for publishing
Dec 10 2014, 4:30 PM
Jsahleen committed rECTXdd87a22fb656: High MT Category: Minor adjustments based on comments.
High MT Category: Minor adjustments based on comments
Dec 10 2014, 4:30 PM
Jsahleen committed rECTXad94c24ddb6e: Source Selector: Add different presentation modes and cancel button.
Source Selector: Add different presentation modes and cancel button
Dec 10 2014, 4:30 PM
Jsahleen committed rECTXd7dd04b8baca: Source selector improvements (authored by santhosh).
Source selector improvements
Dec 10 2014, 4:30 PM
Jsahleen committed rECTX1de567071211: Source selector: Hide messages on input.
Source selector: Hide messages on input
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX20dac2bbfdb5: Source selector: Inject siteMapper as a dependency.
Source selector: Inject siteMapper as a dependency
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX2e5f69d87c6c: Remove unscoped .hidden class (authored by santhosh).
Remove unscoped .hidden class
Dec 10 2014, 4:29 PM
Jsahleen committed rECTXf97f947b5478: Source Selector: Refactor source selector.
Source Selector: Refactor source selector
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX99fc808e3680: Links: Change add link so it preserves selected text.
Links: Change add link so it preserves selected text
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX815408102044: Categories: Unit Tests.
Categories: Unit Tests
Dec 10 2014, 4:29 PM
Jsahleen committed rECTXa0214418e98a: Categories: Change message when no categories.
Categories: Change message when no categories
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX38d87d3ab704: Add lang and dir to category counters and lists (authored by Amire80).
Add lang and dir to category counters and lists
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX31061105ae04: Cleanup ext.cx.tools.categories.js according to coding conventions (authored by Amire80).
Cleanup ext.cx.tools.categories.js according to coding conventions
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX1b9f02c5a7b5: Categories: Increase API limit on categories retrieved and adapted.
Categories: Increase API limit on categories retrieved and adapted
Dec 10 2014, 4:29 PM
Jsahleen committed rECTXa8f7cf452c70: Categories: Publish categories.
Categories: Publish categories
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX5b7986ef5d30: Categories: Retrieve, adapt and manage categories.
Categories: Retrieve, adapt and manage categories
Dec 10 2014, 4:29 PM
Jsahleen committed rECTXb01a55670ad4: Improve logging of publishing failures.
Improve logging of publishing failures
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX50d07deed8c4: Selections: Update MT Tool to use Selection class.
Selections: Update MT Tool to use Selection class
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX7cdfe70f6882: Selections: Update LinkTool to use new Selection class.
Selections: Update LinkTool to use new Selection class
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX953657654396: Selections: Change Selection class so it saves and restores ranges.
Selections: Change Selection class so it saves and restores ranges
Dec 10 2014, 4:29 PM
Jsahleen committed rECTXeed027f22575: Selections: Add Selection class inside new util module.
Selections: Add Selection class inside new util module
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX043631799531: Selections: Preserve selection/cursor position in translation.
Selections: Preserve selection/cursor position in translation
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX31881fed67ee: Links: Various improvements (authored by santhosh).
Links: Various improvements
Dec 10 2014, 4:29 PM
Jsahleen committed rECTXfdc26bf0e706: Unit Tests: Remove duplicate test declaration..
Unit Tests: Remove duplicate test declaration.
Dec 10 2014, 4:29 PM
Jsahleen committed rECTX9efe0eae758c: Add tests for ContentTranslationHeader.prototype.showMessage (authored by Nikerabbit).
Add tests for ContentTranslationHeader.prototype.showMessage
Dec 10 2014, 4:29 PM
Jsahleen added a comment to T76618: Publish translations to the main namespace by default (if the page does not exist already).

Our success metrics currently include number of users who publish to user namespace. If we change things to publish directly to the main namespace, that metric will no longer be relevant, right?

Dec 10 2014, 4:28 PM · ContentTranslation-Release4, LE-Sprint-81, ContentTranslation-Release3, ContentTranslation
Jsahleen claimed T76700: Page name auto completion does not work on Special:ContentTranslation.
Dec 10 2014, 4:07 PM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation, Language-Team
Jsahleen claimed T76832: Both of language selectors are set to language of the wiki by default.
Dec 10 2014, 4:06 PM · LE-Sprint-80, ContentTranslation-Release3, ContentTranslation
Jsahleen claimed T76847: Source selector "Start translation" button not enabled when pasting in source title.
Dec 10 2014, 4:06 PM · ContentTranslation, LE-Sprint-80, ContentTranslation-Release3
Jsahleen added a comment to T76847: Source selector "Start translation" button not enabled when pasting in source title.

It may be possible to fix this by changing the event to on input with throttle instead of on blur. Related to T1388.

Dec 10 2014, 2:51 PM · ContentTranslation, LE-Sprint-80, ContentTranslation-Release3
Jsahleen added a comment to T76618: Publish translations to the main namespace by default (if the page does not exist already).

This will require changes in both ext.cx.publish.js and ext.cx.publish.dialog.js. Just noting that so we don't forget.

Dec 10 2014, 2:42 PM · ContentTranslation-Release4, LE-Sprint-81, ContentTranslation-Release3, ContentTranslation