I will refactor my patch set on Monday so that it incorporates Santhosh's comments. Most of the comments have to do with parameter documentation or method naming, but there are some places where the code could be optimized and the file could be shortened by combining similar methods and (possibly) moving them into the selection utility class.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 2 2015
Note that with option (b) in Santhosh's comment above any grayed out links in the translation column are removed when publishing and left as plain text. The grayed out links also only show when the section being translated has focus, per Pau's design. However, I am fine with removing the link entirely if that is what Pau suggests.
Dec 23 2014
We should retest this after the red links patch is merged.
This should be resolved with the red links patch:
I just uploaded the revised version of my red links patch. I implemented the functionality Pau discussed in the meeting on Monday and in general cleaned things up and added the graphics. Everything is working quite well now. :-) There may still be a few cases where links that actually have corresponding articles are not adapted automatically after machine translation, but these issues have to do with what is returned from wikidata so there’s not much we can do. At any rate, they’re fairly rare and can still be manually adapted by the user.
For ES to CA, here is a sample:
I think this may be related to annotation mapping rather than link adaptation. I tried translating something from EN to CA with link adaptation commented out and saw that several link tags were not properly mapped over to the translation html from the source html. They just disappeared. Because link adaptation works on the target html produced by the annotation mapping algorithm rather than on the source html, if the link tags are not mapped over to the target the links cannot be adapted.
Dec 22 2014
Dec 21 2014
Dec 16 2014
Patch has been refactored along the lines suggested by Santhosh. I just needs a quick review and merge. Styling may need some adjustment by Pau.
Dec 15 2014
Dec 14 2014
Dec 12 2014
Since Santhosh is out next week, I will try to refactor the patch along the lines he suggested instead of waiting for him to do it as previously planned.
@pginer These regressions are fixed in the following patch which has not been merged yet. I took care of all language selection issues, I believe.
Dec 11 2014
Adding links by clicking on source link was fixed in this patch:
Fixed by the following patch:
Dec 10 2014
Our success metrics currently include number of users who publish to user namespace. If we change things to publish directly to the main namespace, that metric will no longer be relevant, right?
It may be possible to fix this by changing the event to on input with throttle instead of on blur. Related to T1388.
This will require changes in both ext.cx.publish.js and ext.cx.publish.dialog.js. Just noting that so we don't forget.