I've looked into what implementing this would require. I think it wouldn't require more than a one day's worth of effort with minimal to moderate changes to the code. If we want to include in sprint 82, I can probably take it. However, it might be considered more of a new feature than a bug so I am also fine if we want to postpone in order to address higher priority issues.

Etherpad:

Yes. It is, I believe.

The schema you mention was set up in June and has never been used. We currently only use the schema that is called just "ContentTranslation." The other schema can be safely deleted. Thanks for the info about naming conventions. We will follow the convention in the future.

All the security related patches are merged and on beta-labs now. Please verify that things are as you need them and if they are resolve this task.

The patch ended up being quite simple and fixes an important bit of functionality. We might want to consider including it in the current release.

It looks like the necessary patch is waiting on review from Amir. Should be available shortly.

@csteipp. To reiterate what Santhosh said, the drafts are only visible to the user who created them and they can be deleted. This would seem to take care of the comments about drafts you made. We already have approval from legal on storing drafts in the db since no one else can see them.

@Pginer-WMF. I want to double check with you when the remove link card should be shown.

The publish to user namespace if we are publishing to the real Wikipedia functionality has not been implemented yet because at the time we did this story we did not have the configuration parameter or any way to detect whether we were publishing to main namespace or user namespace by default.

The point is to insert a link that uses the adapted title as the link text at the caret position; not to make the surrounding text a link. So in your example above, it would insert a link with the text "BBC Radio" wherever the text caret is. This would only be done by clicking "Add link." There would be no automatic link creation when clicking on a source link.

It is still possible to add a link inside another link. Selecting text inside a link does not automatically create a new link now, but if you select text inside a link you get the "Add link" card and clicking on "Add link" inserts a link inside the link.

Patches updated following comments from Krinkle. Code to encode as html entities and decode on the client side removed.

I have modified the communication between cxserver and the front end for MT. Response from the server is now sent as JSON with <,> and " converted to html entities. Decoded on the client.

If we automatically go to A if the user selects R and presses "start translation," what should we do with regard to the title? Should we show the R title they selected or the A title that belongs with the article text?

I was able to reproduce this. I published a page and then used 'All translations' to go back to the dashboard. My published translation was shown as 'In progress.' Same after refreshing the page.

Steps to reproduce:

You can add a link by selecting text and using the link card as you noted. The issue I was trying to describe is when the text caret is in an editable area in the translation column but no text is selected and you click on a source link.

I understand about not hiding bug fixes inside feature commits but that is not what I did. IMHO, the root cause of the problems listed above is architectural. In order to make the red links feature work I had to change some aspects of the architecture to accommodate the new feature. Making these architectural changes for red links also resolved the issues listed above. So the bugs were fixed as a result of doing what was necessary to make red links work properly.

Here is the promised list of current issues with link adaptation. These are fixed in the red links patch, but since we are pulling red links from the release they will need to be addressed in some other way.

Here are some links you can look at:

We have a few questions about this security review.

The are currently several issues with link adaptation in master. I will go through and compile a list today, making sure everything is in phabricator. I believe most of the issues are currently undocumented. I just came across them in the course of doing red links.

Santhosh, That is fine if you want to pause this until after the release. If we do that, however, you should know that there are several link-related bugs that will need to be fixed now that would have been resolved by my patch. I did not set out to fix these bugs, but since making red links work required making link adaptation in general work, they were fixed as a by-product.

Here is what I am seeing. Don't know if that is intended.