User Details
- User Since
- Nov 1 2021, 4:22 PM (137 w, 20 h)
- Availability
- Available
- LDAP User
- Unknown
- MediaWiki User
- CMelo (WMF) [ Global Accounts ]
Today
Yesterday
- Yes, they should with a full stop because they are complete sentences. Thanks for checking in about this!
This is done now
- Yes, in cases when the feature is not enabled on a wiki, the user should see the same message, whether or not they are logged in. I have updated the AC.
I will add it, thanks
But one thing occurred to me: I don't think we currently cover in the AC cases in which the wiki has the feature enabled, but the user is not logged in (so we don't yet know if they can access the feature or not). The best behavior would probably be to have a message for that too, such as: "Please login to see if you can access invitation lists." Is there a default way that the code is currently handling this?
At the moment, if the user is not logged in and tries to access Special:GenerateInvitationList, the user is redirect the to login page.
Sun, Jun 16
Fri, Jun 14
@ifried just some notes on this one:
- I think this could be merged with T356679
- The default way to add messages to translation's files, is to make only the first letter uppercase
- So this: You are not allowed to use Invitation Lists
- Would be:You are not allowed to use invitation lists
I am saying this because this type of questions always shows up in code reviews.
Not sure though about the reason behind it, but I think it is due to internationalization or maybe just because it is the default, but @Daimona may know more about the reason why.
Thu, Jun 13
Wed, Jun 12
@ifried one last question on this, should we have a custom message for when Event Invitations is not enabled on a wiki rather than just show an empty page?
Tue, Jun 11
Mon, Jun 10
OK, thank you, In this case I will remove it.
However, there is one use case that I can think of, which is the following: Let's say that an organizer does not like their Invitation List because they think that many of the users in the list don't seem like good candidates to invite. For this reason, they may want to generate a new invitation list with a revised worklist. In this case, it would be helpful to know which users came from which articles, so they could say, "Okay, this article DID generate a list of users who I would want to invite, so I'll include that article again, but this article didn't, so I won't include this article." Then, if we later allow users to export an invitation list or to select users to email from the invitation list, they could use that finalized version of the invitation list, rather than needing to pick and choose various users from multiple lists.
This makes me think: Data on which user is from which article will not be useful for the MVP, but it could be useful for later versions, if we provide support for potential actions that an organizer may take after generating an invitation list.
What do other people think? Would also love feedback from @gonyeahialam.
Fri, Jun 7
Thanks @VPuffetMichel and @ifried.
Hi @ifried, @VPuffetMichel, in this new schema to store the worklist date, I added some columns to relate a user with articles in a worklist.
Thu, Jun 6
Hi @ifried, while adding the feature flag for this special page, some questions come up on code review:
Hi @Iflorez, wondering what do you think about the new DB schema to store the worklists data, does it sound good to you?
Wed, Jun 5
We also think it would be nice to have a link to the list of worklists.
I don't understand this.
Tue, Jun 4
@gonyeahialam we may need pagination for this one
@gonyeahialam we are wondering where this empty state image is.
@gonyeahialam We have a question about scrolling it, let's say we have a big list of users (200), should the accordion have a scroll?
To be able to test it locally, you need to add the below to your LocalSettings.php:
Mon, Jun 3
Fri, May 31
This is my suggestion for the new DB schema to store the worklists data cc: @Iflorez.
Thu, May 30
Yes, indeed, it is about whether JSON makes it more difficult to generate them or not.
Given the two scenarios I think we may need, I believe JSON will make it more difficult.
Wed, May 29
Hi @ifried, We talked about this on our Design > engineering meet, and we mention that option 3 would be the best option to go with, so users can select more than one.
Tue, May 28
Yes, I agree
- cew_edited_at: timestamp
- cew_deleted_at: timestamp
I agree with you that we need answers to whether these features will ever exist before making a decision on these fields.
Also, if this table will be in the shared database, I assume we'll need to store the wiki where this worklist was created.
- ce_worklists_articles:
- cewa_article_url: varchar(100) worklist name
Yes, indeed, I will include them
s/worklist/article/? Also, we never store URLs into the database. This should either be a page ID, or two fields for namespace and title; maybe not the namespace if we'll ever only have pages in the mainspace. Additionally, we will need to store the wiki of the article, assuming we will at some point allow external pages. This would be similar to the campaign_events table.
- cewa_created_at: timestamp
- cewa_edited_at: timestamp
What would "create" and "edit" be in this context?
These I added by mistake, they are not needed, I will remove them thanks
- cewa_deleted_at: timestamp
I think hard deletion should be fine here?
Yes, I agree, I don't think we need to restore it not even generate reports on it, I will remove it
- ce_worklists_user_by_article
- cewuba_username: varchar(100) worklist name
Storing usernames is problematic. Firstly because it adds a lot of redundancy, and MW has been moving in the opposite direction for a few years now with the introduction of the actor table and related fields. Secondarily because usernames are not stable identifiers--people get renamed all the time, and tracking that is possible but cumbersome. We should only store the central user ID, like in other places.
Yes, thanks I added it by mistake, will remove it
- cewa_id: ID links the user to the article of the worklist
Would this be useful? Without an indication of how strong the link is (i.e., how much someone has contributed to a given article), we probably wouldn't want to use this for analytics purposes or anything.
I think this may be useful to get data like:
- Which articles retuned this user
- This user is present in how many articles on my worklist
Hi @ifried and @gonyeahialam, there are 2 things that come up on code reviews, that I need your feedback on:
Mon, May 27
Thu, May 23
Wed, May 22
Tue, May 21
The event address is also shown on both event details special page and event details modal on the event page, I think we should also hide them
Mon, May 20
For the special wikis, I am not sure if we should display them or not. Here is the list of all special wikis returned by the Sitematrix API:
I don't think we should. Or maybe with exceptions. Many of these wikis are not even SUL wikis and wouldn't work in our current setup.
Yes, I agree, we can check with @ifried if we can exclude them all of if there is some exception.
May 17 2024
Based on what was shared about aggregate analytics, it sounds that a more structured database is needed in order to be able to create reports like:
- Last year, you organized three events and 10% of the people you invited ended up joining your events
- This year, you organized three events and 20% of the people you invited ended up joining your events
May 15 2024
May 14 2024
I did a bunch of tests using the Sitematrix API, and other related APIs I found to get the list of wikis, here are my findings:
May 8 2024
Recommendations
So these are my design options to improve the invitation list management, with a preference for Option 1 for the MVP.
Option 1 Option2 Combination of Idea 1 and 2a Combination of Idea 1 and 2b