Page MenuHomePhabricator

defeature __NOEDITSECTION__ from VE
Closed, DeclinedPublic

Description

Under Page Settings/Advanced Settings there are options to disable section editing in a page.
This option isn't relevant to 99% of the pages and having it available in VE is harmful:

  • New editors add this mistakenly to pages
  • Too many options are confusing
  • developers/VE team have to maintain those options/dialog

Event Timeline

eranroz raised the priority of this task from to Needs Triage.
eranroz updated the task description. (Show Details)
eranroz added a project: VisualEditor.
eranroz subscribed.

To where do you think we should move the feature? It's not clear.

I think it should either completely removed from the VE, or should be hidden when editing pages that are not on talk pages and not portals (since VE isn't enabled in those namespaces, it effectively the same)

Reason: (use enwiki_p;)
select page_namespace, count(page_namespace) from page_props inner join page on page_id=pp_page where pp_propname='noeditsection' group by page_namespace ;
+----------------+-----------------------+

page_namespacecount(page_namespace)

+----------------+-----------------------+

0156
161040
25611
389227
412402
514198
726
836
9151
102644
111569
12136
13122
1414
1552
1007262
101195
1081
1091
1182
1193
4474
828232
82930

+----------------+-----------------------+

The same is true also for nonewsectionlink/newsectionlink magic words:
+----------------+-----------------------+

page_namespacecount(page_namespace)

+----------------+-----------------------+

012
161062
25665
387083
43549
516550
726
9113
1053
111570
1267
13122
1551
100236
101172
11821014
1196
4472
82930

+----------------+-----------------------+

Jdforrester-WMF claimed this task.

No. VisualEditor is intentionally a full-service editor. De-featuring it is fine, but we're not removing the functionality.

eranroz set Security to None.

I'm sorry James but you probably don't understand the purpose of NOEDITSECTION feature.
Please discuss with someone who do know it (for example @WhatamIdoing ).
A NOEDITSECITON option in the page settings is like a disc format near the start menu - users accidentally enable it and other users don't understand why they can't edit sections.
NOEDITSECTION has a very specific use case, that should be used by "power users".

You are mistaken. I know very well what it does. I was an editor well before we had this feature, and I will be an editor well after we remove this feature from MediaWiki. But until that day, the request to remove it from VisualEditor is an absolute "no".

So please explain how should we handle users who mistakenly press on this button and other users don't understand why did the edit buttons dissappeared? (this already happen too many times...)
As a sysop, should I block those users and call them vandals just because they press this button? and what use case it does serves - creating a new main page using the VE??

James, how about I file a task to kill the NOEDITSECTION feature in MediaWiki? ;-)

VisualEditor is intentionally a full-service editor.

I feel the importance of this sentence was not understood. Since a few months, the goal was established that VisualEditor must be able to do everything action=edit does and in general be an improvement also for experienced editors. (More or less.)

There is probably some high-level mediawiki.org page where the principle is featured prominently and where eranroz's perspective would be most useful.

For what it is worth, the setting is under advanced settings so it is quiet unlikely new editors disable the heading edit links by mistake. Most probably they are playing with option and feel the end result is nicer without the editing links.

The information icon on enwiki states:

You can stop the edit links from appearing next to each section in the unusual case where that is appropriate.

Maybe it can be slightly rephrased on enwiki to discourage its usage on the main namespace.

I believe I should reopen the task, if the new one was merged here.

Krenair subscribed.

nope, getting merged into a declined task basically means declined

So, the bug will remain forever?

So, the bug will remain forever?

See T100691#1377356. Can someone link a mediawiki.org page where the high level principle underlying the "decline" is expressed, so that people can understand/comment/challenge the principle if they wish?

So, the bug will remain forever?

The NOEDITSECTION keyword is a feature of MediaWiki itself and VisualEditor just implements the possibility for people to add it instead of having to edit the Wikitext. From my previous comment T100691#1377477:

[..] the setting is under advanced settings so it is quite unlikely new editors disable the heading edit links by mistake.[..]

From there, if one would like to discourage the use of this feature, I would recommend to override the information icon on a per project basis. One can state that the use of that feature is discouraged on the project.

The information icon on enwiki states:

You can stop the edit links from appearing next to each section in the unusual case where that is appropriate.

The corresponding l10n message is visualeditor-dialog-meta-settings-noeditsection-help editable on enwiki at: https://en.wikipedia.org/wiki/MediaWiki:Visualeditor-dialog-meta-settings-noeditsection-help . Maybe it can be slightly rephrased on enwiki to discourage its use on the main namespace.


As for the original request to remove the NOEDITSECTION feature, the removal request need to be proposed for MediaWiki itself. If it was accepted, VisualEditor will catch up and remove it. I am pretty sure MediaWiki will keep NOEDITSECTION, hence this task is declined.


Hope that clarify and that editing the information message is a good workaround.

As I shows in https://phabricator.wikimedia.org/T100691#1320853 NOEDITSECTION is not being used in main namespace, though it is cool to have NOEDITSECTION in VE for talk pages...

So, the bug will remain forever?

Yes - unless you convince product owner/devs that it is bug and this should be removed.
I doubt you can find a more convincing argument than the DB query in my first comment that shows that this feature is being used by 156/5000000 pages in enwiki.

Anyway, if you get community consensus in specific project you can disable it by CSS:
.ns-0 .ve-test-page-settings-noeditsection { display: 'none' }

This isn't a nice solution since changes in the VE code may break it, or even worse - you may break the VE design of the page settings.