Page MenuHomePhabricator
Create Task
Maniphest T104318

[GOAL]: Testing practices & expose test coverage
Closed, ResolvedPublic
Actions

Description

Subgoals

  • Expose test coverage metrics on documentation site.
  • Expose test coverage metrics on each submitted patch.

Developing a testing culture

Why

Test coverage indicates what percentage of our code is tested and helps improve
the confidence and reliability when making changes.

Current situation

There's no (or little) insight into code coverage by our tests on our
properties.

We are fairly lax on adding and merging code without the proper coverage.

Objectives
  • Document how and expose test coverage of our properties.
  • Run coverage reports by patch. Notify.
  • Educate the team on the validity of a patch without tests. Training sessions.
  • Improve test coverage of the worst offender artifacts.
  • Ongoing mentoring and conversations, offsites, training
Estimated work

1 sprint ~25%

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• JhernandezT104318 [GOAL]: Testing practices & expose test coverage
 OpenNoneT100294 [EPIC] Encourage developers to increase code coverage
 ResolvedLegoktmT71685 Generate PHP code coverage reports for extensions
 StalledNoneT88434 generate Wikibase.git code coverage on Jenkins
 OpenNoneT74318 [Task] add possibility to generate proper phpunit coverage reports of Wikibase.git
 OpenNoneT88435 [Task] generate patch code coverage on gerrit patch-set upload for wikibase.git
 ResolvedJdlrobsonT102006 Add @covers annotations to MobileFrontend PHPUnit tests
 DuplicateNoneT151333 Proof of concept to generate coverage report of some Wikimedia mediawiki extensions
 OpenNoneT185211 Generate coverage report for Wikidata extensions
 OpenNoneT288396 [REPO][CLIENT][SW] Re-start Wikibase test coverage reporting
 ResolvedLegoktmT101544 Provide (pre-merge) code coverage reports on patchsets
 DeclinedJdlrobsonT103440 Write tests for modules that are in stable and have low code coverage
 DeclinedJdlrobsonT112568 `grunt qunit` tool no longer works
 DeclinedNoneT103578 Improve Gather unit test coverage
 ResolvedLegoktmT111396 [EPIC] Wikimedia should use a standard set of tools for managing code quality
 DeclinedNoneT86587 [jsduck] Various custom tags should be easily shareable between projects
 DeclinedNoneT107588 EPIC: Detect and prevent UI regressions
 ResolvedSpikeovasilevaT236722 [Spike, 10hrs] Investigate automated visual regression tools
 OpenNoneT184657 Generate JavaScript code coverage reports for extensions
 OpenNoneT116808 Provide a CI job to generate JS code coverage reports for extensions by using karma-coverage instead of just karma
 OpenpwangaiT211710 Expose code coverage stats for Services

Event Timeline

• Jhernandez created this task.Jun 30 2015, 11:27 AM
• Jhernandez claimed this task.
• Jhernandez raised the priority of this task from to Medium.
• Jhernandez updated the task description. (Show Details)
• Jhernandez added a project: Web-Team-Backlog.
• Jhernandez moved this task to Completely Invisible Column 22 on the Web-Team-Backlog board.
• Jhernandez subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2015, 11:27 AM
• Jhernandez edited projects, added Reading-Web-Planning; removed Web-Team-Backlog.Jul 2 2015, 9:22 AM
• Jhernandez added a subtask: T100294: [EPIC] Encourage developers to increase code coverage.Jul 2 2015, 12:04 PM
• Jhernandez moved this task from To classify to Q1 Goals on the Reading-Web-Planning board.Jul 8 2015, 11:05 AM
• Jhernandez renamed this task from Testing practices & expose test coverage to [GOAL]: Testing practices & expose test coverage.Jul 31 2015, 4:26 PM
• Jhernandez set Security to None.
Jdlrobson moved this task from Q1 Goals to Goals on the Reading-Web-Planning board.Sep 18 2015, 7:54 PM
Jdlrobson moved this task from Goals to Q1 Goals on the Reading-Web-Planning board.Sep 18 2015, 8:31 PM
Jdlrobson moved this task from Q1 Goals to Goals on the Reading-Web-Planning board.Sep 30 2015, 8:33 PM
jayvdb subscribed.Oct 15 2015, 9:05 AM
bd808 moved this task from Goals to To classify on the Reading-Web-Planning board.Dec 28 2015, 4:24 PM
Jdlrobson moved this task from To classify to Backlog on the Reading-Web-Planning board.May 17 2016, 6:15 PM
• Phabricator_maintenance added a project: Goal.Aug 13 2016, 8:39 PM
Jdlrobson edited projects, added Web-Team-Backlog, Epic; removed Reading-Web-Planning.Oct 9 2017, 5:03 PM
MBinder_WMF moved this task from Completely Invisible Column 22 to Epics/Goals on the Web-Team-Backlog board.Oct 10 2017, 8:03 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Jan 12 2018, 5:06 PM
Jdlrobson moved this task from Untriaged to Discuss further on the Web-Team-Backlog (Tracking) board.Feb 7 2018, 5:51 PM
Jdlrobson closed this task as Resolved.Sep 10 2019, 11:59 PM
Jdlrobson subscribed.

Closing given that we have code coverage reports in MobileFrontend: https://doc.wikimedia.org/MobileFrontend/master/js/lcov-report/mobile.startup/Browser.js.html and we are achieving both of the goals

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits