[SPIKE][Infra] Re-start Wikibase test coverage reporting
Closed, ResolvedPublic
Actions

Description

Currently (2024-12-19), the Wikibase extension does not appear on https://doc.wikimedia.org/cover-extensions/. Clicking https://doc.wikimedia.org/cover-extensions/Wikibase/ leads to a 404 HTTP error, as the folder containing coverage test results was removed due to the false positives described below in the original report.

Acceptance Criteria:

We are clear on what is required in order to re-enable the reports and, depending on level of effort:
Wikibase coverage stats appears in https://doc.wikimedia.org/cover-extensions/
Detailed coverage information exists in https://doc.wikimedia.org/cover-extensions/Wikibase
Coverage reporting runs on a periodic OR per change basis (See open questions)

Notes:

-In the following comments and patches, a solution was discussed to re-enable the coverage reporting for Wikibase. However, this seems to have not been operational and was reverted in 1017888. The complexities behind this are not mentioned.

Original Report:

Following on from T287913: Enable extension-coverage on most WMF deployed and all MW bundled extensions

Wikibase shows on https://doc.wikimedia.org/cover-extensions/ at 19% coverage. But if you click in to https://doc.wikimedia.org/cover-extensions/Wikibase/ you get Empty directory!

Seems this might be worth fixing

Open Questions

Should we run coverage reporting per patch, as is done in most extensions? Or will it be more performant to enable coverage reporting on a periodic (daily/weekly) basis, if possible?

Timebox: 4 days

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
quibble-coverage: pass --test-dir as a relative path	integration/config	master	+13 -2
jjb: quibble-coverage: use relative test-dir	integration/config	master	+3 -3
(DO NOT SUBMIT) test coverage	mediawiki/extensions/Wikibase	master	+2 -0
jjb: fix patch coverage generation for Wikibase	integration/config	master	+3 -3
Fix patch coverage generation for Wikibase	integration/config	master	+32 -4
zuul: add back coverage job to Wikibase	integration/config	master	+1 -1
jjb: update coverage jobs for Wikibase	integration/config	master	+3 -3
Fix `suite.xml` coverage configuration generation for Wikibase	integration/config	master	+44 -4
Revert "layout.yaml: Add extension-coverage to Wikibase extension"	integration/config	master	+1 -1
jjb: rm Docker image override for mwext-phpunit-coverage-docker	integration/config	master	+0 -1
Add experimental coverage job for Wikibase	integration/config	master	+10 -0
dockerfiles: use extension base path for coverage report	integration/config	master	+9 -2

Related Objects
Search...

Status	Assigned	Task
Resolved	• Jhernandez	T104318 [GOAL]: Testing practices & expose test coverage
Resolved	None	T100294 [EPIC] Encourage developers to increase code coverage
Resolved	Legoktm	T71685 Generate PHP code coverage reports for extensions
Resolved	hashar	T185211 Generate coverage report for Wikidata extensions
Open	None	T242617 Wikibase post-merge builds are failing
Resolved	None	T288396 [SPIKE][Infra] Re-start Wikibase test coverage reporting

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

I don't know why mwext-phpunit-coverage is a shell script instead of being part of quibble. Maybe @hashar can explain why it was done that way. I couldn't find an explanation in T195918.

I think core's ExtensionsTestSuite should create one suite per extension, under a top-level extensions suite. Then CI could just run that suite, instead of trying to guess the path.

Alternatively, you can just specify extensions/Wikibase as the path. It seems to work.

T288396#8979619 is a very nice dig :)

If you omit the $ext/tests/phpunit argument, it runs 36438 tests (presumably all tests from all installed extensions).

Actually it's unclear to me how CI can ever run only the tests from a specific extension. It looks as if non-coverage test jobs will always run tests from extension dependencies.

When a patch is triggered for a MediaWiki extension, Quibble invokes composer run phpunit:entrypoint -- --testsuite extensions. The suite is defined in mediawiki/core tests/phpunit/suite.xml and finds tests extensions registered via the onUnitTestsList hook.

As a result, Quibble triggers PHPUnit tests for every single extensions that are dependencies. It is a brute force approach to run the cross extensions integration tests. There are a lot of issues: we run way too many tests and given the dependencies are not bi directional, some integration tests are not run when an extension is not defined as a dependency. But I digress.

The coverage is rendered with solely for tests of the triggering extension (and thus the coverage reports lacks any tests exercised by other repositories). It is probably not a big issue.

Alternatively, you can just specify extensions/Wikibase as the path. It seems to work.

That is the root cause I guess, congratulation. tests/phpunit suffix probably rely on the convention used for most extension but clashes with Wikibase (and possibly other extensions). The path suffix comes from 2018 patch Only run that extension's tests in coverage job https://gerrit.wikimedia.org/r/c/integration/config/+/405393

The scripts can be altered:

dockerfiles/quibble-buster-php74-coverage/mwext-phpunit-coverage.sh

- "$MW_INSTALL_PATH/extensions/$EXT_NAME/tests/phpunit" &
+ "$MW_INSTALL_PATH/extensions/$EXT_NAME" &

dockerfiles/quibble-buster-php74-coverage/mwskin-phpunit-coverage.sh

- "$MW_INSTALL_PATH/extensions/$SKIN_NAME/tests/phpunit" &
+ "$MW_INSTALL_PATH/extensions/$SKIN_NAME" &

If I fix the test path, I still get "Warning: Incorrect filter configuration, code coverage will not be processed". This is probably because src/, includes/ and maintenance/ are all non-existent, and so no files are included in the coverage filter. Perhaps CI could get the list of directories to cover from some configuration file in the extension, instead of guessing.

MediaWiki core has composer run phpunit:coverage-edit which invokes includes/composer/ComposerPhpunitXmlCoverageEdit.php which looks similar to the CI script phpunit-suite-edit.py uses the same wrong assumption. Looks like it can be replaced by the MediaWiki core equivalent code. I have found T235031: phpunit:coverage-edit - Add configuration flag so it can replace phpunit-suite-edit.py.

Change 935410 had a related patch set uploaded (by Hashar; author: Tim Starling):

[integration/config@master] dockerfiles: use extension base path for coverage report

https://gerrit.wikimedia.org/r/935410

gerritbot added a project: Patch-For-Review.Jul 4 2023, 12:27 PM

In T288396#8987843, @hashar wrote:

MediaWiki core has composer run phpunit:coverage-edit which invokes includes/composer/ComposerPhpunitXmlCoverageEdit.php which looks similar to the CI script phpunit-suite-edit.py uses the same wrong assumption. Looks like it can be replaced by the MediaWiki core equivalent code. I have found T235031: phpunit:coverage-edit - Add configuration flag so it can replace phpunit-suite-edit.py.

It's all very unsatisfying. I don't want to touch it because I don't like any part of it. I'd end up patching MediaWiki, PHPUnit, Quibble and integration/config/dockerfiles. A month later, my PHPUnit PRs would be rejected and we'd be back to square one. Maybe you can slip something like if args.cover_extension == 'Wikibase': into phpunit-suite-edit.py and I can pretend not to see it.

Ollie.Shotton_WMDE mentioned this in T306044: [Timebox 12h] Investigate enabling code coverage reporting for the Wikibase REST API in CI.Jul 5 2023, 9:08 AM

Ladsgroup subscribed.Jul 5 2023, 9:09 AM

Change 935410 merged by jenkins-bot:

[integration/config@master] dockerfiles: use extension base path for coverage report

https://gerrit.wikimedia.org/r/935410

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2023, 11:30 AM

hashar added a parent task: T242617: Wikibase post-merge builds are failing.Jul 10 2023, 4:31 PM

Change 936768 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Add experimental coverage job for Wikibase

https://gerrit.wikimedia.org/r/936768

gerritbot added a project: Patch-For-Review.Jul 10 2023, 4:43 PM

Change 936768 merged by jenkins-bot:

[integration/config@master] Add experimental coverage job for Wikibase

https://gerrit.wikimedia.org/r/936768

Change 936770 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Wikibase@master] (DO NOT SUBMIT) test coverage

https://gerrit.wikimedia.org/r/936770

Michael subscribed.Jul 10 2023, 5:48 PM

I gave it a try with a new job mwext-phpunit-coverage-docker which has the new image version.

The new job does run Phpunit with just the extension:

php -d extension=pcov.so -d pcov.enabled=1 -d pcov.directory=/workspace/src/extensions/Wikibase \
  -d 'pcov.exclude=@(tests|vendor)@'
   --coverage-clover /workspace/log/clover.xml
   --coverage-html /workspace/cover
   --log-junit /workspace/log/junit.xml
      /workspace/src/extensions/Wikibase

I have send a dummy change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/936770 which removes repo/tests/phpunit/includes/ArrayValueCollectorTest.php and it fails a test https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-docker/4/console#console-section-11

00:07:57.819 1) Wikibase\Repo\Tests\Api\PermissionsTest::testCreateItem with data set "normal permissions, no error" (null, null)
00:07:57.819 API did not return expected error code. Got error message ApiUsageException: failed-save: The save has failed. in /workspace/src/includes/api/ApiBase.php:1543

Which looks unrelated. If I retry with a change which does not alter anything, the same issue occurs so something is off.

Change 936770 abandoned by Hashar:

[mediawiki/extensions/Wikibase@master] (DO NOT SUBMIT) test coverage

Reason:

https://gerrit.wikimedia.org/r/936770

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2023, 2:10 PM

Change 960553 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: rm Docker image override for mwext-phpunit-coverage-docker

https://gerrit.wikimedia.org/r/960553

Change 960553 merged by jenkins-bot:

[integration/config@master] jjb: rm Docker image override for mwext-phpunit-coverage-docker

https://gerrit.wikimedia.org/r/960553

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2023, 9:11 AM

Michael moved this task from Backlog to Tech on the MediaWiki-extensions-Wikibase-Client board.Mar 6 2024, 4:23 PM

Lucas_Werkmeister_WMDE mentioned this in T185211: Generate coverage report for Wikidata extensions.Apr 2 2024, 9:40 AM

hashar added a parent task: T185211: Generate coverage report for Wikidata extensions.Apr 2 2024, 1:00 PM

ArthurTaylor renamed this task from Re-start Wikibase test coverage reporting to [REPO][CLIENT][SW] Re-start Wikibase test coverage reporting.Apr 2 2024, 2:34 PM

ArthurTaylor edited projects, added wmde-wikidata-tech; removed [DEPRECATED] wdwb-tech.

ArthurTaylor moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board.

ArthurTaylor added a project: [Archived]Wikidata Dev Team.

Change #1017888 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[integration/config@master] Revert "layout.yaml: Add extension-coverage to Wikibase extension"

https://gerrit.wikimedia.org/r/1017888

gerritbot added a project: Patch-For-Review.Apr 8 2024, 4:08 PM

Change #1017888 merged by jenkins-bot:

[integration/config@master] Revert "layout.yaml: Add extension-coverage to Wikibase extension"

https://gerrit.wikimedia.org/r/1017888

Lucas_Werkmeister_WMDE removed a project: Patch-For-Review.Apr 23 2024, 1:14 PM

Arian_Bozorg moved this task from Incoming to [DOT] Tech Backlog on the [Archived]Wikidata Dev Team board.Apr 23 2024, 1:15 PM

hashar mentioned this in T74318: [Task] add possibility to generate proper phpunit coverage reports of Wikibase.git.Oct 24 2024, 2:33 PM

hashar mentioned this in T88434: generate Wikibase.git code coverage on Jenkins.

karapayneWMDE removed a project: [Archived]Wikidata Dev Team.Nov 29 2024, 1:37 PM

ItamarWMDE moved this task from [DOT] By Project to Wikidata Omega Triage on the wmde-wikidata-tech board.Dec 4 2024, 11:42 AM

ItamarWMDE edited projects, added wmde-wikidata-tech (Wikidata Omega Triage); removed wmde-wikidata-tech.

ItamarWMDE moved this task from Incoming to Repo on the wmde-wikidata-tech (Wikidata Omega Triage) board.Dec 4 2024, 2:10 PM

ItamarWMDE moved this task from Repo to Infrastructure on the wmde-wikidata-tech (Wikidata Omega Triage) board.Dec 4 2024, 3:23 PM

ItamarWMDE moved this task from Infrastructure to Checks Completeness on the wmde-wikidata-tech (Wikidata Omega Triage) board.Dec 6 2024, 10:41 AM

Prio Notes:

Impact Area	Affected
production / end users	n
monitoring	y
development efforts	y
onboarding efforts	n
additional stakeholders	n

ItamarWMDE triaged this task as Medium priority.Dec 17 2024, 11:41 AM

ItamarWMDE moved this task from Checks Completeness to Prioritized - Moving a task here moves the ticket to Wikidata Dev and removes it from this board on the wmde-wikidata-tech (Wikidata Omega Triage) board.Dec 17 2024, 12:03 PM

ItamarWMDE edited projects, added [Archived]Wikidata Dev Team; removed wmde-wikidata-tech (Wikidata Omega Triage).

ItamarWMDE renamed this task from [REPO][CLIENT][SW] Re-start Wikibase test coverage reporting to [SPIKE][Infra] Re-start Wikibase test coverage reporting.Dec 18 2024, 10:57 AM

ItamarWMDE updated the task description. (Show Details)

ItamarWMDE moved this task from [DOT] Tech Backlog to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Dec 18 2024, 11:15 AM

ArthurTaylor claimed this task.Feb 18 2025, 10:24 AM

ArthurTaylor edited projects, added [Archived]Wikidata Dev Team (Wikidata.org Slice); removed [Archived]Wikidata Dev Team.

ArthurTaylor moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Change #1120532 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[integration/config@master] Fix `suite.xml` coverage configuration generation for Wikibase

https://gerrit.wikimedia.org/r/1120532

gerritbot added a project: Patch-For-Review.Feb 18 2025, 12:45 PM

Had another look at this. By now, the Wikibase suite seems to pass when run under coverage, but the suite.xml changes still need to be made. Hopefully my patch is a bit more elegant than T288396#8989408, but I agree it's not the prettiest. This will need a bump of the dockerfiles / quibble images, and after that it should be fine to revert^^2 the layout.yaml changes again and the coverage should be restored. In my local testing, the quibble job runs successfully with the changed python script.

Change #1121372 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update coverage jobs for Wikibase

https://gerrit.wikimedia.org/r/1121372

Change #1120532 merged by jenkins-bot:

[integration/config@master] Fix `suite.xml` coverage configuration generation for Wikibase

https://gerrit.wikimedia.org/r/1120532

Change #1121372 merged by jenkins-bot:

[integration/config@master] jjb: update coverage jobs for Wikibase

https://gerrit.wikimedia.org/r/1121372

Change #1121375 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] zuul: add back coverage job to Wikibase

https://gerrit.wikimedia.org/r/1121375

Change #1121375 merged by jenkins-bot:

[integration/config@master] zuul: add back coverage job to Wikibase

https://gerrit.wikimedia.org/r/1121375

ArthurTaylor moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Feb 20 2025, 2:58 PM

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Feb 20 2025, 3:02 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 20 2025, 3:31 PM

The mwext-phpunit-coverage-patch job then fails with:

+ exec phpunit-patch-coverage check --command 'php -d extension=pcov.so -d pcov.enabled=1 -d pcov.directory=/workspace/src/extensions/Wikibase -d pcov.exclude='\''@(tests|vendor)@'\'' -d pcov.initial.files=3000 "$MW_INSTALL_PATH"/tests/phpunit/phpunit.php' --html /workspace/log/coverage.html
Finding coverage difference in 498b1dcb7287c90063ab7996a0beeadc98b3ba95

In Finder.php line 592:
                                                 
  The "tests/phpunit" directory does not exist.  
                                                 

check [--sha1 [SHA1]] [--test-dir TEST-DIR] [--html [HTML]] [--command COMMAND]

That is the job diffing the coverage of the parent and current patch.

After merge, the job mwext-phpunit-coverage-publish completed and a coverage report as been published at https://doc.wikimedia.org/cover-extensions/Wikibase/

There were 72 warnings due to invalid @covers annotations, I have pasted them in P73497:

P73497 Wikibase coverage warnings

1	There were 72 warnings:
2
3	1) Tests\Wikibase\DataModel\ReferenceSerializationRoundtripTest::testSnakSerializationRoundtrips with data set #0 (Wikibase\DataModel\Reference Object (...))
4	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
5
6	2) Tests\Wikibase\DataModel\ReferenceSerializationRoundtripTest::testSnakSerializationRoundtrips with data set #1 (Wikibase\DataModel\Reference Object (...))
7	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
8
9	3) Tests\Wikibase\DataModel\ReferenceSerializationRoundtripTest::testSnakSerializationRoundtrips with data set #2 (Wikibase\DataModel\Reference Object (...))
10	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
11
12	4) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewEntityDeserializer
13	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
14
15	5) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewItemDeserializer
16	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
17
18	6) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewPropertyDeserializer
19	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
20
21	7) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewSiteLinkDeserializer
22	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
23
24	8) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewStatementDeserializer
25	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
26
27	9) Tests\Wikibase\DataModel\DeserializerFactoryTest::testStatementListDeserializer
28	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
29
30	10) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewReferencesDeserializer
31	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
32
33	11) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewReferenceDeserializer
34	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
35
36	12) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewSnakDeserializer
37	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
38
39	13) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewEntityIdDeserializer
40	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
41
42	14) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewTermDeserializer
43	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
44
45	15) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewTermListDeserializer
46	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
47
48	16) Tests\Wikibase\DataModel\DeserializerFactoryTest::testNewAliasGroupListDeserializer
49	"@covers Wikibase\DataModel\DeserializerFactory" is invalid
50
51	17) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewEntitySerializer
52	"@covers Wikibase\DataModel\SerializerFactory" is invalid
53
54	18) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewItemSerializer
55	"@covers Wikibase\DataModel\SerializerFactory" is invalid
56
57	19) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewPropertySerializer
58	"@covers Wikibase\DataModel\SerializerFactory" is invalid
59
60	20) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewSiteLinkSerializer
61	"@covers Wikibase\DataModel\SerializerFactory" is invalid
62
63	21) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewStatementSerializer
64	"@covers Wikibase\DataModel\SerializerFactory" is invalid
65
66	22) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewStatementListSerializer
67	"@covers Wikibase\DataModel\SerializerFactory" is invalid
68
69	23) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewReferencesSerializer
70	"@covers Wikibase\DataModel\SerializerFactory" is invalid
71
72	24) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewReferenceSerializer
73	"@covers Wikibase\DataModel\SerializerFactory" is invalid
74
75	25) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewSnakListSerializer
76	"@covers Wikibase\DataModel\SerializerFactory" is invalid
77
78	26) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewSnakSerializer
79	"@covers Wikibase\DataModel\SerializerFactory" is invalid
80
81	27) Tests\Wikibase\DataModel\SerializerFactoryTest::testFactoryCreateWithUnexpectedValue
82	"@covers Wikibase\DataModel\SerializerFactory" is invalid
83
84	28) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewTypedSnakSerializer
85	"@covers Wikibase\DataModel\SerializerFactory" is invalid
86
87	29) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewTermSerializer
88	"@covers Wikibase\DataModel\SerializerFactory" is invalid
89
90	30) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewTermListSerializer
91	"@covers Wikibase\DataModel\SerializerFactory" is invalid
92
93	31) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewAliasGroupSerializer
94	"@covers Wikibase\DataModel\SerializerFactory" is invalid
95
96	32) Tests\Wikibase\DataModel\SerializerFactoryTest::testNewAliasGroupListSerializer
97	"@covers Wikibase\DataModel\SerializerFactory" is invalid
98
99	33) Tests\Wikibase\DataModel\SerializerFactoryTest::testSerializeSnaksWithoutHashConstant
100	"@covers Wikibase\DataModel\SerializerFactory" is invalid
101
102	34) Wikibase\Lib\Tests\Formatters\DispatchingEntityIdHtmlLinkFormatterTest::testGivenFormatterMissing_UseDefaultFormatter
103	"@covers \Wikibase\Lib\DispatchingEntityIdHtmlLinkFormatter" is invalid
104
105	35) Wikibase\Lib\Tests\Formatters\DispatchingEntityIdHtmlLinkFormatterTest::testGivenFormatterExists_FormatterUsed
106	"@covers \Wikibase\Lib\DispatchingEntityIdHtmlLinkFormatter" is invalid
107
108	36) Wikibase\Lib\Tests\Formatters\DispatchingEntityIdHtmlLinkFormatterTest::testGivenInvalidFormatter
109	"@covers \Wikibase\Lib\DispatchingEntityIdHtmlLinkFormatter" is invalid
110
111	37) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::testGetDataTypeFactory with data set #0 (Wikibase\Lib\Modules\DataTypesModule Object (...), array('foo', Closure Object (...)))
112	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
113
114	38) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::testGetDataTypeFactory with data set #1 (Wikibase\Lib\Modules\DataTypesModule Object (...), array('bar123', Wikibase\Lib\DataTypeFactory Object (...)))
115	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
116
117	39) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::testGetConfigVarName with data set #0 (Wikibase\Lib\Modules\DataTypesModule Object (...), array('foo', Closure Object (...)))
118	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
119
120	40) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::testGetConfigVarName with data set #1 (Wikibase\Lib\Modules\DataTypesModule Object (...), array('bar123', Wikibase\Lib\DataTypeFactory Object (...)))
121	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
122
123	41) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::Instantiation raises exception in case missing "datatypefactory" field with data set #0 (array('foo'), 'missing "datatypefactory" field')
124	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
125
126	42) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::Instantiation raises exception in case missing "datatypesconfigvarname" field with data set #1 (array(Wikibase\Lib\DataTypeFactory Object (...)), 'missing "datatypesconfigvarname" field')
127	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
128
129	43) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::Instantiation raises exception in case all fields missing with data set #2 (array(), 'all fields missing')
130	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
131
132	44) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::Instantiation raises exception in case "datatypefactory" field has value of wrong type with data set #3 (array('foo', 123), '"datatypefactory" field has v...g type')
133	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
134
135	45) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::Instantiation raises exception in case "datatypefactory" callback does not return a DataTypeFactory instance with data set #4 (array('foo', Closure Object (...)), '"datatypefactory" callback do...stance')
136	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
137
138	46) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::testGetDefinitionSummary
139	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
140
141	47) Wikibase\Lib\Tests\Modules\DataTypesModuleTest::testGetDefinitionSummary_notEqualForDifferentDataTypes
142	"@covers \WikibaseRepo\Modules\DataTypesModule" is invalid
143
144	48) Wikibase\Lib\Tests\Rdbms\ClientDomainDbFactoryTest::testNewClientDb
145	"@covers \Wikibase\Lib\Rdbms\DomainDbFactory" is invalid
146
147	49) Wikibase\Lib\Tests\Store\TitleLookupBasedEntityExistenceCheckerTest::testExists with data set "title is null" (true, false, false)
148	"@covers \Wikibase\Lib\Store\TitleBasedEntityExistenceChecker" is invalid
149
150	50) Wikibase\Lib\Tests\Store\TitleLookupBasedEntityExistenceCheckerTest::testExists with data set "title is not null and is known" (false, true, true)
151	"@covers \Wikibase\Lib\Store\TitleBasedEntityExistenceChecker" is invalid
152
153	51) Wikibase\Lib\Tests\Store\TitleLookupBasedEntityExistenceCheckerTest::testExists with data set "title is not null and not known" (false, false, false)
154	"@covers \Wikibase\Lib\Store\TitleBasedEntityExistenceChecker" is invalid
155
156	52) Wikibase\Lib\Tests\Store\TitleLookupBasedEntityExistenceCheckerTest::testExistsBatch
157	"@covers \Wikibase\Lib\Store\TitleBasedEntityExistenceChecker" is invalid
158
159	53) Wikibase\Lib\Tests\Store\TitleLookupBasedEntityRedirectCheckerTest::testIsRedirect with data set "title not found" (Closure Object (...), false)
160	"@covers \Wikibase\Lib\Store\TitleBasedEntityRedirectChecker" is invalid
161
162	54) Wikibase\Lib\Tests\Store\TitleLookupBasedEntityRedirectCheckerTest::testIsRedirect with data set "title is not local" (Closure Object (...), false)
163	"@covers \Wikibase\Lib\Store\TitleBasedEntityRedirectChecker" is invalid
164
165	55) Wikibase\Lib\Tests\Store\TitleLookupBasedEntityRedirectCheckerTest::testIsRedirect with data set "local title is not a redirect" (Closure Object (...), false)
166	"@covers \Wikibase\Lib\Store\TitleBasedEntityRedirectChecker" is invalid
167
168	56) Wikibase\Lib\Tests\Store\TitleLookupBasedEntityRedirectCheckerTest::testIsRedirect with data set "title is a redirect" (Closure Object (...), true)
169	"@covers \Wikibase\Lib\Store\TitleBasedEntityRedirectChecker" is invalid
170
171	57) Wikibase\Repo\Tests\Domains\Crud\RouteHandlers\Middleware\MiddlewareHandlerTest::testConstructorErrorsForNoMiddlewares
172	Trying to @cover interface "\Wikibase\Repo\Domains\Crud\RouteHandlers\Middleware\Middleware".
173
174	58) Wikibase\Repo\Tests\Domains\Crud\RouteHandlers\Middleware\MiddlewareHandlerTest::testRun
175	Trying to @cover interface "\Wikibase\Repo\Domains\Crud\RouteHandlers\Middleware\Middleware".
176
177	59) Wikibase\Repo\Tests\Api\EntityByTitleHelperTest::testGetEntityIdsSuccess
178	"@covers \Wikibase\Repo\Api\ItemByTitleHelper" is invalid
179
180	60) Wikibase\Repo\Tests\Api\EntityByTitleHelperTest::testGetEntityIdNormalized
181	"@covers \Wikibase\Repo\Api\ItemByTitleHelper" is invalid
182
183	61) Wikibase\Repo\Tests\Api\EntityByTitleHelperTest::testGetEntityIdsNotFound
184	"@covers \Wikibase\Repo\Api\ItemByTitleHelper" is invalid
185
186	62) Wikibase\Repo\Tests\Api\EntityByTitleHelperTest::testGetEntityIdsNormalizationNotAllowed
187	"@covers \Wikibase\Repo\Api\ItemByTitleHelper" is invalid
188
189	63) Wikibase\Repo\Tests\Api\EntityByTitleHelperTest::testNormalizeTitle with data set #0 ('foo_bar', 123, 1)
190	"@covers \Wikibase\Repo\Api\ItemByTitleHelper" is invalid
191
192	64) Wikibase\Repo\Tests\Api\EntityByTitleHelperTest::testNormalizeTitle with data set #1 ('Bar', false, 0)
193	"@covers \Wikibase\Repo\Api\ItemByTitleHelper" is invalid
194
195	65) Wikibase\Repo\Tests\Api\EntityByTitleHelperTest::testNotEnoughInput with data set #0 (array(), array('barfoo'), false)
196	"@covers \Wikibase\Repo\Api\ItemByTitleHelper" is invalid
197
198	66) Wikibase\Repo\Tests\Api\EntityByTitleHelperTest::testNotEnoughInput with data set #1 (array('enwiki'), array(), false)
199	"@covers \Wikibase\Repo\Api\ItemByTitleHelper" is invalid
200
201	67) Wikibase\Repo\Tests\ChangeOp\ChangeOpResultTraversalTest::testMakeRecursiveTraversable_returnsTraversableRecrusivelyTraversingTree with data set "root node is not ChangeOpsResult" (Wikibase\Repo\Tests\ChangeOp\ChangeOpResultStub Object (...), array(Wikibase\Repo\Tests\ChangeOp\ChangeOpResultStub Object (...)))
202	"@covers \Wikibase\Repo\ChangeOp\ChangeOpResultsTraverser" is invalid
203
204	68) Wikibase\Repo\Tests\ChangeOp\ChangeOpResultTraversalTest::testMakeRecursiveTraversable_returnsTraversableRecrusivelyTraversingTree with data set "root node is ChangeOpsResult - child is not ChangeOpsResult" (Wikibase\Repo\ChangeOp\ChangeOpsResult Object (...), array(Wikibase\Repo\ChangeOp\ChangeOpsResult Object (...), Wikibase\Repo\Tests\ChangeOp\ChangeOpResultStub Object (...)))
205	"@covers \Wikibase\Repo\ChangeOp\ChangeOpResultsTraverser" is invalid
206
207	69) Wikibase\Repo\Tests\ChangeOp\ChangeOpResultTraversalTest::testMakeRecursiveTraversable_returnsTraversableRecrusivelyTraversingTree with data set "the full tree" (Wikibase\Repo\ChangeOp\ChangeOpsResult Object (...), array(Wikibase\Repo\ChangeOp\ChangeOpsResult Object (...), Wikibase\Repo\ChangeOp\ChangeOpsResult Object (...), Wikibase\Repo\Tests\ChangeOp\ChangeOpResultStub Object (...), Wikibase\Repo\Tests\ChangeOp\ChangeOpResultStub Object (...), Wikibase\Repo\ChangeOp\ChangeOpsResult Object (...), Wikibase\Repo\Tests\ChangeOp\ChangeOpResultStub Object (...), Wikibase\Repo\Tests\ChangeOp\ChangeOpResultStub Object (...)))
208	"@covers \Wikibase\Repo\ChangeOp\ChangeOpResultsTraverser" is invalid
209
210	70) Wikibase\Repo\Tests\ParserOutput\EntityParserOutputDataUpdaterCollectionTest::testUpdateParserOutput
211	Trying to @cover interface "\Wikibase\Repo\ParserOutput\EntityParserOutputUpdater".
212
213	71) Wikibase\Repo\Tests\ParserOutput\EntityParserOutputDataUpdaterCollectionTest::testGivenInvalidDataUpdater_constructorThrowsException with data set #0 (array(null))
214	Trying to @cover interface "\Wikibase\Repo\ParserOutput\EntityParserOutputUpdater".
215
216	72) Wikibase\Repo\Tests\ParserOutput\EntityParserOutputDataUpdaterCollectionTest::testGivenInvalidDataUpdater_constructorThrowsException with data set #1 (array('notAnObject'))
217	Trying to @cover interface "\Wikibase\Repo\ParserOutput\EntityParserOutputUpdater".