Page MenuHomePhabricator

File links should be parsed differently from regular wikilinks
Open, MediumPublic3 Estimated Story Points

Description

In

[[File:Foo.jpg|Caption with [[link]] inside]]

the link inside the caption is not highlighted correctly.

Event Timeline

Schnark raised the priority of this task from to Needs Triage.
Schnark updated the task description. (Show Details)
Schnark subscribed.
Pastakhov triaged this task as Medium priority.
Pastakhov set Security to None.

I'm guessing this is a WONTFIX because determining when there's a link inside a link seems like a complicated problem. @Pastakhov can say more about this.

You do use grammar categories. For example, you can recognize template inside template. Try

{{A|B|{{PAGENAME}}|C}}

@Niharika no, it is not a complicated problem. Just Files contain several different parameters (not only the caption) and it takes a time to write code to cover all them. I will fix it.

@IKhitron the ticket about Files with links in caption, I do not understand the text you wrote above, please, try to rephrase or specify more details

I know, that it is about files. Wgat I wrote is this: the tool is able to recognize construct within construct (as template within template as I mentioned above), so it should be much easier to recognize inner link within inner link for fikes.

@IKhitron the problem is not the same like a template inside a template and solution will be different.
Files have their own syntax and I just skipped this part of code (I had no time)

kaldari set the point value for this task to 3.

Oh, sorry. I got hard busy... I hope to continue in 2-3 weeks :-/

Aklapper added a subscriber: Pastakhov.

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)

Bhsd renamed this task from Files with links in caption not highlighted correctly to File links should be parsed differently from regular wikilinks.Jan 22 2024, 3:41 AM