Page MenuHomePhabricator

Blueprint sidebar reuses #firstHeading id
Closed, ResolvedPublic

Description

@Volker_E noticed that the sidebar.template renders the current page title with

<h1 class="firstHeading" id="firstHeading">{{titletext}}</h1>

it should use a different id, they're meant to be unique.

See also T107738: Blueprint doesn't indicate current page in its left nav links if the page doesn't have a TOC.. Note the current page's title also appears in the main content area (with the same CSS), and may be one of the pages in the sidebar navigation.

Related Objects

StatusAssignedTask
Resolved Spage
Resolved Spage
Resolved Spage
Resolvedori
DeclinedNone
ResolvedNone
DeclinedNone
ResolvedAnomie
DeclinedNone
OpenNone
OpenNone
Resolved Spage
DeclinedNone
Resolvedjeropbrenda
OpenNone
DeclinedQgil
Resolved Spage
ResolvedQgil
ResolvedQgil
ResolvedQgil
Resolved Spage
Resolved Spage
Resolved Spage
DeclinedNone
DeclinedNone
Resolved Spage
Resolved Spage
DeclinedNone
DeclinedNone
DeclinedNone
ResolvedNone
ResolvedVolker_E

Event Timeline

Spage created this task.Sep 1 2015, 1:34 AM
Spage raised the priority of this task from to Low.
Spage updated the task description. (Show Details)
Spage moved this task to Backlog on the Blueprint board.
Spage added subscribers: Spage, Volker_E.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2015, 1:34 AM

That's a question of document semantics as well, see T112487

Change 238080 had a related patch set uploaded (by VolkerE):
Fix duplicate id #firstHeading

https://gerrit.wikimedia.org/r/238080

Change 238080 merged by jenkins-bot:
Fix duplicate id #firstHeading

https://gerrit.wikimedia.org/r/238080

Volker_E closed this task as Resolved.Sep 21 2015, 2:35 AM
Volker_E moved this task from Needs Review / Feedback to Done on the Blueprint board.
Volker_E set Security to None.