Page MenuHomePhabricator
Create Task
Maniphest T113860

Fix structure tests for all skins
Closed, ResolvedPublic
Actions

Description

A few skins have autoloader errors and other related structure tests errors. We have to fix them all. T68926 added a job that runs Mediawiki structure tests to run on all the skins, some have been made voting but we still have to fix the following skins:

BlueSpiceSkin Fixed (depended on extension BlueSpiceFoundation
Bouquet
CustomPageDepend on same name extension but it is a no/no T153050. Need renaming
Daddio
Donate
Gamepress
Metrolook
p2wiki
Refreshed
Splash
Synagonismhttps://gerrit.wikimedia.org/r/#/c/327535/ + a missing arrow-down-focus-icon.png
Tempo
Truglass

They have the structure tests running but the result is ignored.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Sep 26 2015, 7:25 PM
hashar raised the priority of this task from to Medium.
hashar updated the task description. (Show Details)
hashar added a project: Continuous-Integration-Infrastructure.
hashar added subscribers: Jdlrobson, Volker_E, Aklapper and 8 others.
gerritbot added a comment.Sep 26 2015, 7:28 PM

Change 241455 had a related patch set uploaded (by Hashar):
Fix autoloader for EruditeTemplate

https://gerrit.wikimedia.org/r/241455

gerritbot added a project: Patch-For-Review.Sep 26 2015, 7:28 PM

Change 241456 had a related patch set uploaded (by Hashar):
Fix autoloader for ExampleTemplate

https://gerrit.wikimedia.org/r/241456

gerritbot added a comment.Sep 26 2015, 7:28 PM

Change 241457 had a related patch set uploaded (by Hashar):
Fix autoloader for SplashTemplate

https://gerrit.wikimedia.org/r/241457

hashar added a project: BlueSky.Sep 26 2015, 7:30 PM
hashar added a comment.Sep 26 2015, 7:48 PM

BlueSky fails with:

1) Warning
The data provider specified for ResourcesTest::testFileExistence is invalid.
ResourceLoaderFileModule::readStyleFile: style file not found: "/mwskins/BlueSky//resources/src/mediawiki.skinning/interface.css"
2) Warning
The data provider specified for ResourcesTest::testStyleMedia is invalid.
ResourceLoaderFileModule::readStyleFile: style file not found: "/mw/skins/BlueSky//resources/src/mediawiki.skinning/interface.css"

Its skin.json defines:

"ResourceModules": {
    "skins.bluesky": {
        "styles": {
            "resources/src/mediawiki.skinning/interface.css": {
                "media": "screen"
            },
Paladox added a comment.Sep 26 2015, 8:39 PM

Should we just rename the style name to skin.skinanme.style and same for script in same format but instead of it being style it should be script or js.

Paladox added a comment.Sep 26 2015, 8:41 PM

If you look at https://git.wikimedia.org/blob/mediawiki%2Fskins%2FBlueSky/ebab0051ce0700477cac85e96be2f5dcda902623/BlueSky.php it seems it is different to skin.json. Skin.json should be updated to what the php version has and empty php entry point

gerritbot added a comment.Sep 26 2015, 9:01 PM

Change 241465 had a related patch set uploaded (by Paladox):
empty php entry point, remove non existing css files

https://gerrit.wikimedia.org/r/241465

gerritbot added a comment.Sep 26 2015, 10:25 PM

Change 241455 merged by jenkins-bot:
Fix autoloader for EruditeTemplate

https://gerrit.wikimedia.org/r/241455

gerritbot added a comment.Sep 26 2015, 10:25 PM

Change 241456 merged by jenkins-bot:
Fix autoloader for ExampleTemplate

https://gerrit.wikimedia.org/r/241456

gerritbot added a comment.Sep 26 2015, 10:25 PM

Change 241457 merged by jenkins-bot:
Fix autoloader for SplashTemplate

https://gerrit.wikimedia.org/r/241457

hashar mentioned this in rSEXA9e575055ec37: Fix autoloader for ExampleTemplate.Sep 26 2015, 10:26 PM
hashar mentioned this in rSSPLcaa1c2f8d7d4: Fix autoloader for SplashTemplate.
hashar mentioned this in rSKINce07fb02805f: Updated mediawiki/skins Project: mediawiki/skins/erudite….
Diffusion mentioned this in rSKIN43f69200afa8: Updated mediawiki/skins Project: mediawiki/skins/Example….Sep 26 2015, 10:26 PM
Diffusion mentioned this in rSKINeb617a6d48c8: Updated mediawiki/skins Project: mediawiki/skins/Splash….
gerritbot added a comment.Sep 26 2015, 10:26 PM

Change 241471 had a related patch set uploaded (by Paladox):
Remove non existing css file reference

https://gerrit.wikimedia.org/r/241471

gerritbot added a comment.Sep 26 2015, 10:29 PM

Change 241465 abandoned by Paladox:
empty php entry point, remove non existing css files

Reason:
Splitted the patches out to

https://gerrit.wikimedia.org/r/#/c/241471/

and

https://gerrit.wikimedia.org/r/#/c/241472/

https://gerrit.wikimedia.org/r/241465

hashar mentioned this in rSERUae16f0b5f227: Fix autoloader for EruditeTemplate.Sep 26 2015, 11:14 PM
matmarex added a subtask: T111446: ResourcesTest::testStyleMedia with data set #30 ('skins.bluesky', 'screen', 'skins/BlueSky/resources/css/nonarticle.css', stdClass): Stylesheets should not both specify "media" and contain @media.Nov 8 2015, 6:34 AM
matmarex added subscribers: matmarex, Isarra.
hashar removed a project: Continuous-Integration-Infrastructure.Mar 10 2016, 2:17 PM
hashar added a project: Continuous-Integration-Config.
hashar moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.
gerritbot added a comment.May 31 2016, 2:25 PM

Change 291925 had a related patch set uploaded (by Paladox):
Disable testStyleMedia test for skins only

https://gerrit.wikimedia.org/r/291925

gerritbot added a comment.May 31 2016, 11:32 PM

Change 291925 abandoned by Paladox:
Disable testStyleMedia test for skins only

https://gerrit.wikimedia.org/r/291925

Krinkle unsubscribed.Jun 2 2016, 9:57 PM
SamanthaNguyen moved this task from Backlog to Bugs on the BlueSky board.Aug 6 2016, 8:10 AM
gerritbot added a comment.Aug 10 2016, 4:38 PM

Change 241471 abandoned by Paladox:
Add missing css file

https://gerrit.wikimedia.org/r/241471

matmarex closed subtask T111446: ResourcesTest::testStyleMedia with data set #30 ('skins.bluesky', 'screen', 'skins/BlueSky/resources/css/nonarticle.css', stdClass): Stylesheets should not both specify "media" and contain @media as Resolved.Oct 14 2016, 12:25 PM
gerritbot added a comment.Nov 23 2016, 3:21 PM

Change 323161 had a related patch set uploaded (by Hashar):
Run MediaWiki 'skins' testsuite on all skins

https://gerrit.wikimedia.org/r/323161

hashar added a comment.Nov 23 2016, 3:23 PM

T68926 will get us a Jenkins job that runs the MediaWiki structure tests. Applies it on every skins we have configured in CI has non voting job.

gerritbot added a comment.Nov 23 2016, 3:39 PM

Change 323161 merged by jenkins-bot:
Run MediaWiki 'skins' testsuite on all skins

https://gerrit.wikimedia.org/r/323161

gerritbot added a comment.Nov 23 2016, 9:09 PM

Change 323247 had a related patch set uploaded (by Hashar):
Make skin tests to vote when they are passing

https://gerrit.wikimedia.org/r/323247

hashar updated the task description. (Show Details)Nov 23 2016, 9:11 PM
hashar set Security to None.
gerritbot added a comment.Nov 23 2016, 9:13 PM

Change 323247 merged by jenkins-bot:
Make skin tests to vote when they are passing

https://gerrit.wikimedia.org/r/323247

hashar mentioned this in T68926: Set up phpunit structure tests for MediaWiki skin repositories.Nov 23 2016, 9:16 PM
gerritbot added a comment.Nov 23 2016, 11:06 PM

Change 323329 had a related patch set uploaded (by Paladox):
Move variables from ResourceLoaderLESSVars to variables.less

https://gerrit.wikimedia.org/r/323329

gerritbot added a comment.Nov 23 2016, 11:22 PM

Change 323329 abandoned by Paladox:
Move variables from ResourceLoaderLESSVars to variables.less

https://gerrit.wikimedia.org/r/323329

gerritbot added a comment.Nov 23 2016, 11:24 PM

Change 323334 had a related patch set uploaded (by Paladox):
Fix mw skin unit tests

https://gerrit.wikimedia.org/r/323334

gerritbot added a comment.Nov 25 2016, 12:34 AM

Change 323334 abandoned by Paladox:
Fix mw skin unit tests

https://gerrit.wikimedia.org/r/323334

Paladox added a parent task: T151593: Add support for skin and extension dependencies in new skin unit test.Nov 25 2016, 12:47 AM
hashar added a comment.Dec 13 2016, 10:17 AM

CI now supports injecting skins as dependencies to an extension or extension as a dependency to a skin (was T151593). That will help fix a few cases. The first I have fixed is the skin BlueSpiceSkin which depends on the extension BlueSpiceFoundation, it is now passing just fine '\O.O/'.

hashar edited projects, added good first task; removed BlueSky, Patch-For-Review.Dec 14 2016, 9:15 PM
hashar updated the task description. (Show Details)
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 14 2016, 9:15 PM
gerritbot added a comment.Dec 15 2016, 4:29 PM

Change 327535 had a related patch set uploaded (by Hashar):
Add SynagonismTemplate class to the autoloader

https://gerrit.wikimedia.org/r/327535

gerritbot added a project: Patch-For-Review.Dec 15 2016, 4:29 PM
hashar updated the task description. (Show Details)Dec 15 2016, 4:33 PM
gerritbot added a comment.Dec 16 2016, 7:50 AM

Change 327535 merged by jenkins-bot:
Add SynagonismTemplate class to the autoloader

https://gerrit.wikimedia.org/r/327535

hashar closed this task as Resolved.Apr 21 2017, 12:34 PM

That is mostly fixed. We have the structure tests running on most of the skins we care about.

hashar mentioned this in rSEXAMPLE0138be56d3ec: Final NoteDb migration updates.Jun 9 2018, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits