Page MenuHomePhabricator

[Task] Deprecate and remove Holder interfaces
Closed, ResolvedPublic

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
DuplicateNone
InvalidNone
InvalidNone
InvalidLydia_Pintscher
Resolveddaniel
ResolvedTobi_WMDE_SW
Resolvedthiemowmde
OpenNone
OpenNone
StalledNone
OpenNone
OpenNone
Resolvedthiemowmde
OpenNone
Resolvedthiemowmde
Resolvedthiemowmde
ResolvedBene
ResolvedBene
ResolvedNone

Event Timeline

Bene created this task.Feb 29 2016, 10:47 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 29 2016, 10:47 AM

Change 273933 had a related patch set uploaded (by Bene):
Don't call setters when not necessary

https://gerrit.wikimedia.org/r/273933

Change 273933 merged by jenkins-bot:
Don't call setters when not necessary

https://gerrit.wikimedia.org/r/273933

thiemowmde closed this task as Resolved.Mar 18 2016, 8:47 AM

https://github.com/wmde/WikibaseDataModel/pull/656 changed the …Provider interfaces to give the guarantee they return a reference to the original DataModel object. This was key to resolve this ticket. Actually removing the …Holder interfaces is totally optional now.