Page MenuHomePhabricator
Create Task
Maniphest T128362

[Task] Deprecate and remove Holder interfaces
Closed, ResolvedPublic
Actions

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+28 -42Don't call setters when not necessary
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidNoneT73781 Add support for a "Multi-Part" content model for use with MediaInfo / structured meta-data
 InvalidNoneT76006 code cleanup and refactoring of the mediawiki file page to be able to store structured data in it
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 ResolveddanielT134473 Create MediaInfo / Linking multimedia files to their mediainfo entity (second prototype)
 ResolvedTobi_WMDE_SWT125822 [Epic] Basic first prototype for structured data support for Commons
 ResolvedthiemowmdeT132442 [Task] Introduce differ for MediaInfo
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolvedthiemowmdeT78298 [Task] Split Diff/Patching code to allow constructing other Differs/Patchers
 ResolvedthiemowmdeT128468 [Task] Release DataModel 6.0
 ResolvedBeneT128378 Release DataModel 5.1
 ResolvedBeneT128362 [Task] Deprecate and remove Holder interfaces
 ResolvedNoneT126152 [RFC] Design of provider/holder interfaces in Wikibase's data model

Event Timeline

Bene created this task.Feb 29 2016, 10:47 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 29 2016, 10:47 AM
Bene added a subtask: T126152: [RFC] Design of provider/holder interfaces in Wikibase's data model.Feb 29 2016, 10:47 AM
Bene moved this task from incoming to consider for next sprint on the Wikidata board.
Bene added a parent task: T128378: Release DataModel 5.1.Feb 29 2016, 3:04 PM
Bene added a comment.Feb 29 2016, 3:27 PM

Patch on Github: https://github.com/wmde/WikibaseDataModel/pull/648

gerritbot added a subscriber: gerritbot.Feb 29 2016, 5:01 PM

Change 273933 had a related patch set uploaded (by Bene):
Don't call setters when not necessary

https://gerrit.wikimedia.org/r/273933

gerritbot added a project: Patch-For-Review.Feb 29 2016, 5:01 PM
Bene added projects: Wikibase-DataModel-Release-6.0.0, Wikidata-Sprint-2016-03-01.Mar 2 2016, 11:23 AM
Bene moved this task from Proposed to Review on the Wikidata-Sprint-2016-03-01 board.
Bene added a parent task: T128468: [Task] Release DataModel 6.0.
thiemowmde added a subscriber: thiemowmde.Mar 4 2016, 11:38 AM

Please review https://github.com/wmde/WikibaseDataModel/pull/651.

gerritbot added a comment.Mar 4 2016, 11:42 AM

Change 273933 merged by jenkins-bot:
Don't call setters when not necessary

https://gerrit.wikimedia.org/r/273933

thiemowmde closed this task as Resolved.Mar 18 2016, 8:47 AM

https://github.com/wmde/WikibaseDataModel/pull/656 changed the …Provider interfaces to give the guarantee they return a reference to the original DataModel object. This was key to resolve this ticket. Actually removing the …Holder interfaces is totally optional now.

thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2016-03-01 board.Mar 18 2016, 8:47 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL