Page MenuHomePhabricator
Create Task
Maniphest T78298

[Task] Split Diff/Patching code to allow constructing other Differs/Patchers
Closed, ResolvedPublic
Actions

Description

"EntityDiff makes assumptions that all entities have aliases, labels, descriptions and claims. It is generally not well designed. claim is used as key for statements.

Creating a well designed alternative from ground up might be the way to go."

https://github.com/wmde/WikibaseDataModel/issues/209

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidNoneT73781 Add support for a "Multi-Part" content model for use with MediaInfo / structured meta-data
 InvalidNoneT76006 code cleanup and refactoring of the mediawiki file page to be able to store structured data in it
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 ResolveddanielT134473 Create MediaInfo / Linking multimedia files to their mediainfo entity (second prototype)
 ResolvedTobi_WMDE_SWT125822 [Epic] Basic first prototype for structured data support for Commons
 ResolvedthiemowmdeT132442 [Task] Introduce differ for MediaInfo
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolvedthiemowmdeT78298 [Task] Split Diff/Patching code to allow constructing other Differs/Patchers
 ResolvedJeroenDeDauwT45326 Cleanup EntityDiff
 ResolvedthiemowmdeT128468 [Task] Release DataModel 6.0
 ResolvedBeneT128362 [Task] Deprecate and remove Holder interfaces
 ResolvedNoneT126152 [RFC] Design of provider/holder interfaces in Wikibase's data model
 ResolvedBeneT78287 [Task] Remove deprecated Entity
 DeclinedBeneT78291 [Task] Remove deprecated term methods from Entity

Event Timeline

Lucie created this task.Dec 11 2014, 3:23 PM
Lucie raised the priority of this task from to Needs Triage.
Lucie updated the task description. (Show Details)
Lucie added projects: Wikibase-DataModel, Wikidata.
Lucie changed Security from none to None.
Lucie subscribed.
JeroenDeDauw subscribed.Jun 21 2015, 10:17 PM

Heh... https://phabricator.wikimedia.org/T45326

Ricordisamoa subscribed.Aug 23 2015, 4:54 PM
thiemowmde renamed this task from Clean up EntityDiff and ItemDiff to [Task] Clean up EntityDiff and ItemDiff.Sep 10 2015, 4:35 PM
thiemowmde triaged this task as Medium priority.
thiemowmde added a subtask: T45326: Cleanup EntityDiff.
thiemowmde added a parent task: T75496: [Epic] Support new types of Entities in Wikibase Repository.
thiemowmde added subscribers: Bene, thiemowmde.
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.Sep 10 2015, 9:54 PM
Bene raised the priority of this task from Medium to High.Feb 29 2016, 4:32 PM
Bene moved this task from ready to go to consider for next sprint on the Wikidata board.

There are also some more issues, for example should patchers not act on an array level but directly on the objects.

Bene renamed this task from [Task] Clean up EntityDiff and ItemDiff to [Task] Clean up Diff and Patching code.Feb 29 2016, 4:33 PM
Bene edited projects, added Wikibase-DataModel-Services; removed Wikibase-DataModel.
Lydia_Pintscher added a project: Wikidata-Sprint-2016-03-01.Mar 1 2016, 2:16 PM
Lydia_Pintscher moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-03-01 board.
daniel added a subtask: T128468: [Task] Release DataModel 6.0.Mar 3 2016, 2:30 PM
thiemowmde claimed this task.Mar 4 2016, 4:49 PM
thiemowmde moved this task from Backlog to Doing on the Wikidata-Sprint-2016-03-01 board.
thiemowmde added a comment.Mar 4 2016, 4:52 PM

This first patch should make it more obvious what this ticket is about: https://github.com/wmde/WikibaseDataModelServices/pull/120. Still work in progress at the moment.

Bene closed subtask T128468: [Task] Release DataModel 6.0 as Resolved.Mar 14 2016, 9:48 PM
thiemowmde moved this task from Doing to Done on the Wikidata-Sprint-2016-03-01 board.Mar 18 2016, 8:48 AM
thiemowmde added a project: Patch-For-Review.EditedMar 18 2016, 8:50 AM

Patches that do nothing but adding tests. Can you merge these first, please?

With these tests in place, the actual refactoring is done in these patches (in suggested review order):

Optional:

  • https://github.com/wmde/Diff/pull/65 is an optional enhancement that would make the code introduced in patch #120 quite a bit cleaner. But #120 should be reviewed and merged without waiting for this dependency.
thiemowmde moved this task from Done to Review on the Wikidata-Sprint-2016-03-01 board.Mar 18 2016, 8:50 AM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-04-12.Apr 12 2016, 11:26 AM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-04-12 board.Apr 12 2016, 11:26 AM
thiemowmde renamed this task from [Task] Clean up Diff and Patching code to [Task] Split Diff/Patching code to allow constructing other Differs/Patchers.Apr 12 2016, 12:54 PM
Tobi_WMDE_SW added a parent task: T132442: [Task] Introduce differ for MediaInfo.Apr 12 2016, 12:54 PM
thiemowmde added a comment.Apr 15 2016, 8:54 AM

I rearranged my comment T78298#2133392 to make this as easy as I can for reviewers.

aude mentioned this in T125822: [Epic] Basic first prototype for structured data support for Commons.Apr 18 2016, 6:47 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-04-26.Apr 26 2016, 11:58 AM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-04-26 board.Apr 26 2016, 11:58 AM
• adrianheine subscribed.Apr 28 2016, 12:58 PM

Only https://github.com/wmde/WikibaseDataModelServices/pull/125 and https://github.com/wmde/Diff/pull/65 are open, the former needs a manual rebase.

• adrianheine added a comment.May 9 2016, 10:40 AM

Only the optional patch is left open, so I guess we can do a WBDMS release and be done :)

thiemowmde added a comment.EditedMay 9 2016, 3:14 PM

Sorry, but https://github.com/wmde/WikibaseDataModelServices/pull/135 introduced bad regressions. See https://github.com/wmde/WikibaseDataModelServices/milestones/3.6.0.

Required for a 3.6 release:

Optional:

Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-05-10.May 10 2016, 11:51 AM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-10 board.May 10 2016, 11:51 AM
• adrianheine added a comment.May 17 2016, 7:57 AM

All except the Diff change are merged.

• adrianheine moved this task from Review to Doing on the Wikidata-Sprint-2016-05-10 board.May 17 2016, 7:58 AM
• adrianheine closed this task as Resolved.May 17 2016, 6:20 PM
• adrianheine moved this task from Doing to Done on the Wikidata-Sprint-2016-05-10 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits