Page MenuHomePhabricator
Create Task
Maniphest T134259

[Task] Create mediainfo entity on demand when saving the first time after editing labels, descriptions and aliases
Closed, ResolvedPublic
Actions

Description

This ticket is about creating a mediainfo entity on demand when hitting save the first time after adding labels, descriptions and/or aliases. A related task is T140760 to create a mediainfo entity on demand when adding a statement the first time.

Details

SubjectRepoBranchLines +/-
Allow entities to be created from more API modules.mediawiki/extensions/Wikibasemaster+90 -73
Fixups to auto-creation of entities with custom idsmediawiki/extensions/Wikibasemaster+50 -50
Allow auto-creation of entities with custom ids.mediawiki/extensions/Wikibasemaster+350 -44
Allow auto-creation of MediaInfo entities.mediawiki/extensions/WikibaseMediaInfomaster+65 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tobi_WMDE_SW created this task.May 3 2016, 1:46 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 3 2016, 1:46 PM
Tobi_WMDE_SW added a project: WikibaseMediaInfo.May 3 2016, 2:11 PM
thiemowmde added a subtask: T134258: [Task] Show empty mediainfo for mediainfo ids that correspond to existing file-pages.May 3 2016, 2:24 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-05-10.May 3 2016, 2:27 PM
Lydia_Pintscher added a parent task: T134473: Create MediaInfo / Linking multimedia files to their mediainfo entity (second prototype).May 5 2016, 7:23 AM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.May 19 2016, 12:40 PM
Lydia_Pintscher triaged this task as High priority.May 19 2016, 12:51 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-05-24.May 23 2016, 1:18 PM
daniel subscribed.Jun 8 2016, 10:25 AM

There are several places where the "on the fly" creation could be handled:

  1. in the client side JS code. It would know when an entity needs to be created with an extra call to wbeditentity before saving an edit.
  2. in the API module (more precisely, the ModifyEntity base class).
  3. in the EditEntity interactor.
  4. in the EntityStore.
  5. in the EntityRevisionLookup, on read, if in a POST request.

I personally tend towards doing this in the API, but there are good arguments for the other places, too. In particular, it's still unclear to me where we should maintain the knowledge about which entity types can be created on the fly, and which can't.

We should further consider whether we want to treat a MediaInfo entity as "existing" (in the context of EntityLookup, Special:EntityData, wbgetentities API calls, etc), when the corresponding File page exists, but no page was yet created for the MediaInfo entity.

daniel claimed this task.Jun 8 2016, 10:37 AM
daniel moved this task from Proposed to Doing on the Wikidata-Sprint-2016-05-10 board.
daniel moved this task from Doing to Proposed on the Wikidata-Sprint-2016-05-10 board.
daniel moved this task from Proposed to Doing on the Wikidata-Sprint-2016-05-24 board.
gerritbot subscribed.Jun 8 2016, 5:18 PM

Change 293339 had a related patch set uploaded (by Daniel Kinzler):
[WIP] Allow auto-creation of entities with custom ids.

https://gerrit.wikimedia.org/r/293339

gerritbot added a project: Patch-For-Review.Jun 8 2016, 5:18 PM
gerritbot added a comment.Jun 14 2016, 4:23 PM

Change 294350 had a related patch set uploaded (by Daniel Kinzler):
Allow auto-creation of MediaInfo entities.

https://gerrit.wikimedia.org/r/294350

daniel mentioned this in rEWBI47dc8fe53f5b: Allow auto-creation of MediaInfo entities..Jun 14 2016, 4:25 PM
gerritbot added a comment.Jun 14 2016, 7:31 PM

Change 294365 had a related patch set uploaded (by Daniel Kinzler):
Allow entities to be created from all API modules.

https://gerrit.wikimedia.org/r/294365

• Jonas closed subtask T134258: [Task] Show empty mediainfo for mediainfo ids that correspond to existing file-pages as Resolved.Jun 16 2016, 4:00 PM
JeroenDeDauw mentioned this in rEWBI3d5dd9c3d36d: Allow auto-creation of MediaInfo entities..Jun 17 2016, 7:00 AM
daniel mentioned this in rEWBI9f783d78cbb4: Allow auto-creation of MediaInfo entities..Jun 20 2016, 11:29 AM
daniel mentioned this in rEWBIb51ca6afe02b: Allow auto-creation of MediaInfo entities..Jun 20 2016, 1:26 PM
gerritbot added a comment.Jun 29 2016, 4:17 PM

Change 296602 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fixups to auto-creation of entities with custom ids

https://gerrit.wikimedia.org/r/296602

daniel mentioned this in rEWBI2a16d53186f0: Allow auto-creation of MediaInfo entities..Jul 3 2016, 11:40 AM
Tobi_WMDE_SW moved this task from Doing to Review on the Wikidata-Sprint-2016-05-24 board.Jul 5 2016, 12:47 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-07-05.Jul 5 2016, 12:51 PM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-07-05 board.Jul 5 2016, 12:53 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-07-19.Jul 19 2016, 1:15 PM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-07-19 board.
Tobi_WMDE_SW renamed this task from [Task] Create mediainfo entity on demand when saving the first time to [Task] Create mediainfo entity on demand when saving the first time after editing labels, descriptions and aliases.Jul 19 2016, 2:16 PM
Tobi_WMDE_SW removed daniel as the assignee of this task.
Tobi_WMDE_SW assigned this task to daniel.
Tobi_WMDE_SW updated the task description. (Show Details)
Tobi_WMDE_SW mentioned this in T140760: [Task] Create mediainfo entity on demand when adding a statement the first time.
Tobi_WMDE_SW updated the task description. (Show Details)
gerritbot added a comment.Jul 19 2016, 4:24 PM

Change 294350 merged by jenkins-bot:
Allow auto-creation of MediaInfo entities.

https://gerrit.wikimedia.org/r/294350

daniel added a subscriber: adrianheine.Jul 19 2016, 4:37 PM

On Ia5f075eb3f1b, @adrianheine briedfly documented a discussion we had:

We had a discussion. Proposal is to have a getEntityForCreation or getEntityForEditing method on EntityStore
that takes the new parameter, id parameter and for properties the dataType part of the POST body.

I agree that this would be cleaner than my original proposal. Since the original patch got merged now, I decided to copy this here as a todo, so it doesn't get lost.

• Jonas subscribed.Jul 20 2016, 6:36 AM

One left to go:
https://gerrit.wikimedia.org/r/#/c/294365/

Tobi_WMDE_SW added a comment.Jul 20 2016, 1:07 PM

@Jonas the patch you're pointing to is already the next step - see T140760. I've just updated the commit message.
I think everything related to this task has been done now, right?

• Jonas closed this task as Resolved.Jul 20 2016, 1:12 PM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-07-19 board.
• Jonas reopened this task as Open.Jul 20 2016, 2:57 PM
• Jonas moved this task from Done to Review on the Wikidata-Sprint-2016-07-19 board.
gerritbot added a comment.Jul 20 2016, 2:57 PM

Change 294365 had a related patch set uploaded (by Jonas Kress (WMDE)):
Allow entities to be created from more API modules.

https://gerrit.wikimedia.org/r/294365

gerritbot added a comment.Jul 20 2016, 3:01 PM

Change 293339 merged by jenkins-bot:
Allow auto-creation of entities with custom ids.

https://gerrit.wikimedia.org/r/293339

• Jonas added a subscriber: thiemowmde.Jul 20 2016, 3:01 PM

OK we still need this to be merge.
@thiemowmde could you please have a look?

https://gerrit.wikimedia.org/r/#/c/294365/

gerritbot added a comment.Jul 20 2016, 3:09 PM

Change 294365 had a related patch set uploaded (by Jonas Kress (WMDE)):
Allow entities to be created from more API modules.

https://gerrit.wikimedia.org/r/294365

gerritbot added a comment.Jul 20 2016, 3:12 PM

Change 296602 merged by jenkins-bot:
Fixups to auto-creation of entities with custom ids

https://gerrit.wikimedia.org/r/296602

gerritbot added a comment.Jul 22 2016, 1:15 PM

Change 294365 merged by jenkins-bot:
Allow entities to be created from more API modules.

https://gerrit.wikimedia.org/r/294365

• Jonas closed this task as Resolved.Jul 27 2016, 9:05 AM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-07-19 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL