We should move the transcoding of Midi to Vorbis from Score to TMH, so that we can use it for uploaded midi files and reuse it from the Score extension.
|Open||None||T44725 Multimedia file format support (tracking)|
|Resolved||Ebe123||T20852 Support inline player for MIDI files|
|Open||None||T136360 Support MOD format in TimedMediaHandler|
|Open||Ebe123||T135597 Move MIDI to audio conversion from Score into TimedMediaHandler|
|Open||None||T181958 TimedMediaHandler should handle OGG/Vorbis length efficiently|
|Resolved||Reedy||T226713 Run cleanupTranscodes.php for current midi files|
|Resolved||TheDJ||T226784 Refresh metadata on very old midi uploads using the audio/mid mime type|
- Mentioned In
- T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object
T20852: Support inline player for MIDI files
T209695: Playback for musical notation files hosted on Wikimedia Commons
T181897: Migrate TiMidity++ to fluidsynth
T181875: Score should output MP3 files
- Mentioned Here
- T226713: Run cleanupTranscodes.php for current midi files
T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object
T50029: crackling at start of OGG renditions of MIDI files (fixed in TiMidity++ 2.14.0)
@Stemby: Welcome to Phabricator and thanks for registering an account. Please note that "I think Blue looks better than Red" comments (especially without any evaluation criteria provided) are off-topic here. This task is about moving TiMidity conversion from the Score extension to the TimedMediaHandler extension. Thanks for keeping this task focused.
OK, sorry to bother you. Read my previous message as «please note that your work risks being lost time, because IMHO timidity should be replaced by fluidsynth». So the right task should be «remove timidity from Score and make MIDI to Vorbis "conversion" in TimedMediaHandler by using fluidsynth».
Also, this means MIDI files no longer need the score extension to work, right? So something like the text below?
MIDI files can soon be played without the Score extension. You can then add them with [[File:Filename.midi]]. override_midi and override_audio will no longer work. Instead you need to add the MIDI file below the music score.
You are correct. However, removing the override_midi and override_audio from MediaWiki-extensions-Score would come later (with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/511123), to give some time for deprecation.
@Ebe123 OK! When you're ready, feel free to go to https://phabricator.wikimedia.org/tag/user-notice/ and drag this ticket from "Not ready to announce" to "Announce in next Tech/News" and ping me here, and we'll make sure the communities get to know what's happening. (:
Great stuff @Ebe123 !
I'm going to leave this out of Tech News this week, because there's no deployment train next week, so the new features won't be available until the week of 17 June. That way when it is announced in Tech News, the feature will be only 3 days from release instead of 10 days away. :-)
So next step here is to figure out how we can make Score use the Transcode pipeline.
Basic idea was to use a separate FileRepo implementation to expose Score entires. Small problem there seems to be that the entire Transcode implementation assumes LocalFile in the implementation. I was supposed to look into this a bit more for @Ebe123 last week, but forgot. Will be good if we can document the design here, because i'm not available enough to keep track of stuff in my mind.
I don't see how separating a new FileRepo implementation could help, as FileRepo is already for interacting with filesystem files with or without database entries.
I was thinking about adding a new field transcode_image_repo to the transcode table with the repo's name which would allow the file to be found using a simple FileRepo in Score. With that, TMH can find and use the transcodes. Thoughts?