Page MenuHomePhabricator
Create Task
Maniphest T142055

Add query.wikidata.org to shortening URL list for UrlShortener
Closed, ResolvedPublic
Actions

Description

Currently, UrlShortener config allows to use URLs based on wikidata.org but not query.wikidata.org. It would be very useful if we could also shorten query URLs, this requires adding query.wikidata.org to whitelisted domains for UrlShortener.

Also, test.wikidata.org is not allowed even on labs, may make sense to add that too for testing purposes. Maybe even *.wikidata.org?

Details

SubjectRepoBranchLines +/-
UrlShortener: Whitelist *.wikidata.orgoperations/mediawiki-configmaster+4 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLadsgroupT44085 Wikimedia needs a URL shortener (tracking)
 ResolvedBBlackT44270 Wikimedia needs a short domain name for URL shortening
 ResolvedSmalyshevT112715 Enable different URL shorteners for WDQS
 ResolvedLadsgroupT108557 Review and deploy UrlShortener extension to Wikimedia wikis
 ResolvedmatmarexT107550 autofocus on Special:UrlShortener broken
 ResolvedmatmarexT106313 Infusion breaks browser autofocus
 ResolvedLegoktmT108558 UrlShortener: Allow short codes to be in the root of the short domain
 ResolvedmatmarexT108600 UrlShortener URL input field truncates text
 DuplicateNoneT108603 Valid URL not validating
 ResolvedoriT108604 UrlShortener extension accepts arbitrary port numbers and credentials
 ResolvedBBlackT108649 Set up "w.wiki" domain for usage with UrlShortener
 ResolvedBBlackT91612 acquire SSL certificate for w.wiki
Unknown Object (Task)
Unknown Object (Task)
 Resolved• dpatrickT112950 Security review for UrlShortener extension
 Resolved• PrtksxnaT112680 UrlShortener should not load all of oojs-ui on all pages
 ResolvedLegoktmT116444 Set up UrlShortener extension on the beta cluster
 ResolvedLegoktmT116512 Special:UrlRedirector error message doesn't display properly due to relative paths/url rewrites
 ResolvedArielGlennT116986 Set up UrlShortener dumps
 ResolvedJoeT133485 Configure apache rules for UrlShortener
 ResolvedBBlackT141170 Strip query parameters from w.wiki domain
 ResolvedSmalyshevT142055 Add query.wikidata.org to shortening URL list for UrlShortener
 ResolvedLadsgroupT133109 Add basic abuse prevention to UrlShortener
 ResolvedMarosteguiT218397 Add usc_deleted to urlshortcodes
 ResolvedLegoktmT187052 UrlShortener: Code stewardship review.
 Resolved• PrtksxnaT191592 Design review for UrlShortener
 ResolvedLadsgroupT219777 DBA review of UrlShortener
 DeclinedNoneT220432 Clean up "easter egg" short URLs before extension goes live

Event Timeline

Smalyshev created this task.Aug 3 2016, 11:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2016, 11:17 PM
Smalyshev triaged this task as Medium priority.Aug 3 2016, 11:17 PM
Smalyshev added a parent task: T108557: Review and deploy UrlShortener extension to Wikimedia wikis.
Smalyshev added a parent task: T112715: Enable different URL shorteners for WDQS.
greg added a project: MediaWiki-extensions-UrlShortener.Aug 3 2016, 11:22 PM
Legoktm subscribed.Aug 3 2016, 11:35 PM

Hm, this seems like an oversight. We should be whitelisting *.wikidata.org, I'm not sure why it's not a wildcard...

gerritbot subscribed.Aug 3 2016, 11:42 PM

Change 302851 had a related patch set uploaded (by Legoktm):
UrlShortener: Whitelist *.wikidata.org

https://gerrit.wikimedia.org/r/302851

Legoktm added a comment.Aug 3 2016, 11:44 PM

git blame points to me...no idea what I was thinking!

gerritbot added a comment.Aug 11 2016, 11:26 PM

Change 302851 merged by jenkins-bot:
UrlShortener: Whitelist *.wikidata.org

https://gerrit.wikimedia.org/r/302851

Dereckson subscribed.EditedAug 11 2016, 11:35 PM

This change will also allow to work with www.wikidata.org and not only https://wikidata.org

Stashbot subscribed.Aug 11 2016, 11:37 PM

Mentioned in SAL [2016-08-11T23:37:41Z] <dereckson@tin> Synchronized wmf-config/CommonSettings.php: UrlShortener: Whitelist *.wikidata.org (T142055) (duration: 00m 47s)

Smalyshev added a comment.Aug 11 2016, 11:59 PM

@Dereckson That's the point - all *.wikidata.org should be allowed.

Smalyshev closed this task as Resolved.Aug 12 2016, 5:54 AM
Smalyshev claimed this task.
Aklapper removed a subscriber: MediaWiki-extensions-UrlShortener.May 16 2023, 11:39 AM
Aklapper removed a subscriber: Wikimedia-Extension-setup.May 16 2023, 12:51 PM
Aklapper removed a subscriber: Wikidata-Query-Service.May 24 2023, 1:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits