Add repository name to TermIndexEntry
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	WMDE-leszek
	Nov 21 2016, 4:11 PM

Description

A constructor of TermIndexEntry should allow to specify repository name, and there should be getter/setter for the repository name. Value of the field will not be stored in the database.

Having this field added would allow to use foreign entities in search.

This would involve extending ItemId::newFromNumber and PropertyId::newFromNumber to also accept repository name as a parameter (empty/null by default).

Details

	Subject	Repo	Branch	Lines +/-
	Add repository parameter to entity-id-composer callbacks	mediawiki/extensions/Wikibase	master	+66 -37
	Add repository name to TermIndexEntry	mediawiki/extensions/Wikibase	master	+124 -6

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open		None	T109579 [Epic] Give more sister projects access to Wikidata
Open		None	T187900 There is no way to reference a specific quote on Wikiquote
Stalled		None	T71753 [Story] Wikibase / Wikidata support on Wikiquote
Resolved		Lydia_Pintscher	T146637 Wikidata 2016 Q4 goals
Resolved		Lydia_Pintscher	T150179 Wikidata 2017 Q1 goals
Resolved		Lydia_Pintscher	T76007 [Epic] add ability to link/refer to foreign items and properties (federation)
Resolved		Lydia_Pintscher	T149580 Allow access to entity data stored on "foreign" repositories (federation)
Resolved		WMDE-leszek	T150848 Create a dispatching version of TermSearchInteractor
Resolved		WMDE-leszek	T151053 Create repo-aware TermSqlIndex
Declined		WMDE-leszek	T151210 Add repository name to TermIndexEntry
Resolved		WMDE-leszek	T151212 Make TermIndexEntry's constructor expect the instance of EntityId as an enity id, not the number

Event Timeline

WMDE-leszek created this task.Nov 21 2016, 4:11 PM

WMDE-leszek updated the task description. (Show Details)Nov 21 2016, 4:23 PM

WMDE-leszek claimed this task.Nov 21 2016, 5:09 PM

WMDE-leszek moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.

Change 322704 had a related patch set uploaded (by WMDE-leszek):
Add repository name to TermIndexEntry

https://gerrit.wikimedia.org/r/322704

gerritbot added a project: Patch-For-Review.Nov 21 2016, 5:30 PM

WMDE-leszek moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Nov 22 2016, 11:52 AM

Change 323141 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[DNM] Add repository parameter to entity-id-composer callbacks

https://gerrit.wikimedia.org/r/323141

daniel added a subtask: T151212: Make TermIndexEntry's constructor expect the instance of EntityId as an enity id, not the number.Nov 24 2016, 6:03 PM

thiemowmde closed subtask T151212: Make TermIndexEntry's constructor expect the instance of EntityId as an enity id, not the number as Resolved.Nov 25 2016, 3:39 PM

Given the change described in T151212 this task is not really valid any more. TermIndexEntry::getEntityId (still) returns the actual entity id instance (which can be asked for the repository name), and TermIndexEntry's constructor now expects the actual EntityId object (including relevant repository prefix!), not just a number. Based on this change it is now possible to create TermIndexEntry objects for foreign entity ids etc.
Convenience getter returning the repository name of the related EntityId object can still be added to TermIndexEntry if needed.

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Nov 28 2016, 8:24 AM

Change 322704 abandoned by WMDE-leszek:
Add repository name to TermIndexEntry

Reason:
I2819090b4759fa1281fcc570b9feb42122ae2442 makes this patch not needed