Global default 'hard' is invalid for field oresDamagingPref
Closed, ResolvedPublic

Description

Occurs on these URIs:

  • /wiki/Special:Preferences
  • /w/api.php

Stack trace:

#0 /srv/mediawiki/php-1.30.0-wmf.1/includes/Preferences.php(102): Preferences::loadPreferenceValues(User, DerivativeContext, array)
#1 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiOptions.php(81): Preferences::getPreferences(User, DerivativeContext)
#2 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiMain.php(1578): ApiOptions->execute()
#3 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiMain.php(545): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiMain.php(516): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.30.0-wmf.1/api.php(83): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)
#7 {main}
Restricted Application added a project: Scoring-platform-team. · View Herald TranscriptMay 11 2017, 7:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
mmodell triaged this task as High priority.
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptMay 11 2017, 9:36 AM
Trizek-WMF added a subscriber: Lea_Lacroix_WMDE.

I've had a look at some wikis (en.wp, pl.wp, pt.wp, fi.wp, he.wp) where ORES is deployed by default, and none of them are impacted. It seems to be a Wikidata specific issue.

Maybe because of Wikidata already has 1.30 whereas Wikipedias have still 1.29...

We're going to have a loop asap!

Maybe because of Wikidata already has 1.30 whereas Wikipedias have still 1.29...

I'm not sure: he.wp is on Wednesday's train and is not impacted.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMay 11 2017, 10:04 AM

I will look into this but I can't promise if I can get it working since the codebase has been changed a lot by the collab's team

I will look into this but I can't promise if I can get it working since the codebase has been changed a lot by the collab's team

Collaboration team developers will be online in a few of hours. I've warned them about this task.

Maybe a side effect: it is not possible to change the interface language on Wikidata anymore. Still possible on Commons. (Report)

Maybe a side effect: it is not possible to change the interface language on Wikidata anymore. Still possible on Commons. (Report)

I created a specific ticket T165030

wikidata1.30.0-wmf.1 Special:Preferences - [WRR0DgpAIDkAAB0GnxgAAABU] 2017-05-11 14:24:14: Fatal exception of type "MWException"

betalabs Special:Preferences -

[WRRz8gpEE4AAAG588yQAAAAA] /wiki/Special:Preferences MWException from line 150 of /srv/mediawiki/php-master/includes/Preferences.php: Global default 'hard' is invalid for field oresDamagingPref

Backtrace:

#0 /srv/mediawiki/php-master/includes/Preferences.php(102): Preferences::loadPreferenceValues(User, RequestContext, array)
#1 /srv/mediawiki/php-master/includes/Preferences.php(1319): Preferences::getPreferences(User, RequestContext)
#2 /srv/mediawiki/php-master/includes/specials/SpecialPreferences.php(84): Preferences::getFormObject(User, RequestContext)
#3 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(522): SpecialPreferences->execute(NULL)
#4 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(862): MediaWiki->performRequest()
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(523): MediaWiki->main()
#8 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): include(string)
#10 {main}
Catrope claimed this task.May 11 2017, 3:11 PM

Change 353311 had a related patch set uploaded (by Catrope; owner: Catrope):
[operations/mediawiki-config@master] Set oresDamagingPref default to values that actually exist

https://gerrit.wikimedia.org/r/353311

Well, I was working on it but I will happy to help and collaborate. What I've got so far is that hewiki is okay even though their configs is almost identical and both are on wmf-30.1

Well, I was working on it but I will happy to help and collaborate. What I've got so far is that hewiki is okay even though their configs is almost identical and both are on wmf-30.1

I think it's because Wikidata's default sensitivity is set to 'hard', but the corresponding damaging level ('maybebad') is set to false in the threshold settings. No other wiki had this problem except fawiki, which is in group2, and this only started mattering with rEORSc047cd54d69e: Align damaging thresholds to filters thresholds which is in wmf.1.

Okay, I get your patch deployed ASAP.

Change 353311 merged by jenkins-bot:
[operations/mediawiki-config@master] Set oresDamagingPref default to values that actually exist

https://gerrit.wikimedia.org/r/353311

Mentioned in SAL (#wikimedia-operations) [2017-05-11T15:35:10Z] <Amir1> starts of ladsgroup@tin:/srv/mediawiki-staging$ scap sync-dir wmf-config 'Set oresDamagingPref default to values that actually exist (T165011)'

Mentioned in SAL (#wikimedia-operations) [2017-05-11T15:35:38Z] <ladsgroup@tin> Synchronized wmf-config: Set oresDamagingPref default to values that actually exist (T165011) (duration: 00m 44s)

I deployed Roan's patch and everything seems fine. Feel free to reopen if you see it happen again.

Ladsgroup closed this task as Resolved.May 11 2017, 3:38 PM

Change 353344 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/mediawiki-config@master] Moving some ORES configs from InitialiseSettings to CommonSettings

https://gerrit.wikimedia.org/r/353344

This new config is causing a huge logspam of "Notice: Undefined variable: wmgOresDefaultSensitivityLevel in /srv/mediawiki/wmf-config/CommonSettings.php on line 33351" because I think CommonsSettings.php is being ran sooner than IniritalizeSettings.php

Change 353344 abandoned by Ladsgroup:
Moving some ORES configs from InitialiseSettings to CommonSettings

https://gerrit.wikimedia.org/r/353344