@ovasileva to review

Change 397568 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Definition list should be also moved with first paragraph

https://gerrit.wikimedia.org/r/397568

I found out that the move first paragraph logic will move leading paragraph with unordered/unordered lists but the definition list would stay not attached to the paragraph. I pushed a small patch to fix this behavior and move any type of list (ordered/unordered/definition) with the first paragraph.

Change 399562 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Treat mw-stack elements as if they are infoboxes

https://gerrit.wikimedia.org/r/399562

@pmiazga in a standup thread you mentioned

I had an idea to split MobileFormatter to many small "MobileFormatterSteps" and leave MobileFormatter as a manager that iterates over steps and applies one by one. Now everything is in one huge class that become very difficult to manage. I'll use my 10% time to work on it

Any progress there? I would be interested to split out the code into several parts that pass $doc by reference and allow better testability

e.g. filterContent would look like

public function filterContent(
		$removeDefaults = true, $removeReferences = false, $removeImages = false,
		$showFirstParagraphBeforeInfobox = false
	) {
		$ctx = MobileContext::singleton();
		$config = $ctx->getMFConfig();
		$doc = $this->getDoc();
               if ( $removeReferences ) {
                    new MobileReferenceFormatter( $doc );
               }
               if ( $showFirstParagraphBeforeInfobox ) {
                    new MobileLeadSectionFormatter( $doc );
               }
               return parent::filterContent();

Change 401776 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Hygiene: Begin refactoring of MobileFormatter mega class

https://gerrit.wikimedia.org/r/401776

Change 401776 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: Begin refactoring of MobileFormatter mega class

https://gerrit.wikimedia.org/r/401776

Change 399562 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Treat mw-stack elements as if they are infoboxes

https://gerrit.wikimedia.org/r/399562

Change 403161 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Hygiene: Improve infobox detection in MoveLeadParagraphTransform

https://gerrit.wikimedia.org/r/403161

@Jdlrobson - I am having some trouble getting the test URLs to work on Staging. They are bringing up pages with no text. Is there a way to copy the article source(s) from prod?

@ABorbaWMF are you using the mobile skin ? http://reading-web-staging.wmflabs.org/wiki/Christopher_II_of_Denmark?useformat=mobile (click mobile view at the bottom of the page if the link exists)

Change 403223 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@specialpages] Hygiene: Improve infobox detection in MoveLeadParagraphTransform

https://gerrit.wikimedia.org/r/403223

Change 403223 abandoned by Pmiazga:
Hygiene: Improve infobox detection in MoveLeadParagraphTransform

https://gerrit.wikimedia.org/r/403223

Change 403161 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: Improve infobox detection in MoveLeadParagraphTransform

https://gerrit.wikimedia.org/r/403161

@Jdlrobson, Yes that did the trick. Testing now. So far no problems on chrome. More results to come.

Looks good so far. There not much visual difference on phone type devices, but looks good on tablets

Production	Staging

Tested and looks good from my side, but @ABorbaWMF - just to double check, what did you mean by "there's not much visual difference on phone devices? The differences here that we're looking for are that the lead paragraph appears before the infobox on mobile devices on staging.

Sorry, it looks ok on mobile too.

Prod	Staging

Found T185040 :/

The template has been edited per my request on wiki

Remaining issues seem to be limited to inconsistently built pages eg.
https://en.wikipedia.org/w/index.php?title=MasterCard_Lola&type=revision&diff=821137852&oldid=810539463 and another template which I've flagged on wiki.
I'm seeing under 100 per hour, down from 440.

I'll keep an eye on the logs and see if this can be resolved on wiki... if not there's little we can do here other than feedback to community "inconsistent" pages which the logging is doing a great job of identifying.

Update: down to 13ish an hour:

Change 405812 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Other less common lead paragraph edge cases

https://gerrit.wikimedia.org/r/405812

Patch was merged but nothing from gerritbot. Weird.

Change 397568 abandoned by Jdlrobson:
Definition list should be also moved with first paragraph

Reason:
This work is now tracked in https://phabricator.wikimedia.org/T186136 given it needs a rebase anyway.

https://gerrit.wikimedia.org/r/397568

I've added this here to chores. I think it's important to keep an eye on this number as it gives us clues that editors have changed template markup: https://www.mediawiki.org/wiki/Reading/Web/Chore_list#Review_the_MobileFormatter_lead_paragraph_transform_on_Wikimedia_content