Page MenuHomePhabricator

All messages in CentralNotice are defaulted to English regardless of content language
Open, LowPublic

Description

Special:NoticeTemplate assumes that the content language is English (also see the comment in https://phabricator.wikimedia.org/diffusion/ECNO/browse/master/i18n/qqq.json;26b909775ec444639ca20959a18626d4443d4eb6$64 ), by:

  • having the “original” column in the translation list hardcoded as English (see MediaWiki:Centralnotice-english), and, more importantly by
  • creating the message key by comparing its language to 'en' (hardcoded!), not to the content language of the wiki, which means that on any wiki with a different content language, the English message text is fetched (or saved to when translating through this special page) from [[MediaWiki:Centralnotice-something-something]], and the text in the content language is fetched from [[MediaWiki:Centralnotice-something-something/lang]], which are both wrong.

See SpecialNoticeTemplate::showView()


Version: unspecified
Severity: minor

Details

Reference
bz16321

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:26 PM
bzimport set Reference to bz16321.
bzimport added a subscriber: Unknown Object (MLST).
Mormegil created this task.Nov 12 2008, 4:50 PM

Not a bad idea to remove some of the English centric settings in there. I'll see if there are any pitfalls in pulling that out.

bugs wrote:

This isn't just an issue when you need to use it with other languages, it's also difficult when you want an English specific text... For example: We want to link to http://wikimediafoundation.org/wiki/Support_Wikipedia2/en for the English pages, but we want to link to {{int:Centralnotice-2009 Notice1-donate-url}} for all the other languages.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2015, 7:34 AM
awight added a subscriber: awight.
Meno25 removed a subscriber: Meno25.Feb 22 2016, 6:03 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 29 2016, 7:40 AM
Aklapper updated the task description. (Show Details)Dec 15 2016, 6:50 PM
Aklapper removed a project: good first task.
Aklapper removed a subscriber: wikibugs-l-list.

See SpecialNoticeTemplate::showView()

That function got removed in https://phabricator.wikimedia.org/rECNO4ea6241aaed2a1d0d9b55f818996a386d0ad5250 .
Is this still an issue? If so, please feel free to update the task description and re-add the good first task tag.

kaldari removed a subscriber: kaldari.Dec 15 2016, 10:21 PM
Base added a subscriber: Base.Feb 19 2017, 1:47 PM
mmodell removed a subscriber: awight.Jun 22 2017, 9:39 PM