Page MenuHomePhabricator
Create Task
Maniphest T18321

All messages in CentralNotice are defaulted to English regardless of content language
Open, LowPublic
Actions

Description

Special:NoticeTemplate assumes that the content language is English (also see the comment in https://phabricator.wikimedia.org/diffusion/ECNO/browse/master/i18n/qqq.json;26b909775ec444639ca20959a18626d4443d4eb6$64 ), by:

  • having the “original” column in the translation list hardcoded as English (see MediaWiki:Centralnotice-english), and, more importantly by
  • creating the message key by comparing its language to 'en' (hardcoded!), not to the content language of the wiki, which means that on any wiki with a different content language, the English message text is fetched (or saved to when translating through this special page) from [[MediaWiki:Centralnotice-something-something]], and the text in the content language is fetched from [[MediaWiki:Centralnotice-something-something/lang]], which are both wrong.

See SpecialNoticeTemplate::showView()

Version: unspecified
Severity: minor

Details

Reference
bz16321

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:26 PM
• bzimport added projects: MediaWiki-extensions-CentralNotice, I18n.
• bzimport set Reference to bz16321.
• bzimport added a subscriber: Unknown Object (MLST).
Mormegil created this task.Nov 12 2008, 4:50 PM
• Tfinc added a comment.Dec 15 2008, 11:37 PM

Not a bad idea to remove some of the English centric settings in there. I'll see if there are any pitfalls in pulling that out.

• bzimport added a comment.Nov 10 2009, 12:27 AM

bugs wrote:

This isn't just an issue when you need to use it with other languages, it's also difficult when you want an English specific text... For example: We want to link to http://wikimediafoundation.org/wiki/Support_Wikipedia2/en for the English pages, but we want to link to {{int:Centralnotice-2009 Notice1-donate-url}} for all the other languages.

• Awjrichards unsubscribed.Dec 3 2014, 5:44 PM
• atgo moved this task from Backlog to Later on the MediaWiki-extensions-CentralNotice board.Feb 27 2015, 1:32 AM
awight awarded a token.Oct 21 2015, 7:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2015, 7:34 AM
awight added a project: good first task.Oct 21 2015, 7:34 AM
awight subscribed.
awight added a parent task: T38591: Use the Translate extension in CentralNotice (tracking).Oct 21 2015, 8:27 AM
awight added a subtask: T116235: [Epic] CentralNotice translation should move closer to MediaWiki i18n standards and the code cleaned up.Nov 13 2015, 6:02 PM
Meno25 unsubscribed.Feb 22 2016, 6:03 PM
Liuxinyu970226 subscribed.Oct 29 2016, 7:40 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 29 2016, 7:40 AM
Aklapper updated the task description. (Show Details)Dec 15 2016, 6:50 PM
Aklapper removed a project: good first task.
Aklapper removed a subscriber: • wikibugs-l-list.

See SpecialNoticeTemplate::showView()

That function got removed in https://phabricator.wikimedia.org/rECNO4ea6241aaed2a1d0d9b55f818996a386d0ad5250 .
Is this still an issue? If so, please feel free to update the task description and re-add the good first task tag.

kaldari unsubscribed.Dec 15 2016, 10:21 PM
AndyRussG added a project: Fundraising-Backlog.Jan 21 2017, 2:56 AM
• ggellerman added a project: good first task.Jan 31 2017, 10:13 PM
• ggellerman moved this task from Triage to Old Unscheduled (prior to 2019) on the Fundraising-Backlog board.
Base subscribed.Feb 19 2017, 1:47 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:39 PM
Aklapper removed a project: good first task.Sep 15 2020, 4:04 PM

It's not very helpful to re-add tags while ignoring the comment which explains why the tag got removed.

AKanji-WMF closed subtask T116235: [Epic] CentralNotice translation should move closer to MediaWiki i18n standards and the code cleaned up as Declined.May 8 2023, 5:41 PM
Tacsipacsi reopened subtask T116235: [Epic] CentralNotice translation should move closer to MediaWiki i18n standards and the code cleaned up as Open.May 9 2023, 9:49 AM
Winston_Sung moved this task from Untriaged to Translation difficulties on the I18n board.Aug 9 2023, 1:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits