Consistently style links between read mode VisualEditor modes (internal, inter-wiki and external)
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Kaartic
	Jan 17 2018, 10:11 AM

Description

I've recently seen a considerable amount of inconsistency in the ways in which the different types of links (internal, inter-wiki and external) are styled in various cases such as,

Rendered wikitext
VisualEditor
2017 wikitext editor preview

I searched for the related tasks and found a few of them but there wasn't anything that collects the different issues together and not every issue was covered. (I'll link the tasks I found to be most related, below.) So I thought of creating a task that collects them together. So, the tagging might be incorrect correct them in case they aren't right.

Wikitext

= Links =

=== Internal link ===
[[Special:Random]]

=== Inter-wiki link ===
[[m:Parsoid/Tests:quotes]]

[[dict:foo]]

=== External link ===
[https://example.com External link]

Different stylings

	Read mode rendering	VisualEditor rendering	2017 wikitext editor preview	Standalone visual diff
Screenshot
Internal links	No icon	No icon	No icon	No icon
Inter-wiki links	No icon	With icon	No icon	No icon
External links	With icon	With icon	No icon	No icon
Notes	All other modes must match read mode rendering.	Partially fixed by https://gerrit.wikimedia.org/r/508693	T187571; fixed by T58756	T187692; not fixed?

Environment details

Browser	Firefox Nightly 59.0a1
OS	Debian GNU/Linux 9 (stretch)
Skin	Vector (default)

Related tasks

Details

	Subject	Repo	Branch	Lines +/-
	Fix initial rendering of interwiki links	mediawiki/extensions/VisualEditor	master	+6 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T322340 Support editing interwiki links within the visual editor
		Open		None	T185083 Consistently style links between read mode VisualEditor modes (internal, inter-wiki and external)

Event Timeline

Kaartic created this task.Jan 17 2018, 10:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2018, 10:11 AM

Kaartic updated the task description. (Show Details)Jan 17 2018, 10:16 AM

The missing icon after external links in NWE preview is definitely a regression, in T180214 it was still there.

This is related to T58756. Depending on how that is resolved this is probably duplicate.

• Esanders merged a task: T187571: External links look like interwiki links in preview.Feb 16 2018, 6:24 PM

• Esanders added a subscriber: Bencemac.

• Esanders merged a task: T187692: Correctly style external links in visual diffs.Feb 20 2018, 2:49 PM

The NWE preview issues should be fixed now.

However, VE showing external links for interwiki links isn't fixed because VE doesn't know about interwiki links .. it needs to convert the link to Wikitext (by asking Parsoid) and only then will it know if the "external link to another wiki" is actually an interwiki link.

I am going to consider the Parsoid side of this issue resolved and will untag Parsoid.

• ssastry removed a project: Parsoid.Mar 19 2018, 4:47 PM

Dvorapa subscribed.Mar 19 2018, 10:01 PM

Krinkle mentioned this in T191405: Mark interwiki links as external links when they fall outside the WMF family.Apr 23 2018, 7:29 PM

Krinkle mentioned this in T178862: Revisit different color of links for internal (inner-domain) and interwiki/external links.

matmarex merged a task: T208310: When editing existing interwiki links, they appear as external.Dec 19 2018, 10:05 PM

matmarex added a subscriber: Krenair.

Can someone determine whether or not this is resolved?

JTannerWMF moved this task from Incoming to Engineering QA on the VisualEditor (Current work) board.May 7 2019, 3:42 PM

The Parsoid side is finished, but we still render interwiki links as external in VE.

Change 508693 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix initial rendering of interwiki links

https://gerrit.wikimedia.org/r/508693

gerritbot added a project: Patch-For-Review.May 7 2019, 7:46 PM

"This does not fix the rendering of new or modified interwiki links, which will require an API request."

Esanders merged a task: T187571: External links look like interwiki links in preview.

I don't think that was actually a duplicate of this task. But it seems to be resolved now, thanks to Parsoid changes from T58756.

Esanders merged a task: T187692: Correctly style external links in visual diffs.

I don't think this is a duplicate either. The proposed patch above does not resolve this issue.

matmarex moved this task from Engineering QA to Code review on the VisualEditor (Current work) board.May 8 2019, 10:23 PM

matmarex updated the task description. (Show Details)May 8 2019, 10:33 PM

Change 508693 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix initial rendering of interwiki links

https://gerrit.wikimedia.org/r/508693

matmarex updated the task description. (Show Details)May 8 2019, 10:42 PM

I made a pretty table and added a case that covers T187692, since it was merged here.

Jdforrester-WMF added a project: VisualEditor-MediaWiki.May 8 2019, 10:50 PM

matmarex updated the task description. (Show Details)May 8 2019, 10:51 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 8 2019, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:55 PM

Krinkle renamed this task from Consistently style links (internal, inter-wiki and external) to Consistently style links between read mode VisualEditor modes (internal, inter-wiki and external).May 22 2019, 9:17 PM

• Esanders removed projects: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), Regression.May 23 2019, 3:15 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptMay 23 2019, 3:15 PM

Partially fixed by latest patch. Moving back off current work board as other cases are lower priority.

matmarex added a parent task: T322340: Support editing interwiki links within the visual editor.Nov 3 2022, 10:02 PM

	F12611486: links confusion (wikitext).png
	Jan 17 2018, 10:11 AM

	F12611561: link confusion (rendering).png
	Jan 17 2018, 10:11 AM

	F28972764: image.png
	May 8 2019, 10:42 PM

Consistently style links between read mode VisualEditor modes (internal, inter-wiki and external)Open, Needs TriagePublicActions