Maniphest T195288

Local exception for notifications does not work
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Congragulations, it's awesome!

The first bug:

Steps to reproduce

Open global preferences.
Make "Notify me about these events" at notifications tab global.
Open local preferences.
Set a local exception for them.
The boxes remain unclickable.

Screen Shot 2018-06-04 at 3.06.00 PM.png (464×368 px, 58 KB)

Thank you.

Expected behavior

The boxes for local preferences should be clickable when the local override is selected.

Details

	Subject	Repo	Branch	Lines +/-
	Support local overrides for CheckMatrix	mediawiki/extensions/GlobalPreferences	master	+34 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Niharika	T139145 global disabling of compact language list
Resolved	None	T16950 [Epic] Support global preferences on Wikimedia wikis
Resolved	• TBolliger	T184121 Deploy checklist for GlobalPreferences on production
Resolved	MaxSem	T189806 Deploy GlobalPrefs on production
Resolved	MaxSem	T195288 Local exception for notifications does not work

Event Timeline

IKhitron created this task.May 22 2018, 10:00 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 22 2018, 10:00 AM

@MaxSem?

Could it be related to T195253 ?

• TBolliger moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.May 24 2018, 4:27 PM

In T195288#4225965, @jcrespo wrote:

Could it be related to T195253 ?

I strongly doubt it.

JTannerWMF moved this task from Untriaged to External on the Collaboration-Team-Triage board.May 30 2018, 6:15 PM

• TBolliger updated the task description. (Show Details)Jun 4 2018, 10:06 PM

• TBolliger moved this task from Needs Discussion to Up Next (May 20-June 3) on the Community-Tech board.Jun 5 2018, 11:32 PM

• TBolliger set the point value for this task to 3.

In my case I selected "Set a local exception for this global preference" and the box became clickable; then I made one change ad I saved. But when I reloaded the page "Set a local exception for this global preference" was still selected, but the change I made had disappeared. I tried many times, but every time I made the change and then it disappeared.

Niharika edited projects, added Community-Tech-Sprint; removed Community-Tech.Jun 12 2018, 11:12 PM

MaxSem claimed this task.Jun 14 2018, 2:21 AM

MaxSem moved this task from Ready to In Development on the Community-Tech-Sprint board.

Change 440564 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Support local overrides for CheckMatrix

https://gerrit.wikimedia.org/r/440564

gerritbot added a project: Patch-For-Review.Jun 15 2018, 7:49 PM

MaxSem moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Jun 15 2018, 7:52 PM

Niharika moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Jun 18 2018, 11:08 PM

greg unsubscribed.Jun 18 2018, 11:34 PM

MaxSem moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Jun 21 2018, 9:39 PM

Change 440564 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Support local overrides for CheckMatrix

https://gerrit.wikimedia.org/r/440564

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 6:01 PM

• Vvjjkkii renamed this task from Local exception for notifications does not work to nicaaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii removed MaxSem as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii removed subscribers: Aklapper, gerritbot, MarcoAurelio.

Marostegui renamed this task from nicaaaaaaa to Local exception for notifications does not work.Jul 1 2018, 6:50 PM

Marostegui assigned this task to MaxSem.

Marostegui lowered the priority of this task from High to Medium.

Marostegui removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Marostegui updated the task description. (Show Details)

CommunityTechBot set the point value for this task to 3.Jul 5 2018, 6:45 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 5 2018, 6:45 PM

CommunityTechBot raised the priority of this task from Medium to Needs Triage.Jul 5 2018, 6:45 PM

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

IKhitron mentioned this in T189806: Deploy GlobalPrefs on production.Jul 10 2018, 2:51 PM

JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 10 2018, 5:30 PM

Well, it works on mediawiki.org.

In T195288#4413230, @IKhitron wrote:

Well, it works on mediawiki.org.

Yes, the code has been deployed to Group 0 wikis earlier today.

In T195288#4413235, @Niharika wrote:

In T195288#4413230, @IKhitron wrote:

Well, it works on mediawiki.org.

Yes, the code has been deployed to Group 0 wikis earlier today.

Yap, I know. I just wanted to see it :-)

Niharika moved this task from Needs Review/Feedback to QA on the Community-Tech-Sprint board.Jul 11 2018, 12:02 AM

• TBolliger unsubscribed.Jul 11 2018, 5:15 PM

Niharika closed this task as Resolved.Jul 17 2018, 8:07 PM

Niharika moved this task from QA to Q1 2018-19 on the Community-Tech-Sprint board.

Niharika added a project: Community-Tech.Jul 27 2018, 9:14 PM

	F18755621: Screen Shot 2018-06-04 at 3.06.00 PM.png
	Jun 4 2018, 10:06 PM

Local exception for notifications does not workClosed, ResolvedPublic3 Estimated Story PointsActions