Page MenuHomePhabricator
Create Task
Maniphest T195807

Fix failing MediaWiki core tests on Postgres database backend
Closed, ResolvedPublic
Actions

Description

MediaWiki core now runs tests using postgres as an experimental job (comment "check experimental" on your patch for it to run). Once all of the current failures are fixed, we can make it voting.

29 May 2018: P7168.

27 Jun 2018 (Travis CI - postgres - errors):

There was 1 error:
1) MediaWiki\Tests\Storage\SqlBlobStoreTest::testSimpleStoreGetBlobSimpleRoundtripWindowsLegacyEncodingGzip with data set #1 ('someText')
gzinflate(): data error
/home/travis/build/wikimedia/mediawiki/includes/Storage/SqlBlobStore.php:484
/home/travis/build/wikimedia/mediawiki/includes/Storage/SqlBlobStore.php:411
/home/travis/build/wikimedia/mediawiki/includes/Storage/SqlBlobStore.php:349
/home/travis/build/wikimedia/mediawiki/includes/Storage/SqlBlobStore.php:277
/home/travis/build/wikimedia/mediawiki/includes/libs/objectcache/WANObjectCache.php:1242
/home/travis/build/wikimedia/mediawiki/includes/libs/objectcache/WANObjectCache.php:1115
/home/travis/build/wikimedia/mediawiki/includes/Storage/SqlBlobStore.php:279
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/SqlBlobStoreTest.php:249
--

27 Jun 2018 (Travis CI - postgres - failures):

There were 26 failures:
1) PageArchiveTest::testListRevisions
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'ar_minor_edit' => '0'
     'ar_user' => '0'
-    'ar_user_text' => '2600:387:ed7:947e:8c16:a1ad:dd34:1dd7'
+    'ar_user_text' => '127.0.0.1'
     'ar_actor' => null
-    'ar_len' => '11'
+    'ar_len' => '7'
     'ar_deleted' => '0'
-    'ar_rev_id' => '3'
-    'ar_sha1' => '0qdrpxl537ivfnx4gcpnzz0285yxryy'
+    'ar_rev_id' => '2'
+    'ar_sha1' => 'pr0s8e18148pxhgjfa0gjrvpy8fiyxc'
     'ar_page_id' => '2'
-    'ar_comment_text' => 'just a test'
+    'ar_comment_text' => 'testing'
     'ar_comment_data' => null
     'ar_comment_cid' => null
     'ar_content_format' => null
     'ar_content_model' => null
     'ts_tags' => null
-    'ar_id' => '2'
+    'ar_id' => '1'
     'ar_namespace' => '0'
     'ar_title' => 'PageArchiveTest_thePage'
-    'ar_text_id' => '3'
-    'ar_parent_id' => '2'
+    'ar_text_id' => '2'
+    'ar_parent_id' => '0'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/PageArchiveTest.php:175
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
2) MediaWiki\Tests\Storage\McrRevisionStoreDbTest::testInsertRevisionOn_successes with data set #0 (array(MediaWiki\Storage\SlotRecord Object (...), true, CommentStoreComment Object (...), '20171117010101', true))
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => '2'
     1 => '1'
-    2 => '2017-11-17 01:01:01 GMT'
+    2 => '2017-11-17 01:01:01+00'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:444
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/McrRevisionStoreDbTest.php:57
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:418
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
3) MediaWiki\Tests\Storage\McrRevisionStoreDbTest::testInsertRevisionOn_successes with data set #1 (array(MediaWiki\Storage\SlotRecord Object (...), true, true, CommentStoreComment Object (...), '20171117010101', true, true, 8))
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => '2'
     1 => '1'
-    2 => '2017-11-17 01:01:01 GMT'
+    2 => '2017-11-17 01:01:01+00'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:444
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/McrRevisionStoreDbTest.php:57
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:418
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
4) MediaWiki\Tests\Storage\McrRevisionStoreDbTest::testInsertRevisionOn_successes with data set "Multi-slot revision insertion" (array(array(WikitextContent Object (...), TextContent Object (...)), true, CommentStoreComment Object (...), '20171117010101', true))
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => '2'
     1 => '1'
-    2 => '2017-11-17 01:01:01 GMT'
+    2 => '2017-11-17 01:01:01+00'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:444
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/McrRevisionStoreDbTest.php:57
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:418
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
5) MediaWiki\Tests\Storage\McrWriteBothRevisionStoreDbTest::testInsertRevisionOn_successes with data set "Bare minimum revision insertion" (array(MediaWiki\Storage\SlotRecord Object (...), true, CommentStoreComment Object (...), '20171117010101', true))
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => '2'
     1 => '1'
-    2 => '2017-11-17 01:01:01 GMT'
+    2 => '2017-11-17 01:01:01+00'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:444
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/McrWriteBothRevisionStoreDbTest.php:49
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:418
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
6) MediaWiki\Tests\Storage\McrWriteBothRevisionStoreDbTest::testInsertRevisionOn_successes with data set "Detailed revision insertion" (array(MediaWiki\Storage\SlotRecord Object (...), true, true, CommentStoreComment Object (...), '20171117010101', true, true, 8))
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => '2'
     1 => '1'
-    2 => '2017-11-17 01:01:01 GMT'
+    2 => '2017-11-17 01:01:01+00'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:444
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/McrWriteBothRevisionStoreDbTest.php:49
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:418
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
7) MediaWiki\Tests\Storage\McrWriteBothRevisionStoreDbTest::testGetSlotsQueryInfo with data set #1 (array('content'), array(array('revision'), array('slots.rev_id', 'NULL', 'slots.rev_id', ''main'', 'slots.rev_len', 'slots.rev_sha1', 'CONCAT('tt:',slots.rev_text_id)', 'slots.rev_content_model'), array()))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
-    'content_address' => 'CONCAT('tt:',slots.rev_text_id)'
+    'content_address' => ''tt:' || slots.rev_text_id'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1865
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:1722
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:1678
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
8) MediaWiki\Tests\Storage\NameTableStoreTest::testGetAndAcquireIdInsertCallback
Failed asserting that 175 is identical to 7251.
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/NameTableStoreTest.php:312
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
9) MediaWiki\Tests\Storage\NoContentModelRevisionStoreDbTest::testInsertRevisionOn_successes with data set "Bare minimum revision insertion" (array(MediaWiki\Storage\SlotRecord Object (...), true, CommentStoreComment Object (...), '20171117010101', true))
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => '2'
     1 => '1'
-    2 => '2017-11-17 01:01:01 GMT'
+    2 => '2017-11-17 01:01:01+00'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:444
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:418
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
10) MediaWiki\Tests\Storage\NoContentModelRevisionStoreDbTest::testInsertRevisionOn_successes with data set "Detailed revision insertion" (array(MediaWiki\Storage\SlotRecord Object (...), true, true, CommentStoreComment Object (...), '20171117010101', true, true, 8))
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => '2'
     1 => '1'
-    2 => '2017-11-17 01:01:01 GMT'
+    2 => '2017-11-17 01:01:01+00'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:444
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:418
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
11) MediaWiki\Tests\Storage\NoContentModelRevisionStoreDbTest::testGetSlotsQueryInfo with data set #1 (array('content'), array(array('revision'), array('slots.rev_id', 'NULL', 'slots.rev_id', ''main'', 'slots.rev_len', 'slots.rev_sha1', 'CONCAT('tt:',slots.rev_text_id)', 'NULL'), array()))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'slot_revision_id' => 'slots.rev_id'
     'slot_origin' => 'slots.rev_id'
     'content_size' => 'slots.rev_len'
     'content_sha1' => 'slots.rev_sha1'
-    'content_address' => 'CONCAT('tt:',slots.rev_text_id)'
+    'content_address' => ''tt:' || slots.rev_text_id'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1865
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:1722
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:1678
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
12) MediaWiki\Tests\Storage\PreMcrRevisionStoreDbTest::testInsertRevisionOn_successes with data set "Bare minimum revision insertion" (array(MediaWiki\Storage\SlotRecord Object (...), true, CommentStoreComment Object (...), '20171117010101', true))
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => '2'
     1 => '1'
-    2 => '2017-11-17 01:01:01 GMT'
+    2 => '2017-11-17 01:01:01+00'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:444
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:418
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
13) MediaWiki\Tests\Storage\PreMcrRevisionStoreDbTest::testInsertRevisionOn_successes with data set "Detailed revision insertion" (array(MediaWiki\Storage\SlotRecord Object (...), true, true, CommentStoreComment Object (...), '20171117010101', true, true, 8))
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => '2'
     1 => '1'
-    2 => '2017-11-17 01:01:01 GMT'
+    2 => '2017-11-17 01:01:01+00'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:444
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:418
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
14) MediaWiki\Tests\Storage\PreMcrRevisionStoreDbTest::testGetSlotsQueryInfo with data set #1 (array('content'), array(array('revision'), array('slots.rev_id', 'NULL', 'slots.rev_id', ''main'', 'slots.rev_len', 'slots.rev_sha1', 'CONCAT('tt:',slots.rev_text_id)', 'slots.rev_content_model'), array()))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
-    'content_address' => 'CONCAT('tt:',slots.rev_text_id)'
+    'content_address' => ''tt:' || slots.rev_text_id'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1865
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:1722
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/RevisionStoreDbTestBase.php:1678
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
15) MediaWiki\Tests\Storage\SqlBlobStoreTest::testSimpleStoreGetBlobSimpleRoundtripWindowsLegacyEncodingGzip with data set #2 ('sammansättningar')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'sammansättningar'
+'sgϖ/j_oooTningoR'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/SqlBlobStoreTest.php:249
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
16) ApiBaseTest::testGetTitleOrPageIdInvalidPageId
Failed asserting that exception of type "Wikimedia\Rdbms\DBQueryError" matches expected exception "ApiUsageException". Message was: "A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
Query: SELECT  page_id,page_namespace,page_title,page_restrictions,page_is_redirect,page_is_new,page_random,page_touched,page_links_updated,page_latest,page_len,page_content_model  FROM "unittest_page"    WHERE page_id = '2147483648'  LIMIT 1  
Function: WikiPage::newFromID
Error: 22003 ERROR:  value "2147483648" is out of range for type integer
LINE 1: ...nt_model  FROM "unittest_page"    WHERE page_id = '214748364...
                                                             ^
" at
/home/travis/build/wikimedia/mediawiki/includes/libs/rdbms/database/Database.php:1443
/home/travis/build/wikimedia/mediawiki/includes/libs/rdbms/database/Database.php:1413
/home/travis/build/wikimedia/mediawiki/includes/libs/rdbms/database/Database.php:1186
/home/travis/build/wikimedia/mediawiki/includes/libs/rdbms/database/Database.php:1640
/home/travis/build/wikimedia/mediawiki/includes/libs/rdbms/database/Database.php:1731
/home/travis/build/wikimedia/mediawiki/includes/page/WikiPage.php:174
/home/travis/build/wikimedia/mediawiki/includes/api/ApiBase.php:1062
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/api/ApiBaseTest.php:181
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
.
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
17) ChangeTagsTest::testUpdateTagsMigrationWriteBoth
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => stdClass Object (
-        'ctd_name' => 'tag1'
-        'ctd_id' => 1
-        'ctd_count' => 2
+        'ctd_name' => 'tag2'
+        'ctd_id' => '2'
+        'ctd_count' => '1'
     )
     1 => stdClass Object (
-        'ctd_name' => 'tag2'
-        'ctd_id' => 2
-        'ctd_count' => 1
+        'ctd_name' => 'tag1'
+        'ctd_id' => '1'
+        'ctd_count' => '2'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/changetags/ChangeTagsTest.php:450
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
18) WikiPageMcrDbTest::testDoRollback
rollback did not revert to the correct revision
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'t8tivusls0jl6wusjjv1gfnakp75mwb'
+'to7r84xq6nktrsiigtf00jn7lggol52'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1085
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
19) WikiPageMcrDbTest::testUpdateRedirectOn with data set #1 ('#REDIRECT [[Foo]]', true, 'Foo', true, false, 1)
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => '1'
+    0 => '2'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1606
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1598
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
20) WikiPageMcrWriteBothDbTest::testDoRollback
rollback did not revert to the correct revision
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'t8tivusls0jl6wusjjv1gfnakp75mwb'
+'to7r84xq6nktrsiigtf00jn7lggol52'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1085
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
21) WikiPageMcrWriteBothDbTest::testUpdateRedirectOn with data set #1 ('#REDIRECT [[Foo]]', true, 'Foo', true, false, 1)
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => '1'
+    0 => '2'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1606
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1598
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
22) WikiPageNoContentModelDbTest::testDoRollback
rollback did not revert to the correct revision
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'t8tivusls0jl6wusjjv1gfnakp75mwb'
+'to7r84xq6nktrsiigtf00jn7lggol52'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1085
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
23) WikiPageNoContentModelDbTest::testUpdateRedirectOn with data set #1 ('#REDIRECT [[Foo]]', true, 'Foo', true, false, 1)
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => '1'
+    0 => '2'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1606
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1598
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
24) WikiPagePreMcrDbTest::testDoRollback
rollback did not revert to the correct revision
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'t8tivusls0jl6wusjjv1gfnakp75mwb'
+'to7r84xq6nktrsiigtf00jn7lggol52'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1085
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
25) WikiPagePreMcrDbTest::testUpdateRedirectOn with data set #1 ('#REDIRECT [[Foo]]', true, 'Foo', true, false, 1)
row #1 mismatches
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => '1'
+    0 => '2'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:1809
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1606
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/page/WikiPageDbTestBase.php:1598
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
26) UserTest::testFindUsersByGroup
Failed asserting that false is true.
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/user/UserTest.php:589
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:469
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94

A while back @Anomie gave me some hints on IRC about the issues (lightly edited):

[07:43:30] <anomie> All the timestamp failures are someone hardcoding a timestamp (assuming TS_MW) instead of using $db->timestamp().
[07:43:35] <anomie> gzinflate() is probably something to do with code writing binary data to a text field. MySQL uses all binary fields, so it isn't noticed there.
[07:45:36] <anomie> The PageArchive failures are probably due to code inserting multiple revisions with the same timestamp and assuming the DB will silently break ties by rev_id. Not even MySQL guarantees that behavior, but the specific queries there probably happen to work.
[07:46:10] <anomie> SqlBlobStoreTest is probably another binary-vs-text fail.
[07:46:53] <anomie> The WikiPage ones are probably either binary-vs-text or ordering like PageArchive, I can't tell which from looking.
[07:47:40] <anomie> No idea about the MediaWikiTestCaseSchema1Test failures. That whole idea is semi-broken anyway, we'd need to do T191231 first to make it sane.
[08:02:57] <anomie> Also the PG schema uses "text" in cases where it should probably be using "bytea", so that's not entirely the calling code's fault. In general MW probably needs to get stricter about that distinction somehow or other.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jun 2 2018, 2:52 AM

Change 436969 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Skip MediaWikiTestCaseSchema1Test on Postgres

https://gerrit.wikimedia.org/r/436969

gerritbot added a comment.Jun 2 2018, 3:36 AM

Change 436970 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] tests: Reset mwuser/pagecontent tables if necessary for postgres

https://gerrit.wikimedia.org/r/436970

gerritbot added a comment.Jun 7 2018, 2:39 PM

Change 436970 merged by jenkins-bot:
[mediawiki/core@master] tests: Reset mwuser/pagecontent tables if necessary for postgres

https://gerrit.wikimedia.org/r/436970

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)); removed MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 7 2018, 3:00 PM
Legoktm mentioned this in T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.Jun 11 2018, 6:25 PM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jun 15 2018, 12:48 PM
Krinkle added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Jun 26 2018, 3:26 PM
gerritbot added a comment.Jun 26 2018, 3:44 PM

Change 436969 merged by jenkins-bot:
[mediawiki/core@master] Skip MediaWikiTestCaseSchema1Test on Postgres

https://gerrit.wikimedia.org/r/436969

Krinkle moved this task from Untriaged to In progress on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.Jun 27 2018, 3:56 PM
Krinkle updated the task description. (Show Details)Jun 27 2018, 3:58 PM
Krinkle removed a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 28 2018, 10:48 PM
Krinkle removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 5:02 PM
• Vvjjkkii renamed this task from Fix failing MediaWiki core tests on Postgres database backend to 83baaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Krinkle renamed this task from 83baaaaaaa to Fix failing MediaWiki core tests on Postgres database backend.Jul 1 2018, 11:39 PM
Krinkle raised the priority of this task from High to Needs Triage.
Krinkle removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Krinkle updated the task description. (Show Details)
Krinkle added a subscriber: Aklapper.
MacFan4000 added a subscriber: gerritbot.Jul 1 2018, 11:42 PM
gerritbot added a comment.Aug 1 2018, 10:22 PM

Change 449669 had a related patch set uploaded (by Krinkle; owner: Legoktm):
[mediawiki/core@master] Disable PHPUnit tests that fail under postgres

https://gerrit.wikimedia.org/r/449669

gerritbot added a project: Patch-For-Review.Aug 1 2018, 10:22 PM
Krinkle mentioned this in T59724: PostgreSQL / PHPUnit tests / MW 1.21.0 / $wikiPage->doDeleteArticle causes DatabasePostgres::reportQueryError: No transaction to rollback, something got out of sync.Aug 1 2018, 10:26 PM
gerritbot added a comment.Aug 1 2018, 10:50 PM

Change 449669 merged by jenkins-bot:
[mediawiki/core@master] Disable PHPUnit tests that fail under postgres

https://gerrit.wikimedia.org/r/449669

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 1 2018, 11:01 PM
Krinkle moved this task from In progress to Resolved on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.Aug 16 2018, 5:58 PM
Krinkle removed projects: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review.
gerritbot added a comment.Sep 10 2018, 6:29 PM

Change 459601 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/libs/Timestamp@master] Fix TS_POSTGRES to match PostgreSQL's actual output

https://gerrit.wikimedia.org/r/459601

gerritbot added a project: Patch-For-Review.Sep 10 2018, 6:29 PM
gerritbot added a comment.Sep 10 2018, 6:54 PM

Change 459601 merged by jenkins-bot:
[mediawiki/libs/Timestamp@master] Fix TS_POSTGRES to match PostgreSQL's actual output

https://gerrit.wikimedia.org/r/459601

Anomie mentioned this in R1985:abdd0f70b059: Fix TS_POSTGRES to match PostgreSQL's actual output.Sep 10 2018, 7:04 PM
gerritbot added a comment.Sep 10 2018, 7:33 PM

Change 459618 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/vendor@master] Update wikimedia/timestamp to v2.1.1

https://gerrit.wikimedia.org/r/459618

gerritbot added a comment.Sep 10 2018, 7:33 PM

Change 459619 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Update wikimedia/timestamp to v2.1.1

https://gerrit.wikimedia.org/r/459619

gerritbot added a comment.Sep 10 2018, 9:21 PM

Change 459618 merged by jenkins-bot:
[mediawiki/vendor@master] Update wikimedia/timestamp to v2.1.1

https://gerrit.wikimedia.org/r/459618

gerritbot added a comment.Sep 10 2018, 9:26 PM

Change 459619 merged by jenkins-bot:
[mediawiki/core@master] Update wikimedia/timestamp to v2.1.1

https://gerrit.wikimedia.org/r/459619

Jdforrester-WMF closed this task as Resolved.Sep 10 2018, 9:28 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

Fixed, I think? Please re-open if https://gerrit.wikimedia.org/r/c/mediawiki/core/+/459619#message-fe2bfae8de38336e2de75f22140a003142127ee6 isn't as positive as it seems.

Legoktm reopened this task as Open.Sep 10 2018, 9:40 PM
Legoktm removed Jdforrester-WMF as the assignee of this task.

Not yet :( https://codesearch.wmflabs.org/core/?q=fails%20under%20postgres&i=nope&files=&repos=

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 10 2018, 10:00 PM
gerritbot added a comment.Nov 5 2018, 12:43 PM

Change 471718 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/core@master] Update wikimedia/timestamp to v2.1.1

https://gerrit.wikimedia.org/r/471718

gerritbot added a project: Patch-For-Review.Nov 5 2018, 12:43 PM
gerritbot added a comment.Dec 16 2018, 11:12 AM

Change 471718 abandoned by D3r1ck01:
Enable tests for PostgreSQL fixed by new version of wikimedia/timestamp

Reason:
Dropping this for now!

https://gerrit.wikimedia.org/r/471718

Krinkle removed projects: Patch-For-Review, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Jan 22 2019, 3:57 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
gerritbot added a comment.Nov 27 2019, 8:01 PM

Change 553404 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] WikiPage: Fix indeterminate ordering in doRollback

https://gerrit.wikimedia.org/r/553404

gerritbot added a project: Patch-For-Review.Nov 27 2019, 8:01 PM
gerritbot added a comment.Nov 27 2019, 9:16 PM

Change 553404 merged by jenkins-bot:
[mediawiki/core@master] WikiPage: Fix indeterminate ordering in doRollback

https://gerrit.wikimedia.org/r/553404

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Nov 27 2019, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 27 2019, 10:10 PM
Krinkle closed this task as Resolved.Nov 28 2019, 3:49 AM
Krinkle claimed this task.
Krinkle edited projects, added MediaWiki-Core-Revision-backend, Platform Engineering; removed MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-Core-Tests.
Krinkle changed the subtype of this task from "Production Error" to "Task".
Anomie reopened this task as Open.Dec 2 2019, 4:05 PM
Anomie removed Krinkle as the assignee of this task.
Anomie added a subscriber: Krinkle.

Reopening, there are still several tests with "FIXME: fails under postgres".

Anomie moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Dec 2 2019, 7:01 PM
Krinkle added a comment.Dec 3 2019, 4:49 PM

Note that mediawiki-quibble-vendor-postgres-php72-docker is passing and enforced on every commit, so those are presumably disabled tests of which we have many outside Postgres as well. Fixing the disabled ones is a new goal post. Moving that seems fine, but perhaps we can list the ones currently known to be disabled for that reason so that there is a clear endpoint for this task (therefore not including new tests that may be disabled for similar reasons after today).

Anomie added a comment.Dec 3 2019, 4:57 PM

rMWb4ea2d8c8131: Disable PHPUnit tests that fail under postgres used that "FIXME: fails under postgres" comment. Only two were added since, in rMWc77d8705ca68: Stop updating tag_summary table. So that comment seems likely to fit the bill.

Ideally people would CR-1 patches trying to add new skips of that type.

WDoranWMF moved this task from Triage Meeting Inbox to Icebox on the Platform Engineering board.Dec 4 2019, 7:58 PM
WDoranWMF edited projects, added Platform Engineering (Icebox); removed Platform Engineering.Mar 23 2020, 2:03 PM
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 18 2020, 10:53 PM
Krinkle removed a project: ci-test-error (WMF-deployed Build Failure).Apr 19 2020, 5:39 PM
daniel mentioned this in T256401: ChangeTags are broken in postgres (at least in unit tests).Jun 25 2020, 5:24 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:01 PM
gerritbot added a comment.Jan 21 2022, 9:33 PM

Change 756054 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Linker::getRollbackEditCount confused on revisions with same timestamp

https://gerrit.wikimedia.org/r/756054

gerritbot added a project: Patch-For-Review.Jan 21 2022, 9:33 PM
gerritbot added a comment.Jan 21 2022, 10:19 PM

Change 756063 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Avoid COUNT(*) in assertSelect() for WikiPageDbTest

https://gerrit.wikimedia.org/r/756063

gerritbot added a comment.Jan 21 2022, 10:42 PM

Change 756091 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Sort by group name in User::findUsersByGroup

https://gerrit.wikimedia.org/r/756091

gerritbot added a comment.Jan 22 2022, 10:40 AM

Change 756110 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Fix signature of DatabasePostgres::buildGroupConcatField

https://gerrit.wikimedia.org/r/756110

gerritbot added a comment.Jan 22 2022, 11:39 AM

Change 756112 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Explicit order by primary in DeleteAutoPatrolLogs maintenance script

https://gerrit.wikimedia.org/r/756112

gerritbot added a comment.Jan 22 2022, 12:14 PM

Change 756113 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove passing markTestSkippedIfDbType or add comment

https://gerrit.wikimedia.org/r/756113

gerritbot added a comment.Jan 22 2022, 12:14 PM

Change 756091 abandoned by Umherirrender:

[mediawiki/core@master] Remove passing markTestSkippedIfDbType or add comment

Reason:

new clean patch set uploaded - Ie883b7056cdd0cb6bec81c2f7e4ed54177b4ecb2

https://gerrit.wikimedia.org/r/756091

gerritbot added a comment.Jan 22 2022, 2:38 PM

Change 756110 merged by jenkins-bot:

[mediawiki/core@master] Fix signature of DatabasePostgres::buildGroupConcatField

https://gerrit.wikimedia.org/r/756110

gerritbot added a comment.Jan 22 2022, 5:24 PM

Change 756112 merged by jenkins-bot:

[mediawiki/core@master] Explicit order by primary key in DeleteAutoPatrolLogs maintenance script

https://gerrit.wikimedia.org/r/756112

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 22 2022, 6:00 PM
gerritbot added a comment.Jan 22 2022, 6:56 PM

Change 756113 merged by jenkins-bot:

[mediawiki/core@master] Remove passing markTestSkippedIfDbType or add comment

https://gerrit.wikimedia.org/r/756113

Umherirrender closed this task as Resolved.Jan 22 2022, 9:41 PM
Umherirrender removed a project: Patch-For-Review.
Umherirrender added subscribers: Anomie, Umherirrender.
In T195807#5705603, @Anomie wrote:

Reopening, there are still several tests with "FIXME: fails under postgres".

The remaining fixmes are tagged with other tasks - T298692 and T198222

Anomie unsubscribed.Jan 24 2022, 3:17 AM
gerritbot added a comment.Jan 24 2022, 6:17 AM

Change 756077 had a related patch set uploaded (by Ammarpad; author: Umherirrender):

[mediawiki/core@REL1_37] Fix signature of DatabasePostgres::buildGroupConcatField

https://gerrit.wikimedia.org/r/756077

gerritbot added a project: Patch-For-Review.Jan 24 2022, 6:17 AM
gerritbot added a comment.Jan 24 2022, 9:53 AM

Change 756077 merged by jenkins-bot:

[mediawiki/core@REL1_37] Fix signature of DatabasePostgres::buildGroupConcatField

https://gerrit.wikimedia.org/r/756077

gerritbot added a comment.Jan 26 2022, 3:56 PM

Change 756054 merged by jenkins-bot:

[mediawiki/core@master] Linker::getRollbackEditCount confused on revisions with same timestamp

https://gerrit.wikimedia.org/r/756054

gerritbot added a comment.Jan 26 2022, 8:04 PM

Change 756063 merged by jenkins-bot:

[mediawiki/core@master] Avoid COUNT(*) in assertSelect() for WikiPageDbTest

https://gerrit.wikimedia.org/r/756063

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL