Page MenuHomePhabricator

Option to have FlaggedRevs rating box as an indicator
Open, MediumPublic

Description

The FlaggedRevs rating box (the one discussed in T155878) is at the top of the content area by default, meaning it can affect the layout of the page content (e.g. other elements floated to the right). Hungarian Wikipedia addressed this problem by moving the box to the title, exactly to the place where the indicator icons appeared some years later. However, they use different positioning, meaning that they overlap if both are present. Please create an option (PHP setting) to move the box to the indicators in PHP code. It may require some visual changes to align with the other indicators’ style, especially the help link’s, as they are often next to each other on category pages.

My conception about how it would look like:


(This is not exactly the same: different icon because it’s a different state, also I don’t want to change whether text is shown or not, but I hope you get the idea.)

Event Timeline

Vvjjkkii renamed this task from Option to have FlaggedRevs rating box as an indicator to rhaaaaaaaa.Jul 1 2018, 1:02 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
TerraCodes renamed this task from rhaaaaaaaa to Option to have FlaggedRevs rating box as an indicator.Jul 1 2018, 2:15 AM
TerraCodes raised the priority of this task from High to Needs Triage.
TerraCodes updated the task description. (Show Details)
TerraCodes added a subscriber: Aklapper.

Any hope to get progress on this? Or at least some feedback from the maintainers? Now, after T155878, the icons are OK, so it just needs to be moved to the indicators.

@Tacsipacsi: Which maintainers? FlaggedRevs has no ownership. See https://phabricator.wikimedia.org/T185664 .
Also see https://www.mediawiki.org/wiki/Gerrit/Tutorial how you can provide a patch if you want to see this issue fixed...

@Tacsipacsi: Which maintainers? FlaggedRevs has no ownership. See https://phabricator.wikimedia.org/T185664 .

Ah, that explains why the maintainers haven’t responded yet. This task requires a bit more designer skills than I have, but given the complaints in the mentioned task regarding the UX state of the extension hopefully I can’t worsen it. :) I’ll see if I can come up with an (at least for myself) acceptable design.

ovasileva triaged this task as Medium priority.Mon, Jun 7, 7:13 AM
ovasileva added a project: Readers-Web-Backlog.
ovasileva added a subscriber: ovasileva.
Jdlrobson added a subscriber: Jdlrobson.

I'll look at this today.

Change 698870 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/FlaggedRevs@master] Support outputting flagged revision status as article indicator

https://gerrit.wikimedia.org/r/698870

This looks pretty straightforward. I managed to setup an install with 2 lines of Localsettings.php and running the maintenance script

wfLoadExtension('FlaggedRevs');
$wgGroupPermissions['sysop']['review'] = true; //allow administrators to review revisions

Since we're not familiar with this extension I recommend using a feature flag to de-risk this. A separate deploy can be used to first deploy this on huwiki and then others where needed.

I managed to setup an install with 2 lines of Localsettings.php and running the maintenance script

wfLoadExtension('FlaggedRevs');
$wgGroupPermissions['sysop']['review'] = true; //allow administrators to review revisions

The second line is not even necessary, it’s default in rEFLR extension.json:120 (at 0b3d67140a4d).

Since we're not familiar with this extension I recommend using a feature flag to de-risk this.

I think feature flag is a must-have; each and every wiki should turn it on separately. This is a so long-standing wanted feature that probably several wikis (at least huwiki and enwiki that I know of) have developed workarounds for it. Deploying this change without coordinating with the affected community is likely to break these workarounds.

With above patch:



Do you think this would be sufficient @Tacsipacsi as a first pass (obviously once the approach here is taken too completion)? I know you mentioned "I think the indicator itself needs some redesign to accommodate to its new position, for example by removing its borders" - but we'd do that in a follow up with some input from @alexhollender

"(but probably the trickier part is designing the dropdown, for which I have no definite ideas)."

The dropdown seems to be working for me in the new position. Is there something I'm missing?

I am also wondering if while we're here, we should move to the standardized warningbox styles (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/699030) - would that be controversial?:


With above patch:



Do you think this would be sufficient @Tacsipacsi as a first pass (obviously once the approach here is taken too completion)? I know you mentioned "I think the indicator itself needs some redesign to accommodate to its new position, for example by removing its borders" - but we'd do that in a follow up with some input from @alexhollender

I don’t like what I see on your screenshot. What I see after checking out patchset 4 is much better. It has still moved (from below the yellow “Revision as of…” box to above it), but that’s a fairly minor, acceptable change. However, the design is not mature enough that I’d like have this served to everybody on huwiki. Either some other method is added to enable the new version (e.g. a request parameter), or I won’t propose trying it out on huwiki. (Which is absolutely okay on my side, I don’t care if it’s ready a few weeks later, given that this task has been sitting here for nearly three years for now.)

"(but probably the trickier part is designing the dropdown, for which I have no definite ideas)."

The dropdown seems to be working for me in the new position. Is there something I'm missing?

Technically it works, but without the interlanguage links being in the header, its lower border is a few pixels above the page title’s lower border, which looks ugly IMO (this is why I haven’t simply moved the box to the indicators using the on-wiki Vector.js).

I am also wondering if while we're here, we should move to the standardized warningbox styles (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/699030) - would that be controversial?:


Certainly, I recall some controversies around the watchlist warning about unreviewed watched pages (985dc2b5d569? T107472? I don’t remember). But that doesn’t mean it shouldn’t be implemented, the question is whether the gain on being consistent outweighs the loss on people becoming angry because of the change. Anyways, if it’s changed, I think the message on the second screenshot should be neutral grey, not successful green. (But using messagebox can lead to unexpected layout due to on-wiki customizations, so T270796 should be deployed first.)

Okay, we can skip the change in color of the boxes for now. Scope creep on my part :)

My thinking around doing the move without any design changes is it empowers site admins who want to use the indicators to style it using MediaWiki:Common.css and lowers the risk on something that has questionable maintenance support.

Do we have any test instances running FlaggedRevs on the beta cluster? I don't think it's on https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page

My thinking around doing the move without any design changes is it empowers site admins who want to use the indicators to style it using MediaWiki:Common.css and lowers the risk on something that has questionable maintenance support.

As long as it’s opt-in for the wikis, I don’t think there’s too much risk in making it look good, while the goal of the Desktop Improvements project is to make Wikipedia look better and more modern, so keeping this old-fashioned and (in its new position) not-so-good-looking piece is against this goal.

Do we have any test instances running FlaggedRevs on the beta cluster? I don't think it's on https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page

Since FlaggedRevs is a big thing especially in German-language projects, it’s on the German beta wiki, see pages with pending changes.

Okay great so this is what I suggest:

  • For now: Apply the change above, making sure notices show in the notice area, and icons show in the indicators
  • Get this on the German beta cluster, and get some input from a designer around how to improve that (follow up task)
  • Make design changes
  • Enable on one of the wikis impacted by the coordinates bug.

Does this sound like a plan?

Just an observation: is it on purpose that unregistered users on mobile (Minerva) will not see any box/notification (that is the case now already, but the indicator area is of course no different)? From a dewiki perspective, I feel like this would be an important information for all users (similar to hatnote warnings etc.).

Does this sound like a plan?

Looks good to me. I wouldn’t create a follow-up task for the design changes, though, rather consider them part of this task, but that’s just an organizational detail I don’t care much about.

Just an observation: is it on purpose that unregistered users on mobile (Minerva) will not see any box/notification (that is the case now already, but the indicator area is of course no different)? From a dewiki perspective, I feel like this would be an important information for all users (similar to hatnote warnings etc.).

Not on my side. To be honest, I didn’t even think about mobile experience here (sorry!), but in general I’m all for showing useful indicators on mobile. Since T75299 tries to find a general solution, it’ll hopefully help FlaggedRevs boxes hidden in df619a5d8a69 to appear on mobile once again.

I'm not steward of this codebase (steward is a strong word) but I have been doing a lot of work on it recently that's why I want to mention that this extension is one of the oldest and worst extensions we have in production in terms of code quality, test coverage, unnecessary complexity, and any other aspect you can imagine. On top of that, this code doesn't have an official steward (T185664: Code stewardship review: FlaggedRevs) so I humbly ask you to be extremely careful here.

Its configuration is in a dedicated file in wmf-config/ called flaggedrevs.php and more importantly it has four UI modes (simple or not simple, low-profile or not low-profile). Make sure any changes there not break any of the four different modes. Also any sort of addressing some tech debt (specially in form of simplification and drop unused stuff) is extremely appreciated (I have been trying to do a little bit in T277883: Drop all low-use and unused features of FlaggedRevs to make it more maintainable).