Page MenuHomePhabricator

QA mobile page issues modal
Closed, ResolvedPublic

Description

Some of the work being done on the mobile page issue styling may effect how the page issues modal renders. Before we ship the updates to mobile page issues we should be sure to do some QA on the modal. Specifically in some cases the “x” and the issue icons were missing.

Event Timeline

Not sure what column is appropriate for this as I assume Anthony will be doing this but I'm not sure of his workflow...

Vvjjkkii renamed this task from QA mobile page issues modal to 6baaaaaaaa.Jul 1 2018, 1:03 AM
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
ovasileva raised the priority of this task from Medium to High.Aug 30 2018, 2:17 PM

Was this done as part of T204090, or will it involve additional languages (beyond those checked there for the A/B test)?

^ I would also like to know the answer about this and how this task differs from T204090, (and who's doing it!)

languagesingle issuesection issuemultiple issuesminerva desktopnotes
English
Screen Shot 2018-11-07 at 3.47.50 PM.png (731×448 px, 50 KB)
link
Screen Shot 2018-11-07 at 3.48.49 PM.png (739×406 px, 39 KB)
link
Screen Shot 2018-11-07 at 3.49.38 PM.png (738×442 px, 85 KB)
link
Screen Shot 2018-11-07 at 3.50.55 PM.png (371×1 px, 50 KB)
link
as expected
Spanish
Screen Shot 2018-11-07 at 3.51.39 PM.png (738×401 px, 33 KB)
link
Screen Shot 2018-11-07 at 3.52.26 PM.png (737×403 px, 33 KB)
link
Screen Shot 2018-11-07 at 3.53.10 PM.png (755×410 px, 74 KB)
link
Screen Shot 2018-11-07 at 3.54.24 PM.png (729×407 px, 33 KB)
link
as expected
Japanese
Screen Shot 2018-11-07 at 3.56.07 PM.png (754×406 px, 43 KB)
link
Screen Shot 2018-11-07 at 3.57.02 PM.png (748×406 px, 23 KB)
link
Screen Shot 2018-11-07 at 3.57.51 PM.png (744×404 px, 64 KB)
link
Screen Shot 2018-11-07 at 3.58.37 PM.png (752×402 px, 42 KB)
link
as expected, still needs translation
Frenchno modal linkno modal linkno modal linkno modal linkno modal appearing due to styling. However, entire text of issue is presented. @alexhollender - any thoughts here? This is okay imo.
Russian
Screen Shot 2018-11-07 at 4.02.47 PM.png (756×407 px, 54 KB)
link
Screen Shot 2018-11-07 at 4.05.08 PM.png (750×404 px, 31 KB)
link
Screen Shot 2018-11-07 at 4.05.50 PM.png (755×409 px, 94 KB)
link
Screen Shot 2018-11-07 at 4.07.19 PM.png (754×406 px, 63 KB)
link
as expected
Italianno modal link(section issues seem to be hidden in Minerva)no modal linkno modal linkmodals do not appear
Chinese
Screen Shot 2018-11-07 at 4.09.08 PM.png (754×404 px, 39 KB)
link
Screen Shot 2018-11-07 at 4.10.15 PM.png (753×409 px, 23 KB)
link
Screen Shot 2018-11-07 at 4.10.55 PM.png (751×415 px, 113 KB)
link
Screen Shot 2018-11-07 at 4.11.45 PM.png (753×408 px, 39 KB)
link
as expected
Portugueseno modal linkno modal linkno modal linkno modal linkno modals appear/new page issues styles are not taking effect
Polish
Screen Shot 2018-11-07 at 4.14.31 PM.png (754×408 px, 40 KB)
link
Screen Shot 2018-11-07 at 4.15.22 PM.png (758×413 px, 36 KB)
link
Screen Shot 2018-11-07 at 4.16.06 PM.png (759×484 px, 86 KB)
link
Screen Shot 2018-11-07 at 4.16.41 PM.png (742×406 px, 40 KB)
link
as expected
ovasileva claimed this task.

Modals working as expected. Resolving. @alexhollender where page issues styling is not applied, modals do not appear. Feel free to reopen if you think this is a blocker.