Page MenuHomePhabricator

No way to reach the editable version of a page when viewing the most recent mobile diff
Open, HighPublic3 Story Points

Description

We will allow users to navigate from a diff to the latest revision (to view source at the time of the edit) as well as the page itself (to edit the current version). This is not possible with the current UI.

Description

On older revisions, which are not the most recent, the link Latest revision (which is not available here, as we are on the most recent revision) actually goes to the article, not the most recent revision. So one can go back one diff and then go to the article, or switch to a different language and then back, but both are clearly not intuitive.

Clicking on current revision leads to a help page, which is not very intuitive in this context.

What we do on desktop for reference:

Design

Acceptance criteria

  • The new links show on all diffs - should with AMC enabled and should with AMC disabled.

QA Steps

  1. Go to a random article
  2. Scroll down to reach the page history
  3. Click the most recent entry in the page history, arriving at the mobile diff
  4. Imagine that you came here via your watchlist
  5. Click on the page title to reach the view of current revision
  6. Note that there are "edit pens", but one can only view the source, not edit (which makes sense on old revisions)

Expected: There is a way to reach the article page to see its current state and edit (i.e. without oldid attached to the URL)

Actual: There is no way to do that. The navigation box has no links to it:

Developer notes

Code changes will need to be made in includes/specials/SpecialMobileDiff.php and CSS changes in resources/mobile.special.mobilediff.styles/

Further background

See also T200804 and T200805.

Event Timeline

Cirdan created this task.Aug 2 2018, 4:40 AM
Cirdan updated the task description. (Show Details)
Jdlrobson moved this task from Backlog to Tracking on the MobileFrontend board.Oct 18 2018, 7:00 PM
Gareth added a subscriber: Gareth.Oct 26 2018, 1:36 AM

@alexhollender, the steps to reproduce appear to be:

  1. Click on https://m.mediawiki.org/w/index.php?oldid=2934863#/editor/0
  2. Oops, that's broken.

That link is (currently) the most recent version, and the page is not protected. But the mobile site is refusing to open the mobile editor so you can edit it. It is incorrectly treating the page like it's fully protected.

Jdlrobson added a comment.EditedNov 2 2018, 8:01 PM

Exactly. Most simple thing to do here is check that the revision matches the current one and show view source only for non matching revisions. Interestingly it only impacts the source editor (i can still edit in ve )

A more ambitious idea might be to allow editing of all revisions... could be useful for rollback and undo features but the editor should make clear what's being edited to avoid mistakes

Jdlrobson triaged this task as Normal priority.Nov 5 2018, 3:31 PM
Jdlrobson added a subscriber: ovasileva.

@ovasileva we are having a few bug reports about this. High priority may make sense here..

@Jdlrobson thoughts on T200969#4589239? Maybe I'm misunderstanding the issue...

ovasileva raised the priority of this task from Normal to High.Nov 5 2018, 4:25 PM
pajz added a subscriber: pajz.Mar 14 2019, 7:02 PM
MusikAnimal added a subscriber: MusikAnimal.

@Cirdan would what we do on desktop work here?

Sorry for the late response.

Personally, I think that if one arrives at the latest revision of a page, the "navigation box" should not be shown at all, but instead the page itself should be shown. In other words: Don't display the revision, but display the page.

One often wants to read/edit a page, but less often wants to navigate through old revisions. If the latter is the case, the box is quite useless on mobile, as it is very difficult to click the small links (it also doesn't fit the style). If I really need to go through revisions, I use the mobile diff view, which is both easy to navigate and provides the much better UX.

@Cirdan Is it ever the case you need to view the source associated with the article? If so under what circumstances? From what I am hearing Alex, it does sound like the default behaviour should be to link to the article, but maybe 2 links are needed here?

Crude mock up (note the rev. link):


"Prince Albert..." would link to the current revision, rev. 589.. would link to the old revision (which seems like a lesser needed usecase)

alexhollender added a comment.EditedMar 19 2019, 7:46 PM

@Jdlrobson helped me better understand the issue here. Starting with what we do on vector/desktop:

@Cirdan would this be an acceptable mobile equivalent?

Cirdan added a comment.EditedMar 20 2019, 7:29 AM

@Cirdan Is it ever the case you need to view the source associated with the article? If so under what circumstances?

Usually not. When I'm looking at a diff and want to reach the article, I usually want to see the most recent version, either to check how the change affects the article or to add a reply to an ongoing discussion. Either way, I want to reach the current version and be able to edit it.

This is different from my workflow on the desktop version, where I have the option to revert changes from the diff and can also edit old versions to restore a past state. I guess what's important to consider here is that experienced editors can in most cases visualize the changes made to an article, while new editors might be more likely to want to see a rendered version of an intermediate state.

@Jdlrobson based on our conversation I feel good about the design I posted in T200969#5038114. @Cirdan any additional feedback on that? Otherwise I think we're all set on design.

Jdlrobson updated the task description. (Show Details)Thu, Mar 28, 8:23 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to Upcoming on the Readers-Web-Backlog board.
Jdlrobson updated the task description. (Show Details)Tue, Apr 2, 4:14 PM
Jdlrobson set the point value for this task to 3.Tue, Apr 2, 4:18 PM
Jdrewniak claimed this task.Thu, Apr 4, 1:23 PM

Change 502191 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/MobileFrontend@master] Add link to current article from Special:MobileDiff page

https://gerrit.wikimedia.org/r/502191

Change 502191 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add link to current article from Special:MobileDiff page

https://gerrit.wikimedia.org/r/502191

pmiazga reassigned this task from Edtadros to alexhollender.Fri, Apr 19, 4:44 PM
pmiazga added a subscriber: Edtadros.

This task didn't have design review yet, moving it to "Needs design review".

Edtadros reassigned this task from Edtadros to Niedzielski.Thu, Apr 25, 10:30 PM
Edtadros added a subscriber: Niedzielski.

Test Result

Status:
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

  1. Go to a random article
  2. Scroll down to reach the page history
  3. Click the most recent entry in the page history, arriving at the mobile diff
  4. Imagine that you came here via your watchlist
  5. Click on the page title to reach the view of current revision
  6. Note that there are "edit pens", but one can only view the source, not edit (which makes sense on old revisions)

Expected: There is a way to reach the article page to see its current state and edit (i.e. without oldid attached to the URL)

Actual: There is no way to do that. The navigation box has no links to it:

@Niedzielski need a few clarifications

  1. I assumed this was to be tested in staging based on T200969#5125651 even though the link in the QA steps points to prod. I did this because I was making edits. Please let me know if this is the right place to test.
  2. At first, I thought the verification was step 6, but I'm not sure based on the Expected and Actual. Please confirm what the validation should be.
  3. The Acceptance Criteria state this should be with AMC enabled and disabled, so I did it twice...I'm pretty confident about this :)

Here are both runs:

AMC Enabled:

AMC Disabled: