Page MenuHomePhabricator
Create Task
Maniphest T209525

Migrate tag_summary usage to change_tag and drop the table
Closed, ResolvedPublic
Actions

Description

Now, API modules for recent change use tag_summary but the special page itself uses change_tag table. This means API and GUI are reading from different backend.
Also with T185355: Normalize change tag schema, change_tag is getting nimble and more suitable to be used as it's get automatically pulled into the memory.

It seems the reason for having it in the first place was (from tables.sql):

-- Rollup table to pull a LIST of tags simply without ugly GROUP_CONCAT
-- that only works on MySQL 4.1+

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Drop tag_summary and valid_tag tablesmediawiki/coremaster+11 -143
Stop updating tag_summary tablemediawiki/coremaster+125 -89
Migrate SpecialUndelete and Diff from tag_summary to change_tagmediawiki/coremaster+45 -12
Remove 'valid_tag' from tablesUsed in testsmediawiki/extensions/FlaggedRevsmaster+0 -1
Migrate WatchedItemQueryService from tag_summary to change_tagmediawiki/coremaster+1 -7
Migrate Api modules from tag_summary table to change_tagmediawiki/coremaster+7 -33
Migrate AbuseFilterConsequencesTest from tag_summary to change_tagmediawiki/extensions/AbuseFiltermaster+19 -8
Split ChangeTags::modifyDisplayQuery() to two smaller functionsmediawiki/coremaster+45 -15
Migrate ApiQueryLogEvents from tag_summary to change_tagmediawiki/coremaster+1 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Nov 14 2018, 7:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2018, 7:22 PM
Ladsgroup added a comment.Nov 14 2018, 7:22 PM

Should I turn this into an RFC?

gerritbot subscribed.Nov 14 2018, 8:54 PM

Change 473611 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Split ChangeTags::modifyDisplayQuery() to two smaller functions

https://gerrit.wikimedia.org/r/473611

gerritbot added a project: Patch-For-Review.Nov 14 2018, 8:54 PM
gerritbot added a comment.Nov 14 2018, 9:22 PM

Change 473617 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Migrate ApiQueryLogEvents from tag_summary to change_tag

https://gerrit.wikimedia.org/r/473617

gerritbot added a comment.Nov 27 2018, 12:33 AM

Change 473611 merged by jenkins-bot:
[mediawiki/core@master] Split ChangeTags::modifyDisplayQuery() to two smaller functions

https://gerrit.wikimedia.org/r/473611

gerritbot added a comment.Nov 27 2018, 12:33 AM

Change 473617 merged by jenkins-bot:
[mediawiki/core@master] Migrate ApiQueryLogEvents from tag_summary to change_tag

https://gerrit.wikimedia.org/r/473617

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 27 2018, 1:00 AM
Ladsgroup added a comment.Nov 27 2018, 12:36 PM

Based on https://codesearch.wmflabs.org/search/?q=tag_summary&i=nope&files=&repos=

Core:

  • ApiQueryAllDeletedRevisions.php
  • ApiQueryAllRevisions.php
  • ApiQueryDeletedRevisions.php
  • ApiQueryDeletedrevs.php
  • ApiQueryRecentChanges.php
  • ApiQueryRevisions.php
  • ApiQueryUserContribs.php
  • DifferenceEngine.php
  • SpecialUndelete.php
  • WatchedItemQueryService.php

Abusefilter extension:

  • AbuseFilterConsequencesTest.php
Ladsgroup edited projects, added SRE, DBA; removed Patch-For-Review.Nov 27 2018, 3:58 PM
Ladsgroup added subscribers: Krinkle, • Fjalapeno, • tstarling.

I'm just going to add more people and projects to make sure it reaches more audiences, if it requires some formal procedure, let me know.

gerritbot added a comment.Nov 27 2018, 5:12 PM

Change 476058 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Migrate Api modules from tag_summary table to change_tag

https://gerrit.wikimedia.org/r/476058

gerritbot added a project: Patch-For-Review.Nov 27 2018, 5:12 PM
gerritbot added a comment.Nov 27 2018, 5:20 PM

Change 476059 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Migrate WatchedItemQueryService from tag_summary to change_tag

https://gerrit.wikimedia.org/r/476059

gerritbot added a comment.Nov 27 2018, 5:49 PM

Change 476069 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Migrate SpecialUndelete and Diff from tag_sumaary to change_tag

https://gerrit.wikimedia.org/r/476069

gerritbot added a comment.Nov 27 2018, 5:56 PM

Change 476073 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/AbuseFilter@master] Migrate AbuseFilterConsequencesTest from tag_summary to change_tag

https://gerrit.wikimedia.org/r/476073

Ladsgroup claimed this task.Nov 27 2018, 6:10 PM
Ladsgroup added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptNov 27 2018, 6:10 PM
gerritbot added a comment.Nov 28 2018, 7:52 AM

Change 476073 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Migrate AbuseFilterConsequencesTest from tag_summary to change_tag

https://gerrit.wikimedia.org/r/476073

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 28 2018, 8:01 AM
Ladsgroup mentioned this in T136687: Database error when filtering page log.Nov 28 2018, 8:13 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 29 2018, 11:47 AM
• Banyek subscribed.Nov 29 2018, 2:50 PM

Do you need anything from our side this moment @Ladsgroup ?

• Banyek moved this task from Triage to In progress on the DBA board.Nov 29 2018, 2:50 PM
Ladsgroup added a comment.Nov 29 2018, 2:56 PM
In T209525#4785174, @Banyek wrote:

Do you need anything from our side this moment @Ladsgroup ?

Not yet but I will make the patches to drop the table completely in the next weeks or so. Then it would be great if you implement the schema change.

• Marostegui subscribed.Nov 29 2018, 3:15 PM

Which schema change?

Ladsgroup added a comment.Nov 29 2018, 3:17 PM
In T209525#4785305, @Marostegui wrote:

Which schema change?

DROP TABLE tag_summary

I hasn't made the patch for it (yet). Waiting for the other patches that use this table to get merged first.

• Marostegui added a comment.Nov 29 2018, 3:18 PM
In T209525#4785310, @Ladsgroup wrote:
In T209525#4785305, @Marostegui wrote:

Which schema change?

DROP TABLE tag_summary

I hasn't made the patch for it (yet). Waiting for the other patches that use this table to get merged first.

Ah right - I thought you referred to some ALTER
Thanks for clearing this up

nshahquinn-wmf mentioned this in T210807: Update editor_month generation to use change_tag table rather than tag_summary.Nov 29 2018, 11:06 PM
• Marostegui edited projects, added User-Marostegui; removed DBA, SRE.Nov 30 2018, 6:29 AM

I am going to remove the DBA and Operations tag from here as there is no action item here until the DROP TABLE is issued - we will remain subscribed to the task though.
Thanks for working on this!

gerritbot added a comment.Nov 30 2018, 7:13 PM

Change 476058 merged by jenkins-bot:
[mediawiki/core@master] Migrate Api modules from tag_summary table to change_tag

https://gerrit.wikimedia.org/r/476058

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 3 2018, 3:59 PM
gerritbot added a comment.Dec 4 2018, 10:17 AM

Change 476059 merged by jenkins-bot:
[mediawiki/core@master] Migrate WatchedItemQueryService from tag_summary to change_tag

https://gerrit.wikimedia.org/r/476059

Ladsgroup updated the task description. (Show Details)Dec 4 2018, 11:41 AM
gerritbot added a comment.Dec 4 2018, 6:50 PM

Change 477610 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Stop updating tag_summary table

https://gerrit.wikimedia.org/r/477610

gerritbot added a comment.Dec 4 2018, 6:52 PM

Change 477611 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/FlaggedRevs@master] Remove 'valid_tag' from tablesUsed in tests

https://gerrit.wikimedia.org/r/477611

gerritbot added a comment.Dec 10 2018, 5:38 PM

Change 477611 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove 'valid_tag' from tablesUsed in tests

https://gerrit.wikimedia.org/r/477611

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 10 2018, 6:29 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
gerritbot added a comment.Dec 12 2018, 7:21 PM

Change 479266 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Drop tag_summary and valid_tag tables

https://gerrit.wikimedia.org/r/479266

gerritbot added a comment.Dec 12 2018, 10:30 PM

Change 476069 merged by jenkins-bot:
[mediawiki/core@master] Migrate SpecialUndelete and Diff from tag_summary to change_tag

https://gerrit.wikimedia.org/r/476069

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 12 2018, 11:00 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 14 2018, 11:50 AM
gerritbot added a comment.Dec 17 2018, 12:48 PM

Change 477610 merged by jenkins-bot:
[mediawiki/core@master] Stop updating tag_summary table

https://gerrit.wikimedia.org/r/477610

Addshore updated the task description. (Show Details)Dec 18 2018, 10:25 AM
Addshore triaged this task as Medium priority.Dec 18 2018, 10:38 AM
gerritbot added a comment.Dec 18 2018, 9:00 PM

Change 479266 merged by jenkins-bot:
[mediawiki/core@master] Drop tag_summary and valid_tag tables

https://gerrit.wikimedia.org/r/479266

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 18 2018, 9:01 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 18 2018, 9:01 PM
Ladsgroup added a subtask: T212255: Drop tag_summary table.Dec 18 2018, 9:09 PM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 20 2018, 11:23 AM
• Marostegui changed the status of subtask T212255: Drop tag_summary table from Open to Stalled.Dec 20 2018, 12:19 PM
Ladsgroup changed the status of subtask T212255: Drop tag_summary table from Stalled to Open.Jan 2 2019, 4:10 PM
Ladsgroup mentioned this in T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking).Jan 11 2019, 7:19 PM
• Marostegui closed subtask T212255: Drop tag_summary table as Resolved.Jan 21 2019, 6:49 AM
Ladsgroup closed this task as Resolved.Jan 21 2019, 10:14 AM
Ladsgroup removed a project: Patch-For-Review.
Ladsgroup updated the task description. (Show Details)
Ciencia_Al_Poder subscribed.Aug 12 2019, 9:44 AM

The update.php script breaks when upgrading from ancient MediaWiki versions. See T230317: Error: 1146 Table 'valid_tag' doesn't exist when upgrading from an ancient MediaWiki version

Aklapper removed subscribers: • Banyek, Anomie.Oct 16 2020, 5:41 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL