Properly initialize depicts widget on page without existing depicts items
Closed, ResolvedPublic
Actions

Description

Getting this error on beta commons right now, on a page where there is no existing depicts item:

load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=0sgfkzu:51 jQuery.Deferred exception: Cannot read property 'indexOf' of undefined TypeError: Cannot read property 'indexOf' of undefined
    at MediaInfoStatementsItemWidget.statements.ItemWidget.buildTitle (<anonymous>:684:450)
    at <anonymous>:684:255
    at mightThrow (https://commons.wikimedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=0sgfkzu:48:856)
    at process (https://commons.wikimedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=0sgfkzu:49:516) undefined

I suspect this is just a case of attempting to setData() with incomplete/missing data, or setData() incorrectly processing such data.

Details

	Subject	Repo	Branch	Lines +/-
	Delete statements on 'publish' when editing depicts on File page	mediawiki/extensions/WikibaseMediaInfo	master	+58 -13

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Resolved		• Ramsey-WMF	T199352 Deploy Structured Data on Commons with arbitrary Statements
Resolved		Cparle	T204264 "Depicts crawling": Add displaying/editing statements to File page
Resolved		matthiasmullie	T215924 Properly initialize depicts widget on page without existing depicts items

Event Timeline

matthiasmullie triaged this task as High priority.Feb 12 2019, 4:37 PM

matthiasmullie created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2019, 4:37 PM

Cparle subscribed.Feb 12 2019, 4:52 PM

Update:

Current error msg:

jQuery.Deferred exception: Cannot read property 'indexOf' of undefined TypeError: Cannot read property 'indexOf' of undefined
    at MediaInfoStatementsItemWidget.statements.ItemWidget.renderInternal (<anonymous>:685:176)
    at mightThrow (https://commons.wikimedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=0r9qulh:48:856)
    at process (https://commons.wikimedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=0r9qulh:49:516) undefined

Fix for this has been rolled into https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/490584

matthiasmullie moved this task from To Do to Doing on the Structured Data Engineering board.Feb 14 2019, 3:46 PM

Change 490584 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Delete statements on 'publish' when editing depicts on File page

https://gerrit.wikimedia.org/r/490584

gerritbot added a project: Patch-For-Review.Feb 14 2019, 5:11 PM

Cparle mentioned this in rEWBI673f8f98372b: Delete statements on 'publish' when editing depicts on File page.Feb 14 2019, 5:14 PM

Cparle mentioned this in rEWBI67cc0401f4a9: Delete statements on 'publish' when editing depicts on File page.Feb 14 2019, 5:36 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Feb 14 2019, 6:20 PM

matthiasmullie mentioned this in rEWBI33c06cd3a1cc: Delete statements on 'publish' when editing depicts on File page.Feb 14 2019, 7:06 PM

matthiasmullie moved this task from Doing to Verify on Production on the Structured Data Engineering board.Feb 14 2019, 8:13 PM

Change 490584 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Delete statements on 'publish' when editing depicts on File page

https://gerrit.wikimedia.org/r/490584

Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.18; 2019-02-19); removed Patch-For-Review.Feb 14 2019, 8:29 PM

Jdforrester-WMF mentioned this in T216288: JSON.parse error while initialising module 'wikibase.mediainfo.filePageDisplay'.Feb 15 2019, 10:15 PM

MarkTraceur edited projects, added Structured Data Engineering (Depicts-Crawling); removed Structured Data Engineering.Feb 19 2019, 8:25 PM

MarkTraceur moved this task from To Do to Sign off on the Structured Data Engineering (Depicts-Crawling) board.

Cparle closed this task as Resolved.Feb 21 2019, 11:10 AM

• Phabricator_maintenance added a project: SDC-Statements (Depicts-Crawling).Mar 7 2019, 12:35 AM

greg added a project: Structured-Data-Team-Current-Work.Mar 7 2019, 10:59 PM